Skip to content

Mark profiling type as technical preview#507

Merged
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:profiling-data-type-tech-preview
Apr 20, 2023
Merged

Mark profiling type as technical preview#507
jsoriano merged 3 commits intoelastic:mainfrom
jsoriano:profiling-data-type-tech-preview

Conversation

@jsoriano
Copy link
Copy Markdown
Member

New data stream type added in #503 is intended for a package that may never be released as GA. Set this type as technical preview so we can also remove it if not needed anymore in the future.

@jsoriano jsoriano requested a review from inge4pres April 20, 2023 10:13
@jsoriano jsoriano requested a review from a team as a code owner April 20, 2023 10:13
@jsoriano jsoriano self-assigned this Apr 20, 2023
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-20T11:43:49.486+0000

  • Duration: 7 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 766
Skipped 0
Total 766

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 67.857% (19/28) 👎 -2.513
Classes 75.676% (28/37) 👎 -2.102
Methods 54.237% (64/118) 👎 -0.935
Lines 41.336% (594/1437) 👎 -1.142
Conditionals 100.0% (0/0) 💚

Comment on lines +5 to +13
- input: pf-elastic-symbolizer
title: Universal Profiling Symbols
description: "Collect debug symbols for native binaries"
enabled: true
- input: logfile
title: Sample logs
description: Collect sample logs
vars:
- name: paths
type: text
title: Paths
multi: true
default:
- /var/log/*.log
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we are removing this?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recreated the package from scratch to fill some missing files and forgot to recover this content. Fixed.

mrodm
mrodm previously approved these changes Apr 20, 2023
Copy link
Copy Markdown
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsoriano jsoriano merged commit 5436521 into elastic:main Apr 20, 2023
@mrodm mrodm mentioned this pull request Feb 18, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants