update google java format dependency #13700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test this please |
|
@elasticsearchmachine run elasticsearch-ci/docs |
robbavey
added a commit
that referenced
this pull request
Mar 1, 2022
After #13700 updated google-java-format dependency, it is now required to add a number of `--add-export` flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still work
9 tasks
robbavey
added a commit
that referenced
this pull request
Mar 22, 2022
After #13700 updated google-java-format dependency, it is now required to add a number of `--add-export` flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still work
robbavey
added a commit
that referenced
this pull request
Mar 22, 2022
After #13700 updated google-java-format dependency, it is now required to add a number of `--add-export` flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still work
robbavey
added a commit
that referenced
this pull request
Mar 22, 2022
After #13700 updated google-java-format dependency, it is now required to add a number of `--add-export` flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still work
robbavey
added a commit
that referenced
this pull request
Mar 24, 2022
After #13700 updated google-java-format dependency, it is now required to add a number of `--add-export` flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still work
robbavey
added a commit
that referenced
this pull request
Mar 24, 2022
…13825) * [Java17] Add `--add-export` settings to restore JDK17 compatibility After #13700 updated google-java-format dependency, it is now required to add a number of `--add-export` flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still work * Move mandatory JVM options out of `jvm.options` and into JvmOptionsParser Certain values for the JVM are mandatory for Logstash to function correctly. Rather than leave them in config/jvm.options where they can be updated, and can cause upgrade issues for users when we add new mandatory options, move them into code where they cannot be changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of google-java-format 1.8 and above no longer depend on the gpl2 javac-shaded jar, so we can upgrade.