-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java17] Add --add-export
settings to restore JDK17 compatibility
#13825
Conversation
|
I don't believe we can - the error message we get is
referring to an unnamed module. The extra additions made here are directly from the release notes for the library that causes this issue.
That's probably not a bad idea. Once I'm confident this fixes the issue, I'll take a look at maybe adding this to the JvmOptionsParser? (and maybe include regex.interruptible as well...) |
It looks like in order to be more refined than |
Jenkins test this please |
After #13700 updated google-java-format dependency, it is now required to add a number of `--add-export` flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still work
…rser Certain values for the JVM are mandatory for Logstash to function correctly. Rather than leave them in config/jvm.options where they can be updated, and can cause upgrade issues for users when we add new mandatory options, move them into code where they cannot be changed
@yaauie Apologies for the delay, ready for another round of reviews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💫
After #13700 updated google-java-format dependency, it is now required to add a number of
--add-export
flags in order to run on JDK17. This commit adds these flags to the jvm options for a running logstash, and to the tests running on gradle to enable tests to still workRelease notes
Note: If you use custom
jvm.options
, you will need to add the following settings toconfig.jvm.options
to allow Logstash to start:Why is it important/What is the impact to the user?
Without these additional settings, logstash will not start, and tests will fail.
Checklist
Author's Checklist
How to test this PR locally
LS_JAVA_HOME
bin/logstash
with a simple pipeline including at least one filterRelated issues
Closes #13819
Relates #13700
Relates logstash-plugins/logstash-filter-kv#98