remove google java formatter dependency

[jsvd]

No description provided.

[jsvd]

@colinsurprenant you've been around the compilation code recently, what do you think here about the need of this dependency? if this is being used to avoid cache invalidation, in what scenarios does it do that?

This dependency was introduced in #8913

[colinsurprenant]

Good question, will investigate.

[colinsurprenant]

@jsvd This is used to do generated source code formatting and in that respect insures that 2 equivalent code generation will yield the same text+formatting. I see that the note about licensing :

WARNING: DO NOT UPGRADE "google-java-format"
later versions require GPL licensed code in javac-shaded that is
Apache2 incompatible

I just verified that and starting at v1.8 they removed that GPL dependency we should be good to upgrade to latest v1.9 without incompatible license dependency.

I think we can close this and create a new PR to upgrade google-java-format.

[colinsurprenant]

Created #12223 to upgrade to latest versions.

[jsvd]

@colinsurprenant I believe that version only works with Java >= 9, which is why we didn’t upgrade

[colinsurprenant]

Good catch. I can't find clear indications for the Java version requirements but looking at https://github.com/google/google-java-format/releases all I see is that v1.8 requires JDK 11.

Short of upgrading the library because of minimum JDK requirements we can either keep the current version or remove it altogether as you suggest here but by doing so we also will loose readable formatting on the generated sources which is useful when developing/debugging. I don't think that removing the formatter will break caching but I don't know for sure.

[andsel]

Here we should upgrade to version 1.13.

[andsel]

Left a comment to update the version

[andsel]

Given that it's use for code formatting in debug mode of Janino, we should keep it and update to version 1.13 which still require Java 11 and is In Apache License

[jsvd]

Closing this in favor of #13700