Merged
Conversation
Contributor
|
Can one of the admins verify this patch? |
This was referenced Jan 10, 2017
Contributor
|
jenkins is failing ... its complaining that .rej files are still there .... probably needs to be rebased ? |
Contributor
Author
|
the |
Contributor
|
jenkins, test this |
Contributor
Author
|
I did ran |
scampi
force-pushed
the
jasper/backport/7302/5.x
branch
from
25f8984 to
e415c68
Compare
Backports PR elastic#7302 **Commit 1:** add top_hits aggregation * Original sha: 22bab62 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-05-26T22:02:08Z **Commit 2:** support nested fields * Original sha: 8aef2b8 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-11T14:57:35Z **Commit 3:** added choice of the order and select by default the index pattern associated time field * Original sha: 9791ac5 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-14T21:08:00Z **Commit 4:** improved parameters name and changed aggregation from latest to top to better reflect what this aggregation may accomplish * Original sha: 692f41c * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-22T20:32:12Z **Commit 5:** made variable a constant * Original sha: 39cddab * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-07-01T22:42:13Z **Commit 6:** use shorter name for variable * Original sha: c6494cc * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-07-27T08:50:44Z **Commit 7:** prevent to sort terms on top_hits * Original sha: b365ddc * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-08-28T09:47:47Z **Commit 8:** Added the top_hits agg to line/pie/tile vis. Added support for function in prop_filter to allow more flexibility when filtering the list of values. The _term order is now the default ordering instead of _custom. * Original sha: be44e90 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-09-19T14:53:48Z **Commit 9:** simplified tests * Original sha: 43767f0 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-11T09:29:11Z **Commit 10:** changed as per code review * Original sha: 53469d5 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-11T21:49:36Z **Commit 11:** Top Hit should support all field types on the metric vis * Original sha: 20be950 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-17T21:18:31Z **Commit 12:** renamed metric to top hit * Original sha: 20cbb12 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-17T21:28:30Z **Commit 13:** check if there is any result from buckets * Original sha: b99d6c7 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-18T09:13:19Z **Commit 14:** support scripted fields * Original sha: f79cdc1 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-23T20:58:55Z **Commit 15:** Merge branch 'master' of github.com:elastic/kibana into latest-value * Original sha: 82060ce * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-01T09:47:19Z **Commit 16:** Merge branch 'master' of github.com:elastic/kibana into latest-value * Original sha: 2577298 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-12T11:30:42Z **Commit 17:** - added logic for trying to get the field value from the source or from a doc_values field. - added onlyAggregatable option for a field agg param to decide whether or not to retain only aggregatable fields. * Original sha: 6a2bc01 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-13T12:34:10Z **Commit 18:** improved loops in getValuesAtPath method * Original sha: 991864c * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-16T10:10:28Z **Commit 19:** Merge branch 'master' of github.com:elastic/kibana into latest-value * Original sha: bc1c90a * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-17T23:51:13Z **Commit 20:** do not try to get the doc_values field of an IP field * Original sha: d697f11 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-18T00:49:34Z **Commit 21:** improved field tests on the onlyAggregatable option * Original sha: c2249e5 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-18T01:08:34Z **Commit 22:** use indexPattern.formatField to get all the values at a given path * Original sha: f4200e1 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-19T23:02:18Z **Commit 23:** do not show the analyzed warning * Original sha: 2dda53d * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-19T23:30:59Z **Commit 24:** support to sort on scripted field * Original sha: eda9610 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-19T23:52:15Z **Commit 25:** corrected tests and rely on the field's formatter instead of trying to return a nice string * Original sha: b465438 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-20T14:40:43Z **Commit 26:** do not rely on init_default_field_props to set the doc_values property * Original sha: 19e2104 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-21T23:11:29Z **Commit 27:** added test for the doc_values property * Original sha: fd323f3 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-23T10:04:16Z **Commit 28:** Merge branch 'master' of github.com:elastic/kibana into latest-value * Original sha: cfed72e * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-05T15:47:45Z **Commit 29:** - corrected source formatter - add option to show/hide analyzed warning of a field * Original sha: 3090182 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-05T22:40:14Z **Commit 30:** set the default value of the showAnalyzedWarning in fieldparam * Original sha: 0d924fc * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-08T16:29:46Z **Commit 31:** added description of the showAnalyzedWarning option * Original sha: 7f85803 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-08T16:39:07Z **Commit 32:** use aggParam object to access the options of the field parameter * Original sha: ef95ceb * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-09T10:54:51Z **Commit 33:** flattenHit: support object in array * Original sha: b64f92a * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-10T23:36:45Z **Commit 34:** added aggregation option to support multivalued fields and top_hits aggregation with a size different than 1 * Original sha: e18a30d * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-17T13:49:17Z **Commit 35:** disable concatenate aggregation type for visualizations other than table and metric * Original sha: 2a2fa67 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-17T15:00:08Z **Commit 36:** corrected display of arrays in the metric vis * Original sha: eb70e84 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-17T15:27:36Z **Commit 37:** removed condition on the IP field type when retrieving doc values * Original sha: d19ba56 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-17T21:30:47Z **Commit 38:** - do not set a default value for the aggregate with property since it is * Original sha: 66d3b31 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-21T23:04:12Z **Commit 39:** filter out incompatble aggregate options and auto select the option if there is only one * Original sha: 1bd4727 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-28T17:14:21Z **Commit 40:** simplified condition * Original sha: 5babf9a * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-28T23:49:46Z **Commit 41:** lint * Original sha: 7372fce * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-30T19:43:08Z **Commit 42:** fix min/max/sum/average aggregate of elements having only null/undefined values * Original sha: 0791be7 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2017-01-03T10:40:16Z **Commit 43:** added top_hits metric to heatmap visualization * Original sha: c967a23 * Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2017-01-03T11:16:56Z
Contributor
Author
|
@ppisljar I rebased onto 5.x, and it seems fine now: Could you try running the jenkins test one more time ? |
Contributor
|
jenkins, test this |
Contributor
Author
|
I think if failed before because I started this PR based on the previous backport attempt. Sorry about that. |
Contributor
|
no problem, it looks good now .... i'll try to get thru the code today to make sure everything is still as it was. |
Contributor
Author
|
Thanks @ppisljar In those two places, I modified the code from the original commits so that it works with the |
Contributor
|
code looks good, im gonna try few basic use cases now ... shouldn't take long |
Contributor
|
Congratulations once again @scampi ! This will go out with 5.3 if everything 'll be fine. |
Contributor
Author
|
cool! ping me if there is an issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports PR #7302
Commit 1:
add top_hits aggregation
Commit 2:
support nested fields
Commit 3:
added choice of the order and select by default the index pattern associated time field
Commit 4:
improved parameters name and changed aggregation from latest to top to better reflect what this aggregation may accomplish
Commit 5:
made variable a constant
Commit 6:
use shorter name for variable
Commit 7:
prevent to sort terms on top_hits
Commit 8:
Added the top_hits agg to line/pie/tile vis. Added support for function in prop_filter to allow more flexibility when filtering the list of values. The _term order is now the default ordering instead of _custom.
Commit 9:
simplified tests
Commit 10:
changed as per code review
Commit 11:
Top Hit should support all field types on the metric vis
Commit 12:
renamed metric to top hit
Commit 13:
check if there is any result from buckets
Commit 14:
support scripted fields
Commit 15:
Merge branch 'master' of github.com:elastic/kibana into latest-value
Commit 16:
Merge branch 'master' of github.com:elastic/kibana into latest-value
Commit 17:
doc_values field.
or not to retain only aggregatable fields.
Commit 18:
improved loops in getValuesAtPath method
Commit 19:
Merge branch 'master' of github.com:elastic/kibana into latest-value
Commit 20:
do not try to get the doc_values field of an IP field
Commit 21:
improved field tests on the onlyAggregatable option
Commit 22:
use indexPattern.formatField to get all the values at a given path
Commit 23:
do not show the analyzed warning
Commit 24:
support to sort on scripted field
Commit 25:
corrected tests and rely on the field's formatter instead of trying to return a nice string
Commit 26:
do not rely on init_default_field_props to set the doc_values property
Commit 27:
added test for the doc_values property
Commit 28:
Merge branch 'master' of github.com:elastic/kibana into latest-value
Commit 29:
Commit 30:
set the default value of the showAnalyzedWarning in fieldparam
Commit 31:
added description of the showAnalyzedWarning option
Commit 32:
use aggParam object to access the options of the field parameter
Commit 33:
flattenHit: support object in array
Commit 34:
added aggregation option to support multivalued fields and top_hits aggregation with a size different than 1
Commit 35:
disable concatenate aggregation type for visualizations other than table and metric
Commit 36:
corrected display of arrays in the metric vis
Commit 37:
removed condition on the IP field type when retrieving doc values
Commit 38:
Commit 39:
filter out incompatble aggregate options and auto select the option if there is only one
Commit 40:
simplified condition
Commit 41:
lint
Commit 42:
fix min/max/sum/average aggregate of elements having only null/undefined values
Commit 43:
added top_hits metric to heatmap visualization