Skip to content

[5.x] add top_hit metric#9735

Closed
elastic-jasper wants to merge 1 commit into5.xfrom
jasper/backport/7302/5.x
Closed

[5.x] add top_hit metric#9735
elastic-jasper wants to merge 1 commit into5.xfrom
jasper/backport/7302/5.x

Conversation

@elastic-jasper
Copy link
Contributor

@elastic-jasper elastic-jasper commented Jan 4, 2017

add top_hit metric

Backports PR #7302

Commit 1:
add top_hits aggregation

Commit 2:
support nested fields

Commit 3:
added choice of the order and select by default the index pattern associated time field

Commit 4:
improved parameters name and changed aggregation from latest to top to better reflect what this aggregation may accomplish

Commit 5:
made variable a constant

Commit 6:
use shorter name for variable

Commit 7:
prevent to sort terms on top_hits

Commit 8:
Added the top_hits agg to line/pie/tile vis. Added support for function in prop_filter to allow more flexibility when filtering the list of values. The _term order is now the default ordering instead of _custom.

Commit 9:
simplified tests

Commit 10:
changed as per code review

Commit 11:
Top Hit should support all field types on the metric vis

Commit 12:
renamed metric to top hit

Commit 13:
check if there is any result from buckets

Commit 14:
support scripted fields

Commit 15:
Merge branch 'master' of github.com:elastic/kibana into latest-value

Commit 16:
Merge branch 'master' of github.com:elastic/kibana into latest-value

Commit 17:

  • added logic for trying to get the field value from the source or from a
    doc_values field.
  • added onlyAggregatable option for a field agg param to decide whether
    or not to retain only aggregatable fields.

Commit 18:
improved loops in getValuesAtPath method

Commit 19:
Merge branch 'master' of github.com:elastic/kibana into latest-value

Commit 20:
do not try to get the doc_values field of an IP field

Commit 21:
improved field tests on the onlyAggregatable option

Commit 22:
use indexPattern.formatField to get all the values at a given path

Commit 23:
do not show the analyzed warning

Commit 24:
support to sort on scripted field

Commit 25:
corrected tests and rely on the field's formatter instead of trying to return a nice string

Commit 26:
do not rely on init_default_field_props to set the doc_values property

Commit 27:
added test for the doc_values property

Commit 28:
Merge branch 'master' of github.com:elastic/kibana into latest-value

Commit 29:

  • corrected source formatter
  • add option to show/hide analyzed warning of a field

Commit 30:
set the default value of the showAnalyzedWarning in fieldparam

@elastic-jasper
add top_hit metric
0b1eb0d 
Backports PR #7302

**Commit 1:**
add top_hits aggregation

* Original sha: 22bab62
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-05-26T22:02:08Z

**Commit 2:**
support nested fields

* Original sha: 8aef2b8
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-11T14:57:35Z

**Commit 3:**
added choice of the order and select by default the index pattern associated time field

* Original sha: 9791ac5
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-14T21:08:00Z

**Commit 4:**
improved parameters name and changed aggregation from latest to top to better reflect what this aggregation may accomplish

* Original sha: 692f41c
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-06-22T20:32:12Z

**Commit 5:**
made variable a constant

* Original sha: 39cddab
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-07-01T22:42:13Z

**Commit 6:**
use shorter name for variable

* Original sha: c6494cc
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-07-27T08:50:44Z

**Commit 7:**
prevent to sort terms on top_hits

* Original sha: b365ddc
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-08-28T09:47:47Z

**Commit 8:**
Added the top_hits agg to line/pie/tile vis. Added support for function in prop_filter to allow more flexibility when filtering the list of values. The _term order is now the default ordering instead of _custom.

* Original sha: be44e90
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-09-19T14:53:48Z

**Commit 9:**
simplified tests

* Original sha: 43767f0
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-11T09:29:11Z

**Commit 10:**
changed as per code review

* Original sha: 53469d5
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-11T21:49:36Z

**Commit 11:**
Top Hit should support all field types on the metric vis

* Original sha: 20be950
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-17T21:18:31Z

**Commit 12:**
renamed metric to top hit

* Original sha: 20cbb12
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-17T21:28:30Z

**Commit 13:**
check if there is any result from buckets

* Original sha: b99d6c7
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-18T09:13:19Z

**Commit 14:**
support scripted fields

* Original sha: f79cdc1
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-10-23T20:58:55Z

**Commit 15:**
Merge branch 'master' of github.com:elastic/kibana into latest-value

* Original sha: 82060ce
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-01T09:47:19Z

**Commit 16:**
Merge branch 'master' of github.com:elastic/kibana into latest-value

* Original sha: 2577298
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-12T11:30:42Z

**Commit 17:**
- added logic for trying to get the field value from the source or from a
  doc_values field.
- added onlyAggregatable option for a field agg param to decide whether
  or not to retain only aggregatable fields.

* Original sha: 6a2bc01
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-13T12:34:10Z

**Commit 18:**
improved loops in getValuesAtPath method

* Original sha: 991864c
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-16T10:10:28Z

**Commit 19:**
Merge branch 'master' of github.com:elastic/kibana into latest-value

* Original sha: bc1c90a
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-17T23:51:13Z

**Commit 20:**
do not try to get the doc_values field of an IP field

* Original sha: d697f11
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-18T00:49:34Z

**Commit 21:**
improved field tests on the onlyAggregatable option

* Original sha: c2249e5
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-18T01:08:34Z

**Commit 22:**
use indexPattern.formatField to get all the values at a given path

* Original sha: f4200e1
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-19T23:02:18Z

**Commit 23:**
do not show the analyzed warning

* Original sha: 2dda53d
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-19T23:30:59Z

**Commit 24:**
support to sort on scripted field

* Original sha: eda9610
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-19T23:52:15Z

**Commit 25:**
corrected tests and rely on the field's formatter instead of trying to return a nice string

* Original sha: b465438
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-20T14:40:43Z

**Commit 26:**
do not rely on init_default_field_props to set the doc_values property

* Original sha: 19e2104
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-21T23:11:29Z

**Commit 27:**
added test for the doc_values property

* Original sha: fd323f3
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-11-23T10:04:16Z

**Commit 28:**
Merge branch 'master' of github.com:elastic/kibana into latest-value

* Original sha: cfed72e
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-05T15:47:45Z

**Commit 29:**
- corrected source formatter
- add option to show/hide analyzed warning of a field

* Original sha: 3090182
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-05T22:40:14Z

**Commit 30:**
set the default value of the showAnalyzedWarning in fieldparam

* Original sha: 0d924fc
* Authored by Stéphane Campinas <stephane.campinas@gmail.com> on 2016-12-08T16:29:46Z
@elastic-jasper elastic-jasper added backport This PR is a backport of another PR has conflicts labels Jan 4, 2017
@ppisljar ppisljar mentioned this pull request Jan 4, 2017
Merged
3 tasks
@scampi
Copy link
Contributor

scampi commented Jan 5, 2017

I will need some time to figure out what to do, I'll take care of this later today

Running "rejectRejFiles" task
>> .rej files are not allowed:
>> backport--instructions.rej
>> backport-commit-message.rej
>> backport-guided-begin.rej
>> backport-guided-finish.rej
>> backport-wrangle-into-commit.rej
Warning: Task "rejectRejFiles" failed.� Use --force to continue.

@ppisljar
Copy link
Contributor

ppisljar commented Jan 5, 2017 

git fetch upstream jasper/backport/7302/5.x
git checkout jasper/backport/7302/5.x
sh backport-guided-begin.rej

.... resolve conflicts .... once all commits have been mergen and all conflits resolved call

sh backport-guided-finish.rej

@scampi
Copy link
Contributor

scampi commented Jan 6, 2017 •
edited
Loading

There were so many conflicts that the guided backport was impossible.
I chose then the second way and just pulled the changes from 5.x branch.
See #9759 (PR on top of this one). Tell me how this looks...
forget that PR... i'll try to resolve all the conflicts

@scampi
Copy link
Contributor

scampi commented Jan 9, 2017

@ppisljar Is it normal that this backport only contains 30 out of the 46 commits from the #7302 PR ?

@scampi
Copy link
Contributor

scampi commented Jan 10, 2017

@ppisljar please see the PR #9809 with a backport. I changed a bit the guided begin script so that the END commit was actually the last commit of #7302, strange it wasn't.

Could you run the tests on jenkins ? thanks

@ppisljar
Copy link
Contributor

ppisljar commented Jan 11, 2017

@scampi no .... its not normal that its missing commits ... i am taking a look at #9809 ... i can close this one right ?

@scampi
Copy link
Contributor

scampi commented Jan 11, 2017

@ppisljar the PR #9809 is merging onto this branch. Should I change the base of the PR and point it to 5.x ?

@ppisljar
Copy link
Contributor

ppisljar commented Jan 11, 2017

@scampi its up to you, but maybe that's the easiest way to go.

@scampi
Copy link
Contributor

scampi commented Jan 11, 2017

ok done, this can be closed then ;o)

@ppisljar ppisljar closed this Jan 11, 2017
@epixa epixa deleted the jasper/backport/7302/5.x branch January 12, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ppisljar ppisljar

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elastic-jasper @scampi @ppisljar