use angular instead of global window

[scampi]

Chrome 55.0.2883 (Linux 0.0.0) confirmClick directive confirmed "before each" hook for "should trigger window.confirm when clicked" FAILED
	TypeError: Attempted to wrap confirm which is already stubbed
	    at checkWrappedMethod (eval at module.exports (http://localhost:5610/bundles/tests.bundle.js:151488:9), <anonymous>:1329:29)
	    at Object.wrapMethod (eval at module.exports (http://localhost:5610/bundles/tests.bundle.js:151488:9), <anonymous>:1366:21)
	    at Object.stub (eval at module.exports (http://localhost:5610/bundles/tests.bundle.js:151488:9), <anonymous>:3429:26)
	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js:324823:39)
Chrome 55.0.2883 (Linux 0.0.0): Executed 447 of 2667 (1 FAILED) (skipped 6) (0 secs / 11.723 secChrome 55.0.2883 (Linux 0.0.0) confirmClick directive confirmed "after each" hook for "should trigger window.confirm when clicked" FAILED
	TypeError: window.confirm.restore is not a function
	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js:324828:23)
Chrome 55.0.2883 (Linux 0.0.0): Executed 448 of 2667 (2 FAILED) (skipped 6) (0 secs / 11.723 secChrome 55.0.2883 (Linux 0.0.0) confirmClick directive not confirmed "before each" hook for "should not run the click function when canceled" FAILED
	TypeError: Attempted to wrap confirm which is already stubbed
	    at checkWrappedMethod (eval at module.exports (http://localhost:5610/bundles/tests.bundle.js:151488:9), <anonymous>:1329:29)
	    at Object.wrapMethod (eval at module.exports (http://localhost:5610/bundles/tests.bundle.js:151488:9), <anonymous>:1366:21)
	    at Object.stub (eval at module.exports (http://localhost:5610/bundles/tests.bundle.js:151488:9), <anonymous>:3429:26)
	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js:324849:39)
Chrome 55.0.2883 (Linux 0.0.0): Executed 449 of 2667 (3 FAILED) (skipped 6) (0 secs / 11.752 secChrome 55.0.2883 (Linux 0.0.0) confirmClick directive not confirmed "after each" hook for "should not run the click function when canceled" FAILED
	TypeError: window.confirm.restore is not a function
	    at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js:324854:23)

[elasticmachine]

Can one of the admins verify this patch?

[thomasneirynck]

jenkins, test this

[Bargs]

@scampi mind if we close this since it turned out not to be the cause of our failures? Or do you think there's still a bug that needs fixing here?

[trevan]

I see these test failures in FF all the time and this PR fixes them.

[Bargs]

Interesting! I'll take a closer look on monday

[scampi]

@Bargs actually I keep on having this error, I got it again when running tests for #9809.
Anyway, it's better to use $window I think. Also, I don't know how much trust to put into that read-only claim but that'd be another reason to use $window.

Are you using chrome for running the tests ? I have version 55.0.2883.87 (64-bit).

[spalger]

LGTM

[Bargs]

jenkins, test this

[Bargs]

@scampi could you rebase on master? I think that's all we need to get the tests passing. Otherwise LGTM

[spalger]

jenkins, test this

[scampi]

thanks for the rebase @spalger I didn't read @Bargs' request before now