Skip to content

Update dependency @elastic/elasticsearch to v7.13.0-canary.4 (7.x)#97926

Closed
renovate[bot] wants to merge 4 commits into7.xfrom
renovate/7.x-@elasticelasticsearch
Closed

Update dependency @elastic/elasticsearch to v7.13.0-canary.4 (7.x)#97926
renovate[bot] wants to merge 4 commits into7.xfrom
renovate/7.x-@elasticelasticsearch

Conversation

@renovate
Copy link
Copy Markdown
Contributor

@renovate renovate bot commented Apr 21, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@elastic/elasticsearch (source) 7.13.0-canary.1 -> 7.13.0-canary.4 age adoption passing confidence

Release Notes

elastic/elasticsearch-js

v7.13.0-canary.4

Compare Source

v7.13.0-canary.3

Compare Source

v7.13.0-canary.2

Compare Source


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.13.0 labels Apr 21, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@renovate renovate bot requested a review from a team April 21, 2021 22:06
@renovate renovate bot force-pushed the renovate/7.x-@elasticelasticsearch branch from 6e325b6 to c155e06 Compare April 21, 2021 22:51
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Apr 21, 2021

@delvedor it looks like @elastic/elasticsearch-canary@7.13.0-canary.3 has broken types as TS is complaining that the Client class is only a type, and not a concrete class that can be instantiated, which is actually the case.

import { Client } from '@elastic/elasticsearch';

image

from packages/kbn-es-archiver/src/cli.ts

@delvedor
Copy link
Copy Markdown
Member

@spalger thanks for the ping! I've published an update with the fix.

@renovate renovate bot changed the title Update dependency @elastic/elasticsearch to v7.13.0-canary.3 (7.x) Update dependency @elastic/elasticsearch to v7.13.0-canary.4 (7.x) Apr 22, 2021
@renovate renovate bot force-pushed the renovate/7.x-@elasticelasticsearch branch from d26a432 to caf450f Compare April 22, 2021 11:58
@spalger
Copy link
Copy Markdown
Contributor

spalger commented Apr 22, 2021

@elastic/kibana-core Would someone mind taking a look at the type failures here?

@pgayvallet
Copy link
Copy Markdown
Contributor

pgayvallet commented Apr 23, 2021

@spalger I can fix the errors in this PR, now that would force to do the same thing on master once these changes lands in the 8.0.0 canary version we're using on master

Not sure why these type changes are in @elastic/elasticsearch-canary@7.13.0-canary.4 and not in @elastic/elasticsearch-canary@^8.0.0-canary.4? @delvedor?

Or are those real divergences in the ES API between 8.0 and 7.13 (kinda doubt it)?

@pgayvallet
Copy link
Copy Markdown
Contributor

pgayvallet commented Apr 23, 2021

95f9a03 fixes the core types, however that also causes lot of other type failure to appear in plugins code now.

Should I continue on fixing? I feel like we need to do that on master and then backport, somehow.

@kibanamachine

This comment has been minimized.

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Apr 23, 2021

Let's see if this divergence between 7.x and master is intentional, I really don't think we should diverge this much if we can avoid it.

@mshustov
Copy link
Copy Markdown
Contributor

@spalger there is a PR for master #97360. I will send it as soon as I finish with #97222 (Monday, likely)

@mshustov
Copy link
Copy Markdown
Contributor

closed in favor of #98266 with back port to 7.x

@mshustov mshustov closed this May 26, 2021
@mshustov mshustov deleted the renovate/7.x-@elasticelasticsearch branch May 26, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants