Update elasticsearch client version#97360
Conversation
mshustov
added
chore
v8.0.0
release_note:skip
💔 Build Failed
Failed CI Steps
Metrics [docs]
To update your PR or re-run it, just comment with: |
ppisljar
left a comment
ppisljar
left a comment
There was a problem hiding this comment.
app services changes LGTM
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Kibana app changes look great to me! Code review only (removing ts-expect-error)
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
Task manager changes LGTM!
| [index]: { | ||
| aliases: { foo: index }, | ||
| mappings: { dynamic: 'strict', properties: { a: 'b' } }, | ||
| mappings: { dynamic: 'strict', properties: { a: 'b' } as any }, |
There was a problem hiding this comment.
should we fix the mocked result instead of casting it as any? { a: 'b' } doesn't seem to fit any mapping definition.
| index, | ||
| timeout: DEFAULT_TIMEOUT, | ||
| body: mappings, | ||
| body: mappings as estypes.TypeMapping, |
There was a problem hiding this comment.
should we @elastic/elasticsearch? The reason it's failing is that GenericProperty expects all properties to be mandatory.
wylieconlon
left a comment
wylieconlon
left a comment
There was a problem hiding this comment.
Thanks for fixing these errors from the last review!
|
closed in favour of #98266 |
10 participants
Summary
Update
@elastic/elaticsearchto the nextcanaryversion and fix type errors.