Update @elastic/elasticsearch to 8.0.0-canary13 by mshustov · Pull Request #98266 · elastic/kibana

mshustov · 2021-04-26T10:09:16Z

Summary

Update @elastic/elaticsearch to the next canary version and fix type errors.
Most of the changes have been caused by changes in the @elastic/elaticsearch naming schema.

mshustov · 2021-04-26T10:11:53Z

x-pack/plugins/actions/server/saved_objects/index.ts

    hidden: true,
    namespaceType: 'single',
-    mappings: mappings.action,
+    mappings: mappings.action as SavedObjectsTypeMappingDefinition,


mappings imported from json file are inferred with { type: string since we cannot enforce immutability with as const, so I had to cast the type manually

mshustov · 2021-04-26T10:46:25Z

@jgowdyelastic Would you be able to check ML plugin type errors, please?

spong

Security Solution changes LGTM -- thanks @mshustov!

poffdeluxe

Canvas type update LGTM

weltenwort

infra plugin code LGTM - thank you!

I left just a question about a @ts-expect-error below.

weltenwort · 2021-06-07T14:28:14Z

x-pack/plugins/infra/server/services/log_entries/queries/log_entries.ts

      },
-      // @ts-expect-error @elastic/elasticsearch doesn't declare body.fields on AsyncSearchSubmitRequest
      fields,
+      // @ts-expect-error @elastic/elasticsearch expects "runtime" property


Does it? I can find neither runtime_mappings nor runtime on the type. 🤔

Agree, I can't find it anymore. I will update the comment

weltenwort · 2021-06-07T14:28:55Z

x-pack/plugins/infra/server/services/log_entries/queries/log_entry.ts

    },
-    // @ts-expect-error @elastic/elasticsearch doesn't declare body.fields on AsyncSearchSubmitRequest
    fields: ['*'],
+    // @ts-expect-error @elastic/elasticsearch expects "runtime" property


Same was above: Is that message misleading because the type has neither?

TinaHeiligers

LGTM

igoristic

Stack Monitoring changes look good 👍

jen-huang

Fleet changes LGTM

pgayvallet

Note that the name of the branch is misleading

pgayvallet · 2021-06-07T17:53:12Z

src/core/server/saved_objects/mappings/lib/get_root_properties_objects.test.ts

      },
    },
-  };
+  } as const;


NIT: why casting as const instead of const mappings: IndexMapping = ... ? (in some other test files too)

When TS infers a type for an object { type: 'keyword' }, it ends up with { type: string } since the object can be mutated. as const asserts that the object is immutable and the final type will be { type: "keyword" }.

we can do const mappings: IndexMapping =, but it found as const easier to understand 🤷‍♂️

pgayvallet · 2021-06-07T18:00:38Z

src/core/server/saved_objects/mappings/types.ts

-export interface SavedObjectsCoreFieldMapping {
-  type: string;
-  null_value?: number | boolean | string;
-  index?: boolean;


That's probably a good thing to finally get rid of these manually maintained types

pgayvallet · 2021-06-07T18:03:55Z

src/core/server/saved_objects/migrationsv2/actions/remove_write_block.ts

        body: {
-          index: {
+          settings: {
            blocks: {


Is this an actual API change?

According to the Elasticsearch tests, both forms are valid

https://github.com/elastic/elasticsearch/blob/27089e74602dc442656cf97ca4b29af79f724933/qa/full-cluster-restart/src/test/java/org/elasticsearch/upgrades/FullClusterRestartIT.java#L560
https://github.com/elastic/elasticsearch/blob/27089e74602dc442656cf97ca4b29af79f724933/qa/full-cluster-restart/src/test/java/org/elasticsearch/upgrades/FullClusterRestartIT.java#L301

I picked one supported by @elastic/elasticsearch client

pgayvallet · 2021-06-07T18:06:15Z

src/core/server/saved_objects/saved_objects_type_registry.ts

    }
    validateType(type);
-    this.types.set(type.name, deepFreeze(type));
+    this.types.set(type.name, deepFreeze(type) as SavedObjectsType);


What change caused this cast to be required?

I believe it's the fact that SavedObjectsFieldMapping is the union type from now on.

shahzad31

Uptime changes LGTM !!

kibanamachine · 2021-06-08T13:02:47Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`core`	1061	1052	-9
`ml`	283	270	-13
total			-22

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	5.9MB	5.9MB	+243.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`ml`	34	32	-2

Unknown metric groups

API count

id	before	after	diff
`core`	2282	2270	-12
`ml`	287	274	-13
total			-25

History

💔 Build #129716 failed 13cca1f
💚 Build #129448 succeeded d05b773
💔 Build #129419 failed 3909a74
💔 Build #129412 failed 7eec0dd
💔 Build #129175 failed 4d562e5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jgowdyelastic

LGTM

* bump @elastic/elasticsearch to canary.7 * address errors in core * address errors in data plugin * address errors in Alerting team plugins * remove outdated messages in Lens * remove unnecessary comments in ML * address errors in Observability plugin * address errors in reporting plugin * address errors in Rule registry plugin * fix errors in Security plugins * fix errors in ES-UI plugin * remove unnecessary union. * update core tests * fix kbn-es-archiver * update to canary 8 * bump to v9 * use new typings * fix new errors in core * fix errors in core typeings * fix type errors in data plugin * fix type errors in telemetray plugin * fix data plugin tests * fix search examples type error * fix errors in discover plugin * fix errors in index_pattern_management * fix type errors in vis_type_* * fix errors in typings/elasticsearch * fix type errors in actions plugin * fix type errors in alerting and apm plugins * fix type errors in canvas and cases * fix errors in event_log * fix type errors in ILM and ingest_pipelines * fix errors in lens plugin * fix errors in lists plugin * fix errors in logstash * fix errors in metrics_entities * fix errors in o11y * fix errors in watcher * fix errors in uptime * fix errors in upgrade_assistant * fix errors in task_manager * fix errors in stack_alerts * fix errors in security_solution * fix errors in rule_registry * fix errors in snapshot_restore * fix remaining errors * fix search intergration tests * adjust assetion * bump version to canary.10 * adapt code to new naming schema * use mapping types provided by the client library * Revert "adjust assetion" This reverts commit 19b8fe0. * fix so intergration tests * fix http integration tests * bump version to canary 11 * fix login test * fix http integration test * fix apm test * update docs * fixing some ml types * fix new errors in data plugin * fix new errors in alerting plugin * fix new errors in lists plugin * fix new errors in reporting * fix or mute errors in rule_registry plugin * more ML type fixes * bump to canary 12 * fix errors after merge conflict * additional ML fixes * bump to canary 13 * fix errors in apm plugin * fix errors in fleet plugin * fix errors in infra plugin * fix errors in monitoring plugin * fix errors in osquery plugin * fix errors in security solution plugins * fix errors in transform plugin * Update type imports for ES * fix errors in x-pack plugins * fix errors in tests * update docs * fix errors in x-pack/test * update error description * fix errors after master merge * update comment in infra plugin * fix new errors on xpack tests/ Co-authored-by: James Gowdy <jgowdy@elastic.co> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> # Conflicts: # package.json # src/core/server/saved_objects/migrationsv2/integration_tests/migration.test.ts # test/common/services/saved_object_info.ts # x-pack/plugins/snapshot_restore/server/routes/api/repositories.ts # x-pack/plugins/snapshot_restore/server/routes/api/snapshots.ts # yarn.lock

@ts-expect-error

* Update @elastic/elasticsearch to 8.0.0-canary13 (#98266) * bump @elastic/elasticsearch to canary.7 * address errors in core * address errors in data plugin * address errors in Alerting team plugins * remove outdated messages in Lens * remove unnecessary comments in ML * address errors in Observability plugin * address errors in reporting plugin * address errors in Rule registry plugin * fix errors in Security plugins * fix errors in ES-UI plugin * remove unnecessary union. * update core tests * fix kbn-es-archiver * update to canary 8 * bump to v9 * use new typings * fix new errors in core * fix errors in core typeings * fix type errors in data plugin * fix type errors in telemetray plugin * fix data plugin tests * fix search examples type error * fix errors in discover plugin * fix errors in index_pattern_management * fix type errors in vis_type_* * fix errors in typings/elasticsearch * fix type errors in actions plugin * fix type errors in alerting and apm plugins * fix type errors in canvas and cases * fix errors in event_log * fix type errors in ILM and ingest_pipelines * fix errors in lens plugin * fix errors in lists plugin * fix errors in logstash * fix errors in metrics_entities * fix errors in o11y * fix errors in watcher * fix errors in uptime * fix errors in upgrade_assistant * fix errors in task_manager * fix errors in stack_alerts * fix errors in security_solution * fix errors in rule_registry * fix errors in snapshot_restore * fix remaining errors * fix search intergration tests * adjust assetion * bump version to canary.10 * adapt code to new naming schema * use mapping types provided by the client library * Revert "adjust assetion" This reverts commit 19b8fe0. * fix so intergration tests * fix http integration tests * bump version to canary 11 * fix login test * fix http integration test * fix apm test * update docs * fixing some ml types * fix new errors in data plugin * fix new errors in alerting plugin * fix new errors in lists plugin * fix new errors in reporting * fix or mute errors in rule_registry plugin * more ML type fixes * bump to canary 12 * fix errors after merge conflict * additional ML fixes * bump to canary 13 * fix errors in apm plugin * fix errors in fleet plugin * fix errors in infra plugin * fix errors in monitoring plugin * fix errors in osquery plugin * fix errors in security solution plugins * fix errors in transform plugin * Update type imports for ES * fix errors in x-pack plugins * fix errors in tests * update docs * fix errors in x-pack/test * update error description * fix errors after master merge * update comment in infra plugin * fix new errors on xpack tests/ Co-authored-by: James Gowdy <jgowdy@elastic.co> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co> # Conflicts: # package.json # src/core/server/saved_objects/migrationsv2/integration_tests/migration.test.ts # test/common/services/saved_object_info.ts # x-pack/plugins/snapshot_restore/server/routes/api/repositories.ts # x-pack/plugins/snapshot_restore/server/routes/api/snapshots.ts # yarn.lock * revert @ts-expect-error changes in infra plugin * update docs

mshustov added 13 commits April 26, 2021 12:07

bump @elastic/elasticsearch to canary.7

501dc8f

address errors in core

f54192e

address errors in data plugin

2db55e3

address errors in Alerting team plugins

e8f4424

remove outdated messages in Lens

5a06616

remove unnecessary comments in ML

2201e25

address errors in Observability plugin

2815faa

address errors in reporting plugin

1171f07

address errors in Rule registry plugin

adcb00f

fix errors in Security plugins

911bdd3

fix errors in ES-UI plugin

c6ccefb

remove unnecessary union.

a79ded4

update core tests

78e0b57

mshustov added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 labels Apr 26, 2021

mshustov requested review from a team as code owners April 26, 2021 10:09

mshustov requested a review from a team April 26, 2021 10:09

mshustov requested review from a team as code owners April 26, 2021 10:09

mshustov mentioned this pull request Apr 26, 2021

Update elasticsearch client version #97360

Closed

mshustov commented Apr 26, 2021

View reviewed changes

mshustov marked this pull request as draft April 26, 2021 10:19

fix kbn-es-archiver

00d8356

alisonelizabeth mentioned this pull request Apr 26, 2021

Investigate @ts-expect-error related to ES client typings #95241

Open

mshustov changed the title ~~Update es 8.0.0-canary13~~ Update @elastic/elasticsearch to 8.0.0-canary13 Jun 7, 2021

update error description

5e6ec78

mshustov mentioned this pull request Jun 7, 2021

Feedback from Kibana v7.13 elastic/elasticsearch-specification#197

Open

54 tasks

spong approved these changes Jun 7, 2021

View reviewed changes

poffdeluxe approved these changes Jun 7, 2021

View reviewed changes

weltenwort approved these changes Jun 7, 2021

View reviewed changes

legrego approved these changes Jun 7, 2021

View reviewed changes

jbudz approved these changes Jun 7, 2021

View reviewed changes

TinaHeiligers approved these changes Jun 7, 2021

View reviewed changes

igoristic approved these changes Jun 7, 2021

View reviewed changes

jen-huang approved these changes Jun 7, 2021

View reviewed changes

pgayvallet approved these changes Jun 7, 2021

View reviewed changes

shahzad31 approved these changes Jun 8, 2021

View reviewed changes

Merge branch 'master' into update-es-to-canary-7

a87d4dd

patrykkopycinski approved these changes Jun 8, 2021

View reviewed changes

fix errors after master merge

7304b6c

mshustov enabled auto-merge (squash) June 8, 2021 09:33

mshustov added 2 commits June 8, 2021 12:41

update comment in infra plugin

13cca1f

fix new errors on xpack tests/

6e549ed

mshustov disabled auto-merge June 8, 2021 13:03

jgowdyelastic approved these changes Jun 8, 2021

View reviewed changes

sorenlouv mentioned this pull request Jun 8, 2021

[APM] Kibana errors on "constructor" keyword in APM stack trace documents #99526

Closed

mshustov merged commit d920682 into elastic:master Jun 8, 2021

mshustov deleted the update-es-to-canary-7 branch June 8, 2021 13:06

mshustov mentioned this pull request Jun 8, 2021

[7.x] Update @elastic/elasticsearch to 8.0.0-canary13 (#98266) #101595

Merged

mshustov mentioned this pull request Jun 9, 2021

Cleanup outdated @elastic/elasticsearch client type errors #101741

Merged

peteharverson mentioned this pull request Jun 9, 2021

[ML] Fixes display of job group badges in recognizer wizard #101775

Merged

1 task

Conversation

mshustov commented Apr 26, 2021 • edited by sorenlouv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshustov commented Apr 26, 2021

Uh oh!

spong left a comment

Choose a reason for hiding this comment

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

weltenwort left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshustov Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TinaHeiligers left a comment

Choose a reason for hiding this comment

Uh oh!

igoristic left a comment

Choose a reason for hiding this comment

Uh oh!

jen-huang left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 8, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Public APIs missing exports

API count

History

Uh oh!

jgowdyelastic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

mshustov commented Apr 26, 2021 •

edited by sorenlouv

Loading

mshustov Jun 8, 2021 •

edited

Loading