[theme] default to v8 theme by spalger · Pull Request #94370 · elastic/kibana

spalger · 2021-03-10T21:12:27Z

Switch the default theme from v7 to v8 in both the optimizer and the uiSettings. See #66673 for information about how to continue building v7 themes for local testing if needed.

spalger · 2021-03-10T21:14:05Z

@cchaos I assume there is another PR that represents the "8.0 theme" which should carry the release notes right? Or should we switch to the release_note:feature? I assume this will be a major part of the release notes for 8.0 but I don't think we need to consider that in this PR.

cchaos · 2021-03-10T21:31:50Z

Yeah this won't be released yet, just turning it on for active development. Most likely a 7.14 release. So we'll put the release notes in that final PR.

spalger · 2021-03-10T21:32:56Z

Okay, I assume that means we'll backport this PR to 7.x once we decide which 7.x version to release this in?

cchaos · 2021-03-10T21:35:35Z

Yep! Looks like you've already added that skip label too. 😄

spalger · 2021-03-16T16:49:17Z

Reaching out to the @elastic/kibana-app team for help with this failing functional test.

…ault-v8-theme

elasticmachine · 2021-03-16T20:40:28Z

Pinging @elastic/kibana-operations (Team:Operations)

spalger · 2021-03-16T20:40:55Z

test/functional/page_objects/visual_builder_page.ts

      await PageObjects.common.sleep(1000);
      const byField = await testSubjects.find('groupByField');
-      await comboBox.setElement(byField, field, { clickWithMouse: true });
+      await comboBox.setElement(byField, field);


Chatted with @stratoula about this fix

x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts

walterra

ML changes LGTM.

pgayvallet

LGTM

src/core/server/ui_settings/settings/theme.ts

…ault-v8-theme

cchaos

I tested this locally. It does in fact default to the K8 theme, with all the correct imports. The Sass mixin still works appropriately and the euiThemeVars utility. Checked all other the themes too. 🎉

🙇 Thank you so much for your help with this one!

kibanamachine · 2021-03-17T16:41:25Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💚 Build #113481 succeeded 2498543
💔 Build #113281 failed 08da6d3
💚 Build #113267 succeeded 3375f212df9251dec54c56db96b24682d78f82d8
💔 Build #113239 failed 75064cd48a54e93b72b9ada460ca3a54e0e1babd
💔 Build #113201 failed 5ac03309017a567198a3d2fd69eca17f85fcadcf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611

Presentation changes lgtm 👍

cchaos · 2021-07-12T16:06:16Z

@spalger Since we actually do want this to be default for 7.14 do we need to create the backport to the 7.14 branch now?

spalger · 2021-07-12T18:47:06Z

@cchaos yep, on it

cchaos · 2021-07-12T18:48:46Z

💯 Thank you!

Co-authored-by: spalger <spalger@users.noreply.github.com> # Conflicts: # packages/kbn-optimizer/src/integration_tests/basic_optimization.test.ts # test/functional/page_objects/visual_builder_page.ts # test/functional/screenshots/baseline/area_chart.png # test/functional/screenshots/baseline/tsvb_dashboard.png # test/interpreter_functional/screenshots/baseline/metric_multi_metric_data.png # x-pack/test/functional/apps/ml/data_frame_analytics/outlier_detection_creation.ts

Co-authored-by: spalger <spalger@users.noreply.github.com>

spalger · 2021-07-12T23:29:39Z

Backported to 7.x and 7.14

## Summary Assign test fixtures, etc to ops team Contributes to: #192979 Assigned `x-pack/test/plugin_functional/screenshots` per #94370

## Summary Assign test fixtures, etc to ops team Contributes to: elastic#192979 Assigned `x-pack/test/plugin_functional/screenshots` per elastic#94370

spalger added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Mar 10, 2021

[theme] default to v8 theme

08da6d3

spalger force-pushed the implement/default-v8-theme branch from 3375f21 to 08da6d3 Compare March 16, 2021 03:19

spalger added 2 commits March 16, 2021 11:12

tsvb failure: remove clickWithMouse when selecting the field

54792ae

Merge branch 'master' of github.com:elastic/kibana into implement/def…

2498543

…ault-v8-theme

spalger marked this pull request as ready for review March 16, 2021 20:40

spalger requested review from a team as code owners March 16, 2021 20:40

spalger commented Mar 16, 2021

View reviewed changes

jbudz approved these changes Mar 16, 2021

View reviewed changes

walterra approved these changes Mar 17, 2021

View reviewed changes

pgayvallet approved these changes Mar 17, 2021

View reviewed changes

src/core/server/ui_settings/settings/theme.ts Outdated Show resolved Hide resolved

spalger added 2 commits March 17, 2021 07:42

remove (beta) label on theme:version setting

595ec38

Merge branch 'master' of github.com:elastic/kibana into implement/def…

e8e2831

…ault-v8-theme

cchaos approved these changes Mar 17, 2021

View reviewed changes

spalger mentioned this pull request Mar 17, 2021

[uiSettings/theme] restrict theme options based on KBN_OPTIMIZER_THEMES #94834

Merged

crob611 approved these changes Mar 17, 2021

View reviewed changes

spalger merged commit 37ff43b into elastic:master Mar 17, 2021

spalger deleted the implement/default-v8-theme branch March 17, 2021 16:49

jsanz mentioned this pull request May 27, 2021

Bump dns-packet and EUI and switch to Amsterdam theme elastic/ems-landing-page#355

Merged

spalger mentioned this pull request Jul 12, 2021

[7.x] [theme] default to v8 theme (#94370) #105290

Merged

spalger mentioned this pull request Jul 12, 2021

[7.14] [theme] default to v8 theme (#94370) #105294

Merged

spalger added v7.14.0 v7.15.0 release_note:enhancement and removed backport:skip This PR does not require backporting release_note:enhancement labels Jul 12, 2021

spalger added a commit that referenced this pull request Jul 12, 2021

[7.x] [theme] default to v8 theme (#94370) (#105290)

6dee8d8

Co-authored-by: spalger <spalger@users.noreply.github.com>

spalger added a commit that referenced this pull request Jul 12, 2021

[7.14] [theme] default to v8 theme (#94370) (#105294)

71d6dc8

Co-authored-by: spalger <spalger@users.noreply.github.com>

wayneseymour mentioned this pull request Nov 18, 2024

[Ownership] Assign test fixtures, etc to ops team #200552

Merged

wayneseymour added a commit that referenced this pull request Nov 19, 2024

[Ownership] Assign test fixtures, etc to ops team (#200552)

4f96b85

## Summary Assign test fixtures, etc to ops team Contributes to: #192979 Assigned `x-pack/test/plugin_functional/screenshots` per #94370

Conversation

spalger commented Mar 10, 2021

Uh oh!

spalger commented Mar 10, 2021

Uh oh!

cchaos commented Mar 10, 2021

Uh oh!

spalger commented Mar 10, 2021

Uh oh!

cchaos commented Mar 10, 2021

Uh oh!

spalger commented Mar 16, 2021

Uh oh!

elasticmachine commented Mar 16, 2021

Uh oh!

spalger Mar 16, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

walterra left a comment

Choose a reason for hiding this comment

Uh oh!

pgayvallet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cchaos left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Mar 17, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

cchaos commented Jul 12, 2021

Uh oh!

spalger commented Jul 12, 2021

Uh oh!

cchaos commented Jul 12, 2021

Uh oh!

spalger commented Jul 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants