Skip to content

Bump dns-packet and EUI and switch to Amsterdam theme#355

Merged
jsanz merged 6 commits intoelastic:masterfrom
jsanz:302-amsterdam
Jul 22, 2021
Merged

Bump dns-packet and EUI and switch to Amsterdam theme#355
jsanz merged 6 commits intoelastic:masterfrom
jsanz:302-amsterdam

Conversation

@jsanz
Copy link
Copy Markdown
Contributor

@jsanz jsanz commented May 27, 2021

Fixes #354
Fixes #302

This PR upgrades to the last EUI version and adds some minor visual changes to accommodate better the layer details and the feature table.

This PR should only be merged once we are sure Kibana gets Amsterdam as default theme by backporting this PR elastic/kibana#94370 to the release branch.

image

@kibanamachine
Copy link
Copy Markdown

💚 Build Succeeded

@jsanz jsanz added dependencies Pull requests that update a dependency file v7.14 labels May 27, 2021
@jsanz jsanz requested a review from nickpeihl July 7, 2021 13:29
@jsanz jsanz marked this pull request as ready for review July 7, 2021 13:29
@jsanz
Copy link
Copy Markdown
Contributor Author

jsanz commented Jul 7, 2021

Since we passed the feature freeze for 7.14 and Kibana is confirmed to be released with the Amsterdam theme, we can update our landing page to include the new theme as well.

@kibanamachine
Copy link
Copy Markdown

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is related to your work or is a problem with EUI, but changing the "Rows per page" did not work for me in Firefox. It works in the production release. Can you confirm @jsanz?

@jsanz
Copy link
Copy Markdown
Contributor Author

jsanz commented Jul 21, 2021

Can you confirm @jsanz?

I can confirm, good catch thanks!! I'm taking a look 👀

@kibanamachine
Copy link
Copy Markdown

💚 Build Succeeded

@jsanz jsanz requested a review from nickpeihl July 21, 2021 16:56
Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks.

@jsanz jsanz merged commit 8477580 into elastic:master Jul 22, 2021
@jsanz jsanz deleted the 302-amsterdam branch July 22, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file v7.14

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate to Amsterdam EUI theme

3 participants