[uiSettings/theme] restrict theme options based on KBN_OPTIMIZER_THEMES#94834
[uiSettings/theme] restrict theme options based on KBN_OPTIMIZER_THEMES#94834spalger merged 8 commits intoelastic:masterfrom
Conversation
spalger
added
Team:Core
spalger
force-pushed
the
implement/restrict-theme-options
branch
3 times, most recently
from
1ce0d2b to
7a6aa3f
Compare
spalger
force-pushed
the
implement/restrict-theme-options
branch
from
7a6aa3f to
83a80c9
Compare
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-core (Team:Core) |
| interface GetCoreSettingsOptions { | ||
| isDist?: boolean; | ||
| } |
There was a problem hiding this comment.
Mostly because this is a temporary thing that I plan to remove once we not longer need to switch back to the v7 theme, so I wanted to avoid updating all the tests which use the getCoreSettings() fn.
There was a problem hiding this comment.
And if you're mostly curious about the property specifically, I didn't really want to push people to define the property if they somehow end up calling getCoreSettings() as I'm not really sure where it's called but the places where it matters the right options are passed.
…/kibana into implement/restrict-theme-options
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…ES (#94834) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
Thanks for this @spalger ! Do you think it would be possible to just disable the option instead of completely remove it? I think it's unclear why there's even a theme setting when there's only one option. |
5 participants
Closes #94817
In development, only expose theme versions which have actually been built to avoid confusing state where v7 theme is selected but not built and things seem broken.