[Discover] Fix link from dashboard saved search to Discover by wylieconlon · Pull Request #92937 · elastic/kibana

wylieconlon · 2021-02-25T23:34:00Z

Steps to test:

Add a saved search to a dashboard
Expand the row and click "view surrounding"
No errors

Also, test:

Add a saved search to a dashboard
Expand the row and click "view single doc"
No errors

Fixes #92904

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-02-25T23:34:02Z

Pinging @elastic/kibana-app (Team:KibanaApp)

majagrubic · 2021-03-01T09:53:48Z

test/functional/apps/context/_discover_navigation.js

      await PageObjects.discover.waitForDocTableLoadingComplete();
    });
+
+    it('navigates to context view from embeddable', async () => {


thanx for adding a functional test!

Thanks!! It also tests the doc view of Discover which seems to be a blind spot in functional testing of Discover (Might be because it was a separate plugin without coverage, migrated to the Discover folder). I think the title should be navigate to doc view from embeddable

majagrubic · 2021-03-01T09:54:22Z

test/functional/apps/discover/_data_grid_context.ts

    });
+
+    // Skipped because there is a bug in the data grid row expansion
+    it.skip('navigates to context view from embeddable', async () => {


should now be safe to unskip (and change to the title to navigate to doc view), since it was resolved in #92999

majagrubic

Tested in Chrome on Mac OS and works as expected. Not sure what the functional test failure is, I haven't found any issues with the context view as such. It there are no actual issues, feel free to merge once that's settled

…t-url

wylieconlon · 2021-03-01T19:56:35Z

I figured out the issue in the tests. There were two problems in the functional test as written:

The test passed before navigating, even though the whole point was to navigate away from dashboard
Even though the next test starts with a navigateToContext section, this section was written using outdated code style and was not actually functioning. So I fixed this first, and then fixed the test itself.

…t-url

wylieconlon · 2021-03-01T22:06:01Z

I previously commented about the outdated code style of the context navigation, but I tried a few variants that didn't work either. So I'm reverting that part of the change. The tests now pass because I fixed the behavior of the Dashboard -> Single doc view, which sets up the next test so it can pass too.

…t-url

kertal · 2021-03-03T15:49:19Z

src/plugins/discover/public/application/angular/doc_table/doc_table.html

            index-pattern="indexPattern"
            filter="filter"
            class="kbnDocTable__row"
+            data-test-subj="docTableRow{{ row['$$_isAnchor'] ? ' docTableAnchorRow' : ''}}"


Nit: docTableAnchorRow should not be necessary here, it's just used in context view and there infinite-scroll is set to true. It's here added to the paginated doc table that's used in the embeddable.

kertal · 2021-03-03T15:51:38Z

src/plugins/discover/public/application/helpers/get_context_url.test.ts

  getGlobalFilters: () => [],
  getAppFilters: () => [],
 } as unknown) as FilterManager;
+const addBasePath = (path: string) => `/base/${path}`;


Nit: /base/${path} -> /base${path} and the expected url would be /base/app/....

kertal

Thanks a lot for fixing this! 👍 Code LGTM, just a few minor comments, tested locally in Safari. works as expected.

kertal · 2021-03-03T15:56:06Z

QQ: @flash1293 there were some redirects for context and doc implemented when we moved this to NP, do you know, were they removed on purpose, because this links used to work recently.

kibanamachine · 2021-03-03T18:30:38Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	401.2KB	401.6KB	+370.0B
`triggersActionsUi`	1.6MB	1.5MB	-23.9KB
total			-23.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	104.0KB	104.1KB	+82.0B

Unknown metric groups

async chunk count

id	before	after	diff
`triggersActionsUi`	41	42	+1

History

💚 Build #110414 succeeded f14d6f0
💚 Build #110126 succeeded 15eddd7
💔 Build #110062 failed b8c8a55
💔 Build #109648 failed 6ed0143

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…92937) * [Discover] Fix link from dashboard saved search to Discover * Fix tests that weren't fully testing the navigation * Fix snapshot * Fix test navigation to context app by reverting to previous * Unskip functional test and fix issue in data grid * Respond to review comments

…93500) * [Discover] Fix link from dashboard saved search to Discover * Fix tests that weren't fully testing the navigation * Fix snapshot * Fix test navigation to context app by reverting to previous * Unskip functional test and fix issue in data grid * Respond to review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…93499) * [Discover] Fix link from dashboard saved search to Discover * Fix tests that weren't fully testing the navigation * Fix snapshot * Fix test navigation to context app by reverting to previous * Unskip functional test and fix issue in data grid * Respond to review comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (48 commits) Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448) [Fleet] Correctly track install status of an integration (elastic#93464) Reviews data frame analytics UI text (elastic#93033) Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280) [Security Solution][Detections] ML Popover overflow fix (elastic#93525) chore(NA): do not use execa on bazel workspace status update script (elastic#93532) Bump dependencies (elastic#93511) [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529) [Security Solution] fix data provider cypress test (elastic#93465) Fix service map for All environment single service (elastic#93517) [Fleet] Fix package version comparaison in the UI (elastic#93498) [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720) [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473) [core-new-docs] Adds a dev-doc for core documentation (elastic#92976) remove opacity from maps legacy style (elastic#93456) [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176) Revert "Make tests deterministic by providing unique timestamps (elastic#93350)" [Discover] Fix link from dashboard saved search to Discover (elastic#92937) update public api docs App Search - Polishing Analytics Views (elastic#92939) ...

[Discover] Fix link from dashboard saved search to Discover

6ed0143

wylieconlon added Feature:Discover Discover Application release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 v7.12.0 v7.13.0 labels Feb 25, 2021

wylieconlon requested review from a team and kertal February 25, 2021 23:34

majagrubic reviewed Mar 1, 2021

View reviewed changes

majagrubic approved these changes Mar 1, 2021

View reviewed changes

wylieconlon added 2 commits March 1, 2021 12:35

Merge remote-tracking branch 'origin/master' into discover/fix-contex…

9f0e123

…t-url

Fix tests that weren't fully testing the navigation

b8c8a55

wylieconlon added 3 commits March 1, 2021 16:06

Merge remote-tracking branch 'origin/master' into discover/fix-contex…

16cc57f

…t-url

Fix snapshot

62791c3

Fix test navigation to context app by reverting to previous

15eddd7

wylieconlon added 2 commits March 2, 2021 11:38

Merge remote-tracking branch 'origin/master' into discover/fix-contex…

b412308

…t-url

Unskip functional test and fix issue in data grid

f14d6f0

kertal reviewed Mar 3, 2021

View reviewed changes

kertal approved these changes Mar 3, 2021

View reviewed changes

Respond to review comments

bad0c13

wylieconlon merged commit 799c05e into elastic:master Mar 3, 2021

wylieconlon deleted the discover/fix-context-url branch March 3, 2021 19:47

wylieconlon mentioned this pull request Mar 3, 2021

[7.x] [Discover] Fix link from dashboard saved search to Discover (#92937) #93499

Merged

wylieconlon mentioned this pull request Mar 3, 2021

[7.12] [Discover] Fix link from dashboard saved search to Discover (#92937) #93500

Merged

Conversation

wylieconlon commented Feb 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

elasticmachine commented Feb 25, 2021

Uh oh!

majagrubic Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

kertal Mar 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majagrubic Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

kertal Mar 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majagrubic left a comment

Choose a reason for hiding this comment

Uh oh!

wylieconlon commented Mar 1, 2021

Uh oh!

wylieconlon commented Mar 1, 2021

Uh oh!

kertal Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

kertal Mar 3, 2021

Choose a reason for hiding this comment

Uh oh!

kertal left a comment

Choose a reason for hiding this comment

Uh oh!

kertal commented Mar 3, 2021

Uh oh!

kibanamachine commented Mar 3, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

async chunk count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wylieconlon commented Feb 25, 2021 •

edited

Loading

kertal Mar 2, 2021 •

edited

Loading

kertal Mar 2, 2021 •

edited

Loading