Skip to content

[Security Solution][Detections] ML Popover overflow fix#93525

Merged
dplumlee merged 4 commits intoelastic:masterfrom
dplumlee:ml-popover-overflow
Mar 4, 2021
Merged

[Security Solution][Detections] ML Popover overflow fix#93525
dplumlee merged 4 commits intoelastic:masterfrom
dplumlee:ml-popover-overflow

Conversation

@dplumlee
Copy link
Contributor

@dplumlee dplumlee commented Mar 3, 2021 •
edited
Loading

Summary

Addresses #89090

Adds a max height to the ML popover on the detections page so that users are able to see the entire popover and access table pagination even if they have a smaller screen.

Note
This is a temporary fix, and we should really consider moving the popover content to something more substantial like a modal or its own page since we're stuffing a bunch of functionality into what is essentially supposed to be a tooltip from a ui perspective.

ml.popover.mov

Checklist

Delete any items that are not applicable to this PR.

  • Documentation was added for features that require explanation or tutorials
  • This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

@dplumlee dplumlee added bug Fixes for quality problems that affect the customer experience v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team v7.13.0 labels Mar 3, 2021
@dplumlee dplumlee self-assigned this Mar 3, 2021
@dplumlee dplumlee marked this pull request as ready for review March 3, 2021 22:25
@dplumlee dplumlee requested a review from a team as a code owner March 3, 2021 22:25
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 3, 2021

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@dplumlee
Copy link
Contributor Author

dplumlee commented Mar 3, 2021

@elasticmachine merge upstream

spong
spong approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 Thanks @dplumlee! 🙂

@spong
Update x-pack/plugins/security_solution/public/common/components/ml_p…
80557d2 
…opover/ml_popover.tsx


Adding some magic! 🎩🐰
@spong spong added auto-backport Deprecated - use backport:version if exact versions are needed v7.12.0 labels Mar 3, 2021
@dplumlee
Copy link
Contributor Author

dplumlee commented Mar 4, 2021

@elasticmachine merge upstream

@dplumlee dplumlee enabled auto-merge (squash) March 4, 2021 00:56
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 4, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 7.8MB 7.8MB +70.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@dplumlee dplumlee merged commit 3316fb4 into elastic:master Mar 4, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 4, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 4, 2021
@dplumlee @spong @kibanamachine
[Security Solution][Detections] ML Popover overflow fix (elastic#93525)
5be6323 
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Mar 4, 2021
@dplumlee @spong @kibanamachine
[Security Solution][Detections] ML Popover overflow fix (elastic#93525)
1742710 
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 4, 2021
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Mar 4, 2021

💚 Backport successful

✅ 7.12 / #93551
✅ 7.x / #93552

Successful backport PRs will be merged automatically after passing CI.

@dplumlee dplumlee deleted the ml-popover-overflow branch March 4, 2021 02:46
kibanamachine added a commit that referenced this pull request Mar 4, 2021
@kibanamachine @dplumlee @spong
[Security Solution][Detections] ML Popover overflow fix (#93525) (#93552
66c30df 
)

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Mar 4, 2021
@kibanamachine @dplumlee @spong
[Security Solution][Detections] ML Popover overflow fix (#93525) (#93551
605e54a 
)

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com>
Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
@gmmorris
Merge branch 'master' into task-manager/docs-monitoring
6a3b8b3 
* master: (48 commits)
  Fix wrong import in data plugin causing 100kB bundle increase (elastic#93448)
  [Fleet] Correctly track install status of an integration (elastic#93464)
  Reviews data frame analytics UI text (elastic#93033)
  Display multiple copyable fields for process.args in resolver node detail panel (elastic#93280)
  [Security Solution][Detections] ML Popover overflow fix (elastic#93525)
  chore(NA): do not use execa on bazel workspace status update script (elastic#93532)
  Bump dependencies (elastic#93511)
  [dev/build_ts_refs] support disabling the ts-refs build completely (elastic#93529)
  [Security Solution] fix data provider cypress test (elastic#93465)
  Fix service map for All environment single service (elastic#93517)
  [Fleet] Fix package version comparaison in the UI (elastic#93498)
  [alerting] adds doc on JSON-expanded action variables and task manager max_workers (elastic#92720)
  [dev/build_ts_refs] ignore type checking failures when building ts refs (elastic#93473)
  [core-new-docs] Adds a dev-doc for core documentation (elastic#92976)
  remove opacity from maps legacy style (elastic#93456)
  [Security Solution][Lists] Escape quotes in list ids and quote the id in KQL query (elastic#93176)
  Revert "Make tests deterministic by providing unique timestamps (elastic#93350)"
  [Discover] Fix link from dashboard saved search to Discover (elastic#92937)
  update public api docs
  App Search - Polishing Analytics Views (elastic#92939)
  ...
@dplumlee dplumlee mentioned this pull request Mar 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spong spong spong approved these changes

Assignees

@dplumlee dplumlee

Labels

auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team v7.12.0 v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dplumlee @elasticmachine @kibanamachine @spong