[Discover] Fix expanding document when using saved search data grid by kertal · Pull Request #92999 · elastic/kibana

kertal · 2021-03-01T08:24:26Z

Summary

On a dashboard, a search embeddable couldn't expand a document. This is fixed by this PR, and covered by a functional test (worked before but was broken with another fix)

Steps to reproduce:

Make sure doc_table:legacy setting is off in Advanced settings
Go to Dashboard
Add Saved Search embeddable
Expand a document of the embeddable
Then you should see the selected document in a flyout.

Fixes #93005
Fixes #92938

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2021-03-01T12:59:12Z

Pinging @elastic/kibana-app (Team:KibanaApp)

kertal · 2021-03-01T13:00:17Z

@elasticmachine merge upstream

…-embeddable-expand-fix

kertal · 2021-03-01T15:22:54Z

@elasticmachine merge upstream

…-embeddable-expand-fix

majagrubic

Tested in Chrome on MAC OS and works as expected.

kertal · 2021-03-01T17:19:32Z

@elasticmachine merge upstream

…-embeddable-expand-fix

ThomThomson

Works as expected, tested locally in chrome.

Also, the data grid is looking great!

wylieconlon

LGTM. I tried to figure out what's causing the functional test failures, but I was not able to.

kertal · 2021-03-02T05:26:36Z

@elasticmachine merge upstream

…-embeddable-expand-fix

kibanamachine · 2021-03-02T07:27:43Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	401.0KB	401.2KB	+173.0B

History

💔 Build #110004 failed 2f42218
💔 Build #109937 failed 38fb3fc
💔 Build #109878 failed b4adcef
💚 Build #109803 succeeded 27f0357

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal

kertal · 2021-03-02T07:31:35Z

LGTM. I tried to figure out what's causing the functional test failures, but I was not able to.

@wylieconlon was the usual flakiness with random tests failing

* master: (42 commits) [Lens] Introduces new chart switcher (elastic#91844) [Lens] fix selection when dragging (elastic#93034) Converts usage collection README to .mdx (elastic#92982) Fix expanding document when using saved search data grid (elastic#92999) [SECURITY SOLUTIONS] Bug case connector (elastic#93104) [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025) [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942) [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139) [DOCS] Fixes links for machine learning alerts (elastic#92744) [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748) [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010) [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095) [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667) Bump ems landing page to 7.12 (elastic#93065) [App Search] Implement various Relevance Tuning states and form actions (elastic#92644) [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760) [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092) Hide instances latency distribution chart (elastic#92869) [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087) [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (elastic#92932) ...

… playwright-ftr-e2e * 'playwright-ftr-e2e' of github.com:shahzad31/kibana: (38 commits) [chore] Enable core's eslint rule: `@ts-expect-error` (elastic#93086) [Lens] Introduces new chart switcher (elastic#91844) [Lens] fix selection when dragging (elastic#93034) Converts usage collection README to .mdx (elastic#92982) Fix expanding document when using saved search data grid (elastic#92999) [SECURITY SOLUTIONS] Bug case connector (elastic#93104) [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (elastic#92025) [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (elastic#92942) [APM] Fix hidden search bar in error pages while loading (elastic#84476) (elastic#93139) [DOCS] Fixes links for machine learning alerts (elastic#92744) [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (elastic#92748) [SecuritySolution][Case] Disable cases on detections in read-only mode (elastic#93010) [Security Solution][Case][Bug] Prevent closing collection when pushing (elastic#93095) [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (elastic#92667) Bump ems landing page to 7.12 (elastic#93065) [App Search] Implement various Relevance Tuning states and form actions (elastic#92644) [actions] for simplistic email servers, set rejectUnauthorized to false (elastic#91760) [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (elastic#93092) Hide instances latency distribution chart (elastic#92869) [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (elastic#93087) ...

… ilm/rollup-v2-action * 'ilm/rollup-v2-action' of github.com:elastic/kibana: (30 commits) Fix expanding document when using saved search data grid (#92999) [SECURITY SOLUTIONS] Bug case connector (#93104) [Security Solution] [Timeline] Bugfix to include unmapped fields in the timeline event details JSON (#92025) [Alerting][Docs] Changed alerting documentation to point to a single source of explaining the configurations. (#92942) [APM] Fix hidden search bar in error pages while loading (#84476) (#93139) [DOCS] Fixes links for machine learning alerts (#92744) [Security Solution][Detections] -Fixes rule edit flow bug with max_signals (#92748) [SecuritySolution][Case] Disable cases on detections in read-only mode (#93010) [Security Solution][Case][Bug] Prevent closing collection when pushing (#93095) [Security Solution][Detections][7.12] Critical Threshold Rule Fixes (#92667) Bump ems landing page to 7.12 (#93065) [App Search] Implement various Relevance Tuning states and form actions (#92644) [actions] for simplistic email servers, set rejectUnauthorized to false (#91760) [Security Solution][Case] Migrate category & subcategory fields of ServiceNow ITSM connector (#93092) Hide instances latency distribution chart (#92869) [Maps] fix MapboxDraw import from pointing to dist just pointing to folder (#93087) [Maps] fix results trimmed tooltip message doubles feature count for line and polygon features (#92932) [Security Solution][Detecttions] Indicator enrichment tweaks (#92989) [Maps] fix fit to data on heatmap not working (#92697) [Security Solution][Endpoint][Admin] Fixes policy sticky footer save test (#92919) ...

wylieconlon · 2021-03-03T21:52:10Z

@kertal it looks like you never backported this. It's blocking my new PR, so I'm adding backports.

…3522) Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>

…3523) Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>

kertal · 2021-03-04T11:50:27Z

@kertal it looks like you never backported this. It's blocking my new PR, so I'm adding backports.

@wylieconlon thx a lot!

Fix expanding document when using saved search data grid

27f0357

kertal added the Feature:Discover Discover Application label Mar 1, 2021

kertal self-assigned this Mar 1, 2021

kertal added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.12.0 v7.13.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 1, 2021

kertal marked this pull request as ready for review March 1, 2021 12:59

kertal requested a review from a team March 1, 2021 12:59

kertal requested a review from a team as a code owner March 1, 2021 12:59

kertal requested review from majagrubic and wylieconlon March 1, 2021 12:59

Merge branch 'master' into kertal-pr-2021-03-01-discover-saved-search…

b4adcef

…-embeddable-expand-fix

Merge branch 'master' into kertal-pr-2021-03-01-discover-saved-search…

38fb3fc

…-embeddable-expand-fix

majagrubic approved these changes Mar 1, 2021

View reviewed changes

Merge branch 'master' into kertal-pr-2021-03-01-discover-saved-search…

2f42218

…-embeddable-expand-fix

ThomThomson approved these changes Mar 1, 2021

View reviewed changes

wylieconlon approved these changes Mar 1, 2021

View reviewed changes

Merge branch 'master' into kertal-pr-2021-03-01-discover-saved-search…

ab3eb3c

…-embeddable-expand-fix

kertal merged commit 5afe844 into elastic:master Mar 2, 2021

kertal mentioned this pull request Mar 2, 2021

[Discover] Fix link from dashboard saved search to Discover #92937

Merged

1 task

wylieconlon mentioned this pull request Mar 3, 2021

[7.x] [Discover] Fix link from dashboard saved search to Discover (#92937) #93499

Merged

wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Mar 3, 2021

Fix expanding document when using saved search data grid (elastic#92999)

d870da7

wylieconlon mentioned this pull request Mar 3, 2021

[7.x] Fix expanding document when using saved search data grid (#92999) #93522

Merged

wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Mar 3, 2021

Fix expanding document when using saved search data grid (elastic#92999)

4bab588

wylieconlon mentioned this pull request Mar 3, 2021

[7.12] Fix expanding document when using saved search data grid (#92999) #93523

Merged

wylieconlon pushed a commit that referenced this pull request Mar 4, 2021

Fix expanding document when using saved search data grid (#92999) (#9…

2faf3f4

…3522) Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>

wylieconlon pushed a commit that referenced this pull request Mar 4, 2021

Fix expanding document when using saved search data grid (#92999) (#9…

faadbce

…3523) Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Discover] Fix expanding document when using saved search data grid#92999

[Discover] Fix expanding document when using saved search data grid#92999
kertal merged 5 commits intoelastic:masterfrom
kertal:kertal-pr-2021-03-01-discover-saved-search-embeddable-expand-fix

kertal commented Mar 1, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

kertal commented Mar 1, 2021

Uh oh!

kertal commented Mar 1, 2021

Uh oh!

majagrubic left a comment

Uh oh!

kertal commented Mar 1, 2021

Uh oh!

ThomThomson left a comment

Uh oh!

wylieconlon left a comment

Uh oh!

kertal commented Mar 2, 2021

Uh oh!

kibanamachine commented Mar 2, 2021

Uh oh!

kertal commented Mar 2, 2021

Uh oh!

wylieconlon commented Mar 3, 2021 •

edited

Loading

Uh oh!

kertal commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

kertal commented Mar 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

kertal commented Mar 1, 2021

Uh oh!

kertal commented Mar 1, 2021

Uh oh!

majagrubic left a comment

Choose a reason for hiding this comment

Uh oh!

kertal commented Mar 1, 2021

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

wylieconlon left a comment

Choose a reason for hiding this comment

Uh oh!

kertal commented Mar 2, 2021

Uh oh!

kibanamachine commented Mar 2, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

kertal commented Mar 2, 2021

Uh oh!

wylieconlon commented Mar 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kertal commented Mar 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kertal commented Mar 1, 2021 •

edited

Loading

wylieconlon commented Mar 3, 2021 •

edited

Loading