[Lens] Fix Workspace hidden when using Safari#92616
Merged
dej611 merged 3 commits intoelastic:masterfrom Feb 25, 2021
Merged
Conversation
dej611
added
Feature:Lens
release_note:skip
Alternative solution
Contributor
Author
|
Integrated @mbondyra solution which is lighter than the original one proposed here. |
Contributor
|
Tested in FF, Safari and Chrome, looks good to me! |
mbondyra
approved these changes
Feb 24, 2021
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
dej611
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
myasonik
approved these changes
Feb 24, 2021
Contributor
myasonik
left a comment
myasonik
left a comment
There was a problem hiding this comment.
Didn't test but code LGTM
mbondyra
approved these changes
Feb 24, 2021
flash1293
approved these changes
Feb 25, 2021
Contributor
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Tested in Safari and works fine. However I noticed it's not possible to select fields via tab, I'm going to open a new issue for this
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Feb 25, 2021
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
dej611
added a commit
that referenced
this pull request
Feb 25, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
* master: (38 commits) Fixes Cypress flake by adding pipe, click, and should (elastic#92762) [Discover] Fix filtering selected sidebar fields (elastic#91828) [ML] Fixes positions of calendar arrow buttons in start datafeed modal (elastic#92625) [dev/build_ts_refs] check that commit in outDirs matches mergeBase (elastic#92513) add dep on `@kbn/config` so it is built first [Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn (elastic#90481) [Lens] Fix Workspace hidden when using Safari (elastic#92616) [Lens] Fixes vertical alignment validation messages (elastic#91878) forbid x-elastic-product-origin header in elasticsearch configuration (elastic#92359) [Security Solution][Detections] Set default indicator path to reduce friction with new filebeat modules (elastic#92081) [ILM][Accessibility] Added A11y test for ILM new policy form. (elastic#92570) [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (elastic#90634) Automatically generated Api documentation (elastic#86232) Increase index pattern select limit to 1000 (elastic#92093) [core.logging] Add RewriteAppender for filtering LogMeta. (elastic#91492) [Security Solution][Detection Rules] Update prebuilt rule threats to match schema (elastic#92281) [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (elastic#92565) [Dashboard] Export appropriate references from byValue panels (elastic#91567) [Upgrade Assistant] Align code between branches (elastic#91862) [Security Solution][Case] Fix alerts push (elastic#91638) ...
dej611
added a commit
to dej611/kibana
that referenced
this pull request
Mar 2, 2021
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
dej611
added a commit
that referenced
this pull request
Mar 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #92577
This is my attempt to fix the Safari bug with the Drag&Drop styling of the workspace area.