Increase index pattern select limit to 1000#92093
Merged
kindsun merged 8 commits intoelastic:masterfrom Feb 24, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
added
the
release_note:skip
added 3 commits
February 22, 2021 10:53
…tern-select-component-limit
…tern-select-component-limit
mattkime
approved these changes
Feb 23, 2021
Contributor
mattkime
left a comment
mattkime
left a comment
There was a problem hiding this comment.
code changes lgtm. A long term solution would be a way to express that we want to load {x} number of {criteria} index patterns. But that seems like overkill for the immediate need.
Contributor
Author
|
@elasticmachine merge upstream |
added 2 commits
February 24, 2021 11:05
…tern-select-component-limit
kindsun
force-pushed
the
bump-up-index-pattern-select-component-limit
branch
from
4d73553 to
110a705
Compare
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Feb 24, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Feb 24, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kindsun
pushed a commit
that referenced
this pull request
Feb 25, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
* master: (38 commits) Fixes Cypress flake by adding pipe, click, and should (elastic#92762) [Discover] Fix filtering selected sidebar fields (elastic#91828) [ML] Fixes positions of calendar arrow buttons in start datafeed modal (elastic#92625) [dev/build_ts_refs] check that commit in outDirs matches mergeBase (elastic#92513) add dep on `@kbn/config` so it is built first [Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn (elastic#90481) [Lens] Fix Workspace hidden when using Safari (elastic#92616) [Lens] Fixes vertical alignment validation messages (elastic#91878) forbid x-elastic-product-origin header in elasticsearch configuration (elastic#92359) [Security Solution][Detections] Set default indicator path to reduce friction with new filebeat modules (elastic#92081) [ILM][Accessibility] Added A11y test for ILM new policy form. (elastic#92570) [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (elastic#90634) Automatically generated Api documentation (elastic#86232) Increase index pattern select limit to 1000 (elastic#92093) [core.logging] Add RewriteAppender for filtering LogMeta. (elastic#91492) [Security Solution][Detection Rules] Update prebuilt rule threats to match schema (elastic#92281) [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (elastic#92565) [Dashboard] Export appropriate references from byValue panels (elastic#91567) [Upgrade Assistant] Align code between branches (elastic#91862) [Security Solution][Case] Fix alerts push (elastic#91638) ...
thomasneirynck
added
release_note:fix
and removed
release_note:skip
kindsun
pushed a commit
that referenced
this pull request
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the index pattern select component to a default of 1000 and allows props to be passed in to override the default limit. Resolves #86915.
There are at least 3 potential solutions to this issue:
100. Currently the index patterns service maintains a saved objects cache of10,000so I don't think it's unreasonable to submitfindrequests of1,000.findcache in the index patterns service similar to how we do with the standard saved objects cache. This cache would only get used when the same search term is submitted more than one time in a row. Usefulness seems negligible but I'm open to adding this.