[Security Solution][Case] Fix alerts push#91638
Merged
cnasikas merged 5 commits intoelastic:masterfrom Feb 24, 2021
Merged
Conversation
cnasikas
added
release_note:fix
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
cnasikas
force-pushed
the
fix_push_subcases
branch
from
d3ce362 to
70075bd
Compare
jonathan-buttner
approved these changes
Feb 23, 2021
Contributor
jonathan-buttner
left a comment
jonathan-buttner
left a comment
There was a problem hiding this comment.
Looks good, I agree with @michaelolo24 about making commentId optional if we can 👍
| id: 'mock-comment-2', | ||
| alertId: ['alert-id-1', 'alert-id-2'], | ||
| index: 'alert-index-1', | ||
| type: CommentType.alert as const, |
Contributor
There was a problem hiding this comment.
This is cool, didn't realize this added more type safety. Just for my own edification, what does this enforce for type?
Member
Author
There was a problem hiding this comment.
@jonathan-buttner This enforce the variable to be of type "alert" and not string. If you do const x = "test" the type of x is string. If you do const x = "test" as const the type of x is "test", a constant. When we do type: CommentType.alert TS will refer the type of type as string. This will lead to a TS error because the type should be "alert | user | generated_alert". as const resolve this error.
You can read more here: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-3-4.html#const-assertions
Member
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Endpoint Functional Tests.x-pack/test/security_solution_endpoint/apps/endpoint/policy_details·ts.endpoint When on the Endpoint Policy Details Page and the save button is clicked should have cleared the advanced section when the user deletes the valueStandard OutStack TraceMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @cnasikas |
This was referenced Feb 24, 2021
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Feb 24, 2021
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
cnasikas
added a commit
that referenced
this pull request
Feb 24, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 25, 2021
* master: (38 commits) Fixes Cypress flake by adding pipe, click, and should (elastic#92762) [Discover] Fix filtering selected sidebar fields (elastic#91828) [ML] Fixes positions of calendar arrow buttons in start datafeed modal (elastic#92625) [dev/build_ts_refs] check that commit in outDirs matches mergeBase (elastic#92513) add dep on `@kbn/config` so it is built first [Expressions] [Lens] Add id and copyMetaFrom arg to mapColumn fn + add configurable onError argument to math fn (elastic#90481) [Lens] Fix Workspace hidden when using Safari (elastic#92616) [Lens] Fixes vertical alignment validation messages (elastic#91878) forbid x-elastic-product-origin header in elasticsearch configuration (elastic#92359) [Security Solution][Detections] Set default indicator path to reduce friction with new filebeat modules (elastic#92081) [ILM][Accessibility] Added A11y test for ILM new policy form. (elastic#92570) [Security Solution][Exceptions] - Fixes exceptions builder UI where invalid values can cause overwrites of other values (elastic#90634) Automatically generated Api documentation (elastic#86232) Increase index pattern select limit to 1000 (elastic#92093) [core.logging] Add RewriteAppender for filtering LogMeta. (elastic#91492) [Security Solution][Detection Rules] Update prebuilt rule threats to match schema (elastic#92281) [Security Solutions][Detection Engine] Fixes bug with not being able to duplicate indicator matches (elastic#92565) [Dashboard] Export appropriate references from byValue panels (elastic#91567) [Upgrade Assistant] Align code between branches (elastic#91862) [Security Solution][Case] Fix alerts push (elastic#91638) ...
cnasikas
added a commit
that referenced
this pull request
Feb 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes some issues when pushing a case, with alerts attached, to an external service. Specifically:
Elastic Security Alerts attached to the case: <count of alerts>.Checklist
Delete any items that are not applicable to this PR.
For maintainers