Add folding in kbn-monaco and update some viewers #90152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladLasitsa
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
VladLasitsa
added
v7.12.0
v8.0.0
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
cjcenizal
approved these changes
Feb 4, 2021
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Haven't tested locally. Rubber-stamping the one-line change to kbn-monaco to unblock ES UI as codeowner.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
Unknown metric groups@kbn/ui-shared-deps asset size
History
To update your PR or re-run it, just comment with: |
Dosant
approved these changes
Feb 8, 2021
Contributor
Dosant
left a comment
Dosant
left a comment
There was a problem hiding this comment.
Tested in Discover and Dashboard. LGTM
VladLasitsa
added a commit
to VladLasitsa/kibana
that referenced
this pull request
Feb 9, 2021
Co-authored-by: Kibana Machine <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 9, 2021
…timeline-and-rollover-info * 'master' of github.com:elastic/kibana: (47 commits) [Fleet] Use TS project references (elastic#87574) before/beforeEach clean up (elastic#90663) [Vega] user should be able to set a specific tilemap service using the mapStyle property (elastic#88440) [Security Solution][Case] ServiceNow SIR Connector (elastic#88655) [Search Sessions] Enable extend from management (elastic#90558) [ILM] Delete phase redesign (rework) (elastic#90291) [APM-UI][E2E] use withGithubStatus step (elastic#90651) Add folding in kb-monaco and update some viewers (elastic#90152) [Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness (elastic#90543) Strongly typed EUI theme for styled-components (elastic#90106) Fix vega renovate label (elastic#90591) [Uptime] Migrate to TypeScript project references (elastic#90510) [Monitoring] Migrate data source for legacy alerts to monitoring data directly (elastic#87377) [Upgrade Assistant] Add A11y Tests (elastic#90265) [Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (elastic#89612) [dev-utils/ship-ci-stats] fail when CI stats is down (elastic#90678) chore(NA): remove write permissions on Bazel remote cache for PRs (elastic#90652) chore(NA): move bazel workspace status from bash script into nodejs executable (elastic#90560) Use default ES distribution for functional tests (elastic#88737) [Alerts] Jira: Disallow labels with spaces (elastic#90548) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.ts
VladLasitsa
added a commit
that referenced
this pull request
Feb 10, 2021
Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Monaco-editorgives possibility for folding but this haven't worked for ourCodeEditor. I added import for folding in@kbn/monacoso that fix it. Also I updated viewers (used 'xjson' language instead of 'json' because we don't load json language in@kbn/monaco) which we use in vega-debug and requests in inspector so that json will be highlighted.Before
After
How to test it:
Release notes
Adds possibility to folding in
CodeEditor. Updates 'spec viewer' in vega and 'request/response code viewer' in inspector.