[Fleet] Use TS project references #87574

jfsiii · 2021-01-06T20:32:13Z

Summary

Added references to all dependencies

kibana/x-pack/plugins/fleet/tsconfig.json

Lines 17 to 38 in 6bc6f34

    
           "references": [ 
        
             { "path": "../../../src/core/tsconfig.json" }, 
        
             // add references to other TypeScript projects the plugin depends on 
        
             // requiredPlugins from ./kibana.json 
        
             { "path": "../licensing/tsconfig.json" }, 
        
             { "path": "../../../src/plugins/data/tsconfig.json" }, 
        
             { "path": "../encrypted_saved_objects/tsconfig.json" }, 
        
             // optionalPlugins from ./kibana.json 
        
             { "path": "../security/tsconfig.json" }, 
        
             { "path": "../features/tsconfig.json" }, 
        
             { "path": "../cloud/tsconfig.json" }, 
        
             { "path": "../../../src/plugins/usage_collection/tsconfig.json" }, 
        
             { "path": "../../../src/plugins/home/tsconfig.json" }, 
        
             // requiredBundles from ./kibana.json 
        
             { "path": "../../../src/plugins/kibana_react/tsconfig.json" }, 
        
             { "path": "../../../src/plugins/es_ui_shared/tsconfig.json" }, 
        
             { "path": "../infra/tsconfig.json" }, 
        
             { "path": "../../../src/plugins/kibana_utils/tsconfig.json" }, 
        
           ]

node scripts/check_ts_projects is successful
node scripts/build_ts_refs is successful

node --max-old-space-size=4096 ./node_modules/.bin/tsc -p tsconfig.json --extendedDiagnostics --noEmit

Files:                        1436
Lines:                      267372
Nodes:                     1016769
Identifiers:                361835
Symbols:                    250405
Types:                       31105
Instantiations:              57570
Memory used:               347817K
Assignability cache size:     5597
Identity cache size:          3073
Subtype cache size:           2140
Strict subtype cache size:    1012
I/O Read time:               0.49s
Parse time:                  3.84s
ResolveModule time:          1.59s
ResolveTypeReference time:   0.16s
Program time:                7.46s
Bind time:                   1.87s
Check time:                  4.02s
printTime time:              0.00s
Emit time:                   0.00s
Total time:                 13.35s

elasticmachine · 2021-01-06T20:32:17Z

Pinging @elastic/ingest-management (Team:Ingest Management)

jfsiii · 2021-01-07T02:27:05Z

Looks like I missed an entry. Check TS projects fails with

15:44:07  $ /dev/shm/workspace/parallel/12/kibana/node_modules/.bin/github-checks-reporter 'Check TypeScript Projects' node scripts/check_ts_projects
15:44:08  GitHub checks API - 13796 remaining out of 15000/hour
15:44:26  ERROR The following files do not belong to a tsconfig.json file, or that tsconfig.json file is not listed in src/dev/typescript/projects.ts
15:44:26         - x-pack/plugins/fleet/common/constants/agent.ts
15:44:26         - x-pack/plugins/fleet/common/constants/agent_policy.ts
...all the rest of the plugin files

mshustov · 2021-01-07T09:44:04Z

@jfsiii yes, include should list all the folders to compile:

  "include": [
    "public/**/*",
    "server/**/*",
    "common/**/*"
  ]

jfsiii · 2021-01-07T12:03:47Z

@elasticmachine merge upstream

jfsiii · 2021-01-07T13:13:50Z

@restrry I added the include entries & linked the data plugin. Any idea about the CI failure ? Anything I should change here?

jfsiii · 2021-01-07T23:58:35Z

@restrry I found the source of the 10,000 errors. I wasn't extending the x-pack tsconfig fff562d

jfsiii · 2021-01-11T11:59:53Z

@elasticmachine merge upstream

jfsiii · 2021-01-11T17:25:25Z

Seeing these errors locally after enabled the features project reference in 3b4aed8

src/plugins/management/target/types/public/management_sections_service.d.ts:2:54 - error TS2307: Cannot find module '../../kibana_utils/public' or its corresponding type declarations.

2 declare const getSectionsServiceStartPrivate: import("../../kibana_utils/public").Get<ManagementSectionsStartPrivate>;
                                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/plugins/management/target/types/public/plugin.d.ts:2:39 - error TS2307: Cannot find module '../../home/public' or its corresponding type declarations.

2 import { HomePublicPluginSetup } from '../../home/public';
                                        ~~~~~~~~~~~~~~~~~~~

src/plugins/management/target/types/public/plugin.d.ts:3:72 - error TS2307: Cannot find module '../../../core/public' or its corresponding type declarations.

3 import { CoreSetup, CoreStart, Plugin, PluginInitializerContext } from '../../../core/public';
                                                                         ~~~~~~~~~~~~~~~~~~~~~~

src/plugins/management/target/types/public/types.d.ts:3:34 - error TS2307: Cannot find module '../../../core/public/' or its corresponding type declarations.

3 import { ChromeBreadcrumb } from '../../../core/public/';
                                   ~~~~~~~~~~~~~~~~~~~~~~~


Found 4 errors.

Pushed to see if they fail in CI as well. If so, I'll follow up with core to confirm a) they're issues outside the Fleet plugin b) what to do next

jfsiii · 2021-01-12T14:15:27Z

@elasticmachine merge upstream

pgayvallet · 2021-01-20T07:19:18Z

x-pack/plugins/fleet/tsconfig.json

+    // optionalPlugins from ./kibana.json
+    { "path": "../security/tsconfig.json" },
+    { "path": "../features/tsconfig.json" },
+    // TODO { "path": "../cloud/tsconfig.json" },


cloud should be available soon: #88676

jfsiii · 2021-01-20T13:53:43Z

@elasticmachine merge upstream

jfsiii · 2021-01-22T20:01:41Z

@elasticmachine merge upstream

jfsiii · 2021-01-25T14:41:29Z

@elasticmachine merge upstream

pgayvallet · 2021-01-26T10:57:11Z

Btw, how is the build passing given that?

// TODO { "path": "../infra/tsconfig.json" },

jfsiii · 2021-01-26T12:49:21Z

@pgayvallet fair question, but I don't know. It's been building without issues since there were many more

kibana/x-pack/plugins/fleet/tsconfig.json

Lines 21 to 37 in 8145db0

    
           // requiredPlugins from ./kibana.json 
        
           { "path": "../licensing/tsconfig.json" }, 
        
           { "path": "../../../src/plugins/data/tsconfig.json" }, 
        
           // TODO { "path": "../encrypted_saved_objects/tsconfig.json" }, 
        
           // optionalPlugins from ./kibana.json 
        
           // TODO { "path": "../security/tsconfig.json" }, 
        
           // TODO { "path": "../features/tsconfig.json" }, 
        
           // TODO { "path": "../cloud/tsconfig.json" }, 
        
           { "path": "../../../src/plugins/usage_collection/tsconfig.json" }, 
        
           { "path": "../../../src/plugins/home/tsconfig.json" }, 
        
           // requiredBundles from ./kibana.json 
        
           { "path": "../../../src/plugins/kibana_react/tsconfig.json" }, 
        
           // TODO { "path": "../../../src/plugins/es_ui_shared/tsconfig.json" }, 
        
           // TODO { "path": "../infra/tsconfig.json" }, 
        
           { "path": "../../../src/plugins/kibana_utils/tsconfig.json" },

jfsiii · 2021-02-08T14:30:50Z

@elasticmachine merge upstream

jfsiii · 2021-02-08T17:07:35Z

@elasticmachine merge upstream

kibanamachine · 2021-02-08T19:16:17Z

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

💔 Build #104706 failed 9dfbbdd
💚 Build #102969 succeeded 3ec6766
💚 Build #100728 succeeded e4e1c69
💚 Build #100543 succeeded 5c955ff
💚 Build #99992 succeeded 79565a2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jfsiii · 2021-02-08T19:22:43Z

ping @restrry & @pgayvallet. All dependencies are linked and CI is 💚

…timeline-and-rollover-info * 'master' of github.com:elastic/kibana: (47 commits) [Fleet] Use TS project references (elastic#87574) before/beforeEach clean up (elastic#90663) [Vega] user should be able to set a specific tilemap service using the mapStyle property (elastic#88440) [Security Solution][Case] ServiceNow SIR Connector (elastic#88655) [Search Sessions] Enable extend from management (elastic#90558) [ILM] Delete phase redesign (rework) (elastic#90291) [APM-UI][E2E] use withGithubStatus step (elastic#90651) Add folding in kb-monaco and update some viewers (elastic#90152) [Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness (elastic#90543) Strongly typed EUI theme for styled-components (elastic#90106) Fix vega renovate label (elastic#90591) [Uptime] Migrate to TypeScript project references (elastic#90510) [Monitoring] Migrate data source for legacy alerts to monitoring data directly (elastic#87377) [Upgrade Assistant] Add A11y Tests (elastic#90265) [Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (elastic#89612) [dev-utils/ship-ci-stats] fail when CI stats is down (elastic#90678) chore(NA): remove write permissions on Bazel remote cache for PRs (elastic#90652) chore(NA): move bazel workspace status from bash script into nodejs executable (elastic#90560) Use default ES distribution for functional tests (elastic#88737) [Alerts] Jira: Disallow labels with spaces (elastic#90548) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.ts

## Summary * Added references to all dependencies https://github.com/elastic/kibana/blob/6bc6f3459a120eddfae70ad2fc7e4669e3a996b0/x-pack/plugins/fleet/tsconfig.json#L17-L38 * `node scripts/check_ts_projects` is successful * `node scripts/build_ts_refs` is successful <details><summary><code>node --max-old-space-size=4096 ./node_modules/.bin/tsc -p tsconfig.json --extendedDiagnostics --noEmit</code></summary> ``` Files: 1436 Lines: 267372 Nodes: 1016769 Identifiers: 361835 Symbols: 250405 Types: 31105 Instantiations: 57570 Memory used: 347817K Assignability cache size: 5597 Identity cache size: 3073 Subtype cache size: 2140 Strict subtype cache size: 1012 I/O Read time: 0.49s Parse time: 3.84s ResolveModule time: 1.59s ResolveTypeReference time: 0.16s Program time: 7.46s Bind time: 1.87s Check time: 4.02s printTime time: 0.00s Emit time: 0.00s Total time: 13.35s ``` </details>

Use TS project references

04a8689

jfsiii requested a review from a team January 6, 2021 20:32

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jan 6, 2021

jfsiii requested a review from mshustov January 6, 2021 20:32

jfsiii self-assigned this Jan 6, 2021

jfsiii added v7.12.0 v8.0.0 labels Jan 6, 2021

jfsiii added the release_note:skip Skip the PR/issue when compiling release notes label Jan 7, 2021

John Schulz added 2 commits January 7, 2021 06:55

Add missing include entries in tsconfig

26000ce

Merge branch 'master' into 82220-use-ts-project-references

c3fed14

kibanamachine and others added 2 commits January 7, 2021 07:03

Merge branch 'master' into 82220-use-ts-project-references

5fdf493

Add reference to data plugin project

1ea65ef

John Schulz added 4 commits January 7, 2021 10:18

Merge branch 'master' into 82220-use-ts-project-references

2f641db

Add references to recently added tsconfig's

bd82222

Add disabled reference to infra tsconfig

bb438c7

Reorder tsconfig references

8145db0

jfsiii linked an issue Jan 7, 2021 that may be closed by this pull request

[Fleet] TS project references migration #82220

Closed

16 tasks

Extend x-pack/tsconfig.json

fff562d

jfsiii requested a review from a team January 7, 2021 20:31

kibanamachine and others added 2 commits January 11, 2021 06:59

Merge branch 'master' into 82220-use-ts-project-references

50249a6

Enable reference to features project

3b4aed8

Add Security & ESO project references

d8c2600

pgayvallet reviewed Jan 20, 2021

View reviewed changes

Merge branch 'master' into 82220-use-ts-project-references

cb1261e

Merge branch 'master' into 82220-use-ts-project-references

79565a2

kibanamachine and others added 2 commits January 22, 2021 15:01

Merge branch 'master' into 82220-use-ts-project-references

22488e6

Link to newly available cloud project

5c955ff

Merge branch 'master' into 82220-use-ts-project-references

e4e1c69

TinaHeiligers mentioned this pull request Jan 26, 2021

[Meta] Migrate plugins to TS references for es_ui CODEOWNERS plugins #89321

Closed

Merge branch 'master' into 82220-use-ts-project-references

3ec6766

jfsiii mentioned this pull request Feb 3, 2021

[Logs + Metrics UI] Migrate to TS project references #80995

Closed

15 tasks

Merge branch 'master' into 82220-use-ts-project-references

2bef282

kibanamachine and others added 2 commits February 8, 2021 09:30

Merge branch 'master' into 82220-use-ts-project-references

9dfbbdd

Merge branch 'master' into 82220-use-ts-project-references

b1cb710

Merge branch 'master' into 82220-use-ts-project-references

6bc6f34

jfsiii requested a review from pgayvallet February 8, 2021 19:21

mshustov approved these changes Feb 9, 2021

View reviewed changes

jfsiii merged commit af75079 into elastic:master Feb 9, 2021

jfsiii mentioned this pull request Feb 9, 2021

[7.x] [Fleet] Use TS project references (#87574) #90748

Merged

jfsiii deleted the 82220-use-ts-project-references branch April 6, 2021 17:09

	"references": [
	{ "path": "../../../src/core/tsconfig.json" },
	// add references to other TypeScript projects the plugin depends on

	// requiredPlugins from ./kibana.json
	{ "path": "../licensing/tsconfig.json" },
	{ "path": "../../../src/plugins/data/tsconfig.json" },
	{ "path": "../encrypted_saved_objects/tsconfig.json" },

	// optionalPlugins from ./kibana.json
	{ "path": "../security/tsconfig.json" },
	{ "path": "../features/tsconfig.json" },
	{ "path": "../cloud/tsconfig.json" },
	{ "path": "../../../src/plugins/usage_collection/tsconfig.json" },
	{ "path": "../../../src/plugins/home/tsconfig.json" },

	// requiredBundles from ./kibana.json
	{ "path": "../../../src/plugins/kibana_react/tsconfig.json" },
	{ "path": "../../../src/plugins/es_ui_shared/tsconfig.json" },
	{ "path": "../infra/tsconfig.json" },
	{ "path": "../../../src/plugins/kibana_utils/tsconfig.json" },
	]

[Fleet] Use TS project references #87574

[Fleet] Use TS project references #87574

Uh oh!

Conversation

jfsiii commented Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jan 6, 2021

Uh oh!

jfsiii commented Jan 7, 2021

Uh oh!

mshustov commented Jan 7, 2021

Uh oh!

jfsiii commented Jan 7, 2021

Uh oh!

jfsiii commented Jan 7, 2021

Uh oh!

jfsiii commented Jan 7, 2021

Uh oh!

jfsiii commented Jan 11, 2021

Uh oh!

jfsiii commented Jan 11, 2021

Uh oh!

jfsiii commented Jan 12, 2021

Uh oh!

pgayvallet Jan 20, 2021

Choose a reason for hiding this comment

Uh oh!

jfsiii commented Jan 20, 2021

Uh oh!

jfsiii commented Jan 22, 2021

Uh oh!

jfsiii commented Jan 25, 2021

Uh oh!

pgayvallet commented Jan 26, 2021

Uh oh!

jfsiii commented Jan 26, 2021

Uh oh!

jfsiii commented Feb 8, 2021

Uh oh!

jfsiii commented Feb 8, 2021

Uh oh!

kibanamachine commented Feb 8, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

jfsiii commented Feb 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jfsiii commented Jan 6, 2021 •

edited

Loading