Skip to content

Add tsconfig ref to vis_type_vega #89551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2021
Merged

Add tsconfig ref to vis_type_vega #89551

merged 2 commits into from
Jan 29, 2021

Conversation

@flash1293
Copy link
Contributor

@flash1293 flash1293 commented Jan 28, 2021

Related to #80508

Adds ts config file for vis_type_vega

@flash1293 flash1293 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Jan 28, 2021
@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 28, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review January 28, 2021 16:58
@flash1293 flash1293 requested a review from a team January 28, 2021 16:58
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 28, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 requested a review from stratoula January 28, 2021 16:58
stratoula
stratoula approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanx Joe 🙂

@flash1293 flash1293 merged commit 749c01d into elastic:master Jan 29, 2021
flash1293 added a commit to flash1293/kibana that referenced this pull request Jan 29, 2021
@flash1293
Add tsconfig ref to vis_type_vega (elastic#89551)
1ee81b9
@flash1293 flash1293 mentioned this pull request Jan 29, 2021
Merged
flash1293 added a commit that referenced this pull request Jan 29, 2021
@flash1293
Add tsconfig ref to vis_type_vega (#89551) (#89696)
06e4a77
@alexwizp alexwizp mentioned this pull request Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flash1293 @kibanamachine @elasticmachine @stratoula