Skip to content

Commit 749c01d

Browse files
authored
Add tsconfig ref to vis_type_vega (#89551)
1 parent 5f8f21b commit 749c01d

File tree

4 files changed

+39
-1
lines changed

4 files changed

+39
-1
lines changed

src/plugins/vis_type_vega/public/vega_visualization.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,14 @@ import { VegaVisualizationDependencies } from './plugin';
1313
import { getNotifications, getData } from './services';
1414
import type { VegaView } from './vega_view/vega_view';
1515

16-
export const createVegaVisualization = ({ getServiceSettings }: VegaVisualizationDependencies) =>
16+
type VegaVisType = new (el: HTMLDivElement, fireEvent: IInterpreterRenderHandlers['event']) => {
17+
render(visData: VegaParser): Promise<void>;
18+
destroy(): void;
19+
};
20+
21+
export const createVegaVisualization = ({
22+
getServiceSettings,
23+
}: VegaVisualizationDependencies): VegaVisType =>
1724
class VegaVisualization {
1825
private readonly dataPlugin = getData();
1926
private vegaView: InstanceType<typeof VegaView> | null = null;
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
{
2+
"extends": "../../../tsconfig.base.json",
3+
"compilerOptions": {
4+
"composite": true,
5+
"outDir": "./target/types",
6+
"emitDeclarationOnly": true,
7+
"declaration": true,
8+
"declarationMap": true
9+
},
10+
"include": [
11+
"server/**/*",
12+
"public/**/*",
13+
"*.ts"
14+
],
15+
"references": [
16+
{ "path": "../../core/tsconfig.json" },
17+
{ "path": "../data/tsconfig.json" },
18+
{ "path": "../visualizations/tsconfig.json" },
19+
{ "path": "../maps_legacy/tsconfig.json" },
20+
{ "path": "../expressions/tsconfig.json" },
21+
{ "path": "../inspector/tsconfig.json" },
22+
{ "path": "../home/tsconfig.json" },
23+
{ "path": "../usage_collection/tsconfig.json" },
24+
{ "path": "../kibana_utils/tsconfig.json" },
25+
{ "path": "../kibana_react/tsconfig.json" },
26+
{ "path": "../vis_default_editor/tsconfig.json" },
27+
]
28+
}

tsconfig.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
"src/plugins/vis_type_timelion/**/*",
5454
"src/plugins/vis_type_timeseries/**/*",
5555
"src/plugins/vis_type_vislib/**/*",
56+
"src/plugins/vis_type_vega/**/*",
5657
"src/plugins/vis_type_xy/**/*",
5758
"src/plugins/visualizations/**/*",
5859
"src/plugins/visualize/**/*",
@@ -109,6 +110,7 @@
109110
{ "path": "./src/plugins/vis_type_timelion/tsconfig.json" },
110111
{ "path": "./src/plugins/vis_type_timeseries/tsconfig.json" },
111112
{ "path": "./src/plugins/vis_type_vislib/tsconfig.json" },
113+
{ "path": "./src/plugins/vis_type_vega/tsconfig.json" },
112114
{ "path": "./src/plugins/vis_type_xy/tsconfig.json" },
113115
{ "path": "./src/plugins/visualizations/tsconfig.json" },
114116
{ "path": "./src/plugins/visualize/tsconfig.json" },

tsconfig.refs.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
{ "path": "./src/plugins/vis_type_timelion/tsconfig.json" },
5050
{ "path": "./src/plugins/vis_type_timeseries/tsconfig.json" },
5151
{ "path": "./src/plugins/vis_type_vislib/tsconfig.json" },
52+
{ "path": "./src/plugins/vis_type_vega/tsconfig.json" },
5253
{ "path": "./src/plugins/vis_type_xy/tsconfig.json" },
5354
{ "path": "./src/plugins/visualizations/tsconfig.json" },
5455
{ "path": "./src/plugins/visualize/tsconfig.json" },

0 commit comments

Comments
 (0)