Skip to content

Add tsconfig ref to vis_type_vega #89551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Add tsconfig ref to vis_type_vega #89551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87ac6e0
add tsconfig ref to vega
flash1293 Jan 28, 2021
7b44fc7
fix tsconfig
flash1293 Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/plugins/vis_type_vega/public/vega_visualization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@ import { VegaVisualizationDependencies } from './plugin';
import { getNotifications, getData } from './services';
import type { VegaView } from './vega_view/vega_view';

export const createVegaVisualization = ({ getServiceSettings }: VegaVisualizationDependencies) =>
type VegaVisType = new (el: HTMLDivElement, fireEvent: IInterpreterRenderHandlers['event']) => {
render(visData: VegaParser): Promise<void>;
destroy(): void;
};

export const createVegaVisualization = ({
getServiceSettings,
}: VegaVisualizationDependencies): VegaVisType =>
class VegaVisualization {
private readonly dataPlugin = getData();
private vegaView: InstanceType<typeof VegaView> | null = null;
Expand Down
28 changes: 28 additions & 0 deletions src/plugins/vis_type_vega/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
{
"extends": "../../../tsconfig.base.json",
"compilerOptions": {
"composite": true,
"outDir": "./target/types",
"emitDeclarationOnly": true,
"declaration": true,
"declarationMap": true
},
"include": [
"server/**/*",
"public/**/*",
"*.ts"
],
"references": [
{ "path": "../../core/tsconfig.json" },
{ "path": "../data/tsconfig.json" },
{ "path": "../visualizations/tsconfig.json" },
{ "path": "../maps_legacy/tsconfig.json" },
{ "path": "../expressions/tsconfig.json" },
{ "path": "../inspector/tsconfig.json" },
{ "path": "../home/tsconfig.json" },
{ "path": "../usage_collection/tsconfig.json" },
{ "path": "../kibana_utils/tsconfig.json" },
{ "path": "../kibana_react/tsconfig.json" },
{ "path": "../vis_default_editor/tsconfig.json" },
]
}
2 changes: 2 additions & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"src/plugins/vis_type_timelion/**/*",
"src/plugins/vis_type_timeseries/**/*",
"src/plugins/vis_type_vislib/**/*",
"src/plugins/vis_type_vega/**/*",
"src/plugins/vis_type_xy/**/*",
"src/plugins/visualizations/**/*",
"src/plugins/visualize/**/*",
Expand Down Expand Up @@ -109,6 +110,7 @@
{ "path": "./src/plugins/vis_type_timelion/tsconfig.json" },
{ "path": "./src/plugins/vis_type_timeseries/tsconfig.json" },
{ "path": "./src/plugins/vis_type_vislib/tsconfig.json" },
{ "path": "./src/plugins/vis_type_vega/tsconfig.json" },
{ "path": "./src/plugins/vis_type_xy/tsconfig.json" },
{ "path": "./src/plugins/visualizations/tsconfig.json" },
{ "path": "./src/plugins/visualize/tsconfig.json" },
Expand Down
1 change: 1 addition & 0 deletions tsconfig.refs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
{ "path": "./src/plugins/vis_type_timelion/tsconfig.json" },
{ "path": "./src/plugins/vis_type_timeseries/tsconfig.json" },
{ "path": "./src/plugins/vis_type_vislib/tsconfig.json" },
{ "path": "./src/plugins/vis_type_vega/tsconfig.json" },
{ "path": "./src/plugins/vis_type_xy/tsconfig.json" },
{ "path": "./src/plugins/visualizations/tsconfig.json" },
{ "path": "./src/plugins/visualize/tsconfig.json" },
Expand Down