-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[backport] PR #8764 to 5.0 - UI Settings should be disabled when elasticsearch is not available #8769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- **Commit 1:** UI Settings disabled when plugins.initialize is false * Original sha: c6f90e2 * Authored by = <[email protected]> on 2016-10-19T20:47:05Z **Commit 2:** Moving where we're disabling the ui settings * Original sha: e66c7e7 * Authored by = <[email protected]> on 2016-10-19T21:22:52Z **Commit 3:** [server/uiSettings] add enabled config in response to matt's comment that relying on `plugins.initialize` is kinda dirty (with which we all agree) we're adding an undocumented config value that the dev cli can use to put prevent the optimizr server from logging meaningless warnings * Original sha: 40ffd12 * Authored by spalger <[email protected]> on 2016-10-19T23:24:55Z **Commit 4:** [server/uiSettings] react to missing elasticsearch plugin * Original sha: 7feacf6 * Authored by spalger <[email protected]> on 2016-10-19T23:26:44Z **Commit 5:** [server/uiSettings] fix da tests * Original sha: c2d7d01 * Authored by spalger <[email protected]> on 2016-10-19T23:36:11Z **Commit 6:** [server/uiSettings] document enabled config * Original sha: f9bd154 * Authored by Spencer <[email protected]> on 2016-10-19T23:52:28Z * Committed by GitHub <[email protected]> on 2016-10-19T23:52:28Z
(cherry picked from commit 6865281)
mgadewoll
added a commit
that referenced
this pull request
Jun 25, 2025
`103.1.0` ⏩ `104.0.2` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes - updates flat tooltip prop usages on **EuiCopy** to use new `tooltipProp` ## Package updates ### `@elastic/eui` ## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2) **Bug fixes** - Fixed missing JSON token exports for `euiColorBackgroundBaseInteractiveSelectHover` and `euiColorBorderStrongText` ([#8819](elastic/eui#8819)) ## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1) **Bug fixes** - Fixed a wrong path in the module declaration for the JSON token exports that would trigger typescript errors ([#8818](elastic/eui#8818)) ## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0) - Added data vis text color tokens: ([#8793](elastic/eui#8793)) - `colors.vis.euiColorVisText0` - `colors.vis.euiColorVisText1` - `colors.vis.euiColorVisText2` - `colors.vis.euiColorVisText3` - `colors.vis.euiColorVisText4` - `colors.vis.euiColorVisText5` - `colors.vis.euiColorVisText6` - `colors.vis.euiColorVisText7` - `colors.vis.euiColorVisText8` - `colors.vis.euiColorVisText9` - Updated and aligned background hover styles for `EuiTable` and `EuiDataGrid` ([#8769](elastic/eui#8769)) **Deprecations** - Deprecated `euiPaletteForLightBackground` and `euiPaletteForDarkBackground` palettes. Use the newly added data vis color tokens instead. ([#8793](elastic/eui#8793)) **Breaking changes** - Removed tokens: ([#8793](elastic/eui#8793)) - `colors.vis.euiColorVisAsTextLight1` - `colors.vis.euiColorVisAsTextLight0` - `colors.vis.euiColorVisAsTextLight2` - `colors.vis.euiColorVisAsTextLight3` - `colors.vis.euiColorVisAsTextLight4` - `colors.vis.euiColorVisAsTextLight5` - `colors.vis.euiColorVisAsTextLight6` - `colors.vis.euiColorVisAsTextDark1` - `colors.vis.euiColorVisAsTextDark0` - `colors.vis.euiColorVisAsTextDark2` - `colors.vis.euiColorVisAsTextDark3` - `colors.vis.euiColorVisAsTextDark4` - `colors.vis.euiColorVisAsTextDark5` - `colors.vis.euiColorVisAsTextDark6` - Removed `xl` size from `EuiTabs` ([#8762](elastic/eui#8762)) - Added `tooltipProps` to `EuiCopy` which replaces spreading all props to `EuiToolTip` ([#8758](elastic/eui#8758)) <!--ONMERGE {"backportTargets":["8.19"]} ONMERGE--> --------- Co-authored-by: Elastic Machine <[email protected]>
mgadewoll
added a commit
to mgadewoll/kibana
that referenced
this pull request
Jul 14, 2025
`103.1.0` ⏩ `104.0.2` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes - updates flat tooltip prop usages on **EuiCopy** to use new `tooltipProp` ## Package updates ### `@elastic/eui` ## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2) **Bug fixes** - Fixed missing JSON token exports for `euiColorBackgroundBaseInteractiveSelectHover` and `euiColorBorderStrongText` ([elastic#8819](elastic/eui#8819)) ## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1) **Bug fixes** - Fixed a wrong path in the module declaration for the JSON token exports that would trigger typescript errors ([elastic#8818](elastic/eui#8818)) ## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0) - Added data vis text color tokens: ([elastic#8793](elastic/eui#8793)) - `colors.vis.euiColorVisText0` - `colors.vis.euiColorVisText1` - `colors.vis.euiColorVisText2` - `colors.vis.euiColorVisText3` - `colors.vis.euiColorVisText4` - `colors.vis.euiColorVisText5` - `colors.vis.euiColorVisText6` - `colors.vis.euiColorVisText7` - `colors.vis.euiColorVisText8` - `colors.vis.euiColorVisText9` - Updated and aligned background hover styles for `EuiTable` and `EuiDataGrid` ([elastic#8769](elastic/eui#8769)) **Deprecations** - Deprecated `euiPaletteForLightBackground` and `euiPaletteForDarkBackground` palettes. Use the newly added data vis color tokens instead. ([elastic#8793](elastic/eui#8793)) **Breaking changes** - Removed tokens: ([elastic#8793](elastic/eui#8793)) - `colors.vis.euiColorVisAsTextLight1` - `colors.vis.euiColorVisAsTextLight0` - `colors.vis.euiColorVisAsTextLight2` - `colors.vis.euiColorVisAsTextLight3` - `colors.vis.euiColorVisAsTextLight4` - `colors.vis.euiColorVisAsTextLight5` - `colors.vis.euiColorVisAsTextLight6` - `colors.vis.euiColorVisAsTextDark1` - `colors.vis.euiColorVisAsTextDark0` - `colors.vis.euiColorVisAsTextDark2` - `colors.vis.euiColorVisAsTextDark3` - `colors.vis.euiColorVisAsTextDark4` - `colors.vis.euiColorVisAsTextDark5` - `colors.vis.euiColorVisAsTextDark6` - Removed `xl` size from `EuiTabs` ([elastic#8762](elastic/eui#8762)) - Added `tooltipProps` to `EuiCopy` which replaces spreading all props to `EuiToolTip` ([elastic#8758](elastic/eui#8758)) <!--ONMERGE {"backportTargets":["8.19"]} ONMERGE--> --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit efedad1) # Conflicts: # package.json # src/dev/license_checker/config.ts # yarn.lock
mgadewoll
added a commit
that referenced
this pull request
Jul 14, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Upgrade EUI to v104.0.2 (#224855)](#224855) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lene Gadewoll","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-06-25T14:55:46Z","message":"Upgrade EUI to v104.0.2 (#224855)\n\n`103.1.0` ⏩ `104.0.2`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n## Changes\n\n- updates flat tooltip prop usages on **EuiCopy** to use new\n`tooltipProp`\n\n## Package updates\n\n### `@elastic/eui`\n\n## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2)\n\n**Bug fixes**\n\n- Fixed missing JSON token exports for\n`euiColorBackgroundBaseInteractiveSelectHover` and\n`euiColorBorderStrongText`\n([#8819](https://github.com/elastic/eui/pull/8819))\n\n## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1)\n\n**Bug fixes**\n\n- Fixed a wrong path in the module declaration for the JSON token\nexports that would trigger typescript errors\n([#8818](https://github.com/elastic/eui/pull/8818))\n\n## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0)\n\n- Added data vis text color tokens:\n([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisText0`\n - `colors.vis.euiColorVisText1`\n - `colors.vis.euiColorVisText2`\n - `colors.vis.euiColorVisText3`\n - `colors.vis.euiColorVisText4`\n - `colors.vis.euiColorVisText5`\n - `colors.vis.euiColorVisText6`\n - `colors.vis.euiColorVisText7`\n - `colors.vis.euiColorVisText8`\n - `colors.vis.euiColorVisText9`\n- Updated and aligned background hover styles for `EuiTable` and\n`EuiDataGrid` ([#8769](https://github.com/elastic/eui/pull/8769))\n\n**Deprecations**\n\n- Deprecated `euiPaletteForLightBackground` and\n`euiPaletteForDarkBackground` palettes. Use the newly added data vis\ncolor tokens instead.\n([#8793](https://github.com/elastic/eui/pull/8793))\n\n**Breaking changes**\n\n- Removed tokens: ([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisAsTextLight1`\n - `colors.vis.euiColorVisAsTextLight0`\n - `colors.vis.euiColorVisAsTextLight2`\n - `colors.vis.euiColorVisAsTextLight3`\n - `colors.vis.euiColorVisAsTextLight4`\n - `colors.vis.euiColorVisAsTextLight5`\n - `colors.vis.euiColorVisAsTextLight6`\n - `colors.vis.euiColorVisAsTextDark1`\n - `colors.vis.euiColorVisAsTextDark0`\n - `colors.vis.euiColorVisAsTextDark2`\n - `colors.vis.euiColorVisAsTextDark3`\n - `colors.vis.euiColorVisAsTextDark4`\n - `colors.vis.euiColorVisAsTextDark5`\n - `colors.vis.euiColorVisAsTextDark6`\n- Removed `xl` size from `EuiTabs`\n([#8762](https://github.com/elastic/eui/pull/8762))\n- Added `tooltipProps` to `EuiCopy` which replaces spreading all props\nto `EuiToolTip` ([#8758](https://github.com/elastic/eui/pull/8758))\n\n\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"efedad1b3e36460cd6ac5e73837e333c54d75861","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","EUI","backport:skip","ci:cloud-deploy","v9.2.0"],"title":"Upgrade EUI to v104.0.2","number":224855,"url":"https://github.com/elastic/kibana/pull/224855","mergeCommit":{"message":"Upgrade EUI to v104.0.2 (#224855)\n\n`103.1.0` ⏩ `104.0.2`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n## Changes\n\n- updates flat tooltip prop usages on **EuiCopy** to use new\n`tooltipProp`\n\n## Package updates\n\n### `@elastic/eui`\n\n## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2)\n\n**Bug fixes**\n\n- Fixed missing JSON token exports for\n`euiColorBackgroundBaseInteractiveSelectHover` and\n`euiColorBorderStrongText`\n([#8819](https://github.com/elastic/eui/pull/8819))\n\n## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1)\n\n**Bug fixes**\n\n- Fixed a wrong path in the module declaration for the JSON token\nexports that would trigger typescript errors\n([#8818](https://github.com/elastic/eui/pull/8818))\n\n## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0)\n\n- Added data vis text color tokens:\n([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisText0`\n - `colors.vis.euiColorVisText1`\n - `colors.vis.euiColorVisText2`\n - `colors.vis.euiColorVisText3`\n - `colors.vis.euiColorVisText4`\n - `colors.vis.euiColorVisText5`\n - `colors.vis.euiColorVisText6`\n - `colors.vis.euiColorVisText7`\n - `colors.vis.euiColorVisText8`\n - `colors.vis.euiColorVisText9`\n- Updated and aligned background hover styles for `EuiTable` and\n`EuiDataGrid` ([#8769](https://github.com/elastic/eui/pull/8769))\n\n**Deprecations**\n\n- Deprecated `euiPaletteForLightBackground` and\n`euiPaletteForDarkBackground` palettes. Use the newly added data vis\ncolor tokens instead.\n([#8793](https://github.com/elastic/eui/pull/8793))\n\n**Breaking changes**\n\n- Removed tokens: ([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisAsTextLight1`\n - `colors.vis.euiColorVisAsTextLight0`\n - `colors.vis.euiColorVisAsTextLight2`\n - `colors.vis.euiColorVisAsTextLight3`\n - `colors.vis.euiColorVisAsTextLight4`\n - `colors.vis.euiColorVisAsTextLight5`\n - `colors.vis.euiColorVisAsTextLight6`\n - `colors.vis.euiColorVisAsTextDark1`\n - `colors.vis.euiColorVisAsTextDark0`\n - `colors.vis.euiColorVisAsTextDark2`\n - `colors.vis.euiColorVisAsTextDark3`\n - `colors.vis.euiColorVisAsTextDark4`\n - `colors.vis.euiColorVisAsTextDark5`\n - `colors.vis.euiColorVisAsTextDark6`\n- Removed `xl` size from `EuiTabs`\n([#8762](https://github.com/elastic/eui/pull/8762))\n- Added `tooltipProps` to `EuiCopy` which replaces spreading all props\nto `EuiToolTip` ([#8758](https://github.com/elastic/eui/pull/8758))\n\n\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"efedad1b3e36460cd6ac5e73837e333c54d75861"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #8764
Commit 1:
UI Settings disabled when plugins.initialize is false
Commit 2:
Moving where we're disabling the ui settings
Commit 3:
[server/uiSettings] add enabled config
in response to matt's comment that relying on
plugins.initializeis kinda dirty (with which we all agree) we're adding an undocumented config value that the dev cli can use to put prevent the optimizr server from logging meaningless warningsCommit 4:
[server/uiSettings] react to missing elasticsearch plugin
Commit 5:
[server/uiSettings] fix da tests
Commit 6:
[server/uiSettings] document enabled config