Skip to content

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Jun 6, 2025

Summary

Important

This is a breaking change.

Closes #8382

On this PR, I:

Storybook

Control displays correctly:

Screenshot 2025-06-06 at 17 12 48

No VRT references difference that could be a result of the changes on this PR.

Docs impact

Button guidelines (Staging link)

Production Localhost
image image

It set anchorClassName to eui-fullWidth so that the anchor takes the whole width of the container. Otherwise, the result would be:

full width classname

Context menu (Staging link)

Production Localhost
image image

It set anchorClassName to eui-fullWidth so that the anchor takes the whole width of the container.

Icons (Staging link)

Production Localhost
image image

It set display="block" on the EuiToolTip anchor:

<EuiToolTipAnchor
{...anchorProps}
ref={this.setAnchorRef}
onBlur={this.onBlur}
onFocus={this.onFocus}
onKeyDown={this.onEscapeKey}
onMouseOver={this.showToolTip}
onMouseOut={this.onMouseOut}
// `id` defines if the trigger and tooltip are automatically linked via `aria-describedby`.
id={!disableScreenReaderOutput ? id : undefined}
className={anchorClasses}
display={display!}
isVisible={visible}
>

Kibana impact

There are 3 usages that pass props other than: textToCopy (required), beforeMessage, afterMessage

All usages | Update commit

Cloud UI impact

There are no usages that pass props other than: textToCopy (required), beforeMessage, afterMessage

All usages

QA

Specific checklist

  • The unit tests pass in CI
  • The doc pages have no regression (staging links above)
  • The EuiCopy component has no regression in Storybook (you have to run Storybook locally with: yarn workspace @elastic/eui start) or on the documentation page
  • The Kibana and Cloud UI affected usages lists are complete

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
    • Added documentation (updated it)
    • Props have proper autodocs (using @default if default values are missing) and playground toggles (control for the prop, by default object)
    • Checked Code Sandbox works for any docs examples
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@weronikaolejniczak weronikaolejniczak self-assigned this Jun 6, 2025
@weronikaolejniczak weronikaolejniczak added the breaking change PRs with breaking changes. (Don't delete - used for automation) label Jun 6, 2025
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:

  • If this PR contains prop/API changes:
    • Search through Kibana for <EuiComponent usages (example search)
    • In the PR description or in a PR comment, include a count or list with the number of component usages in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • If this PR contains CSS changes:
    • Search through Kibana for the changed EUI selectors, e.g. .euiComponent (example search)
    • In the PR description or in a PR comment, include a count or list with the number of custom CSS overrides in Kibana that will need to be updated (if that amount is "none", include that information as well)
  • 🔍 Tip: When searching through Kibana, consider excluding **/target, **/*.snap, **/*.storyshot files to reduce noise and only look at source code usages
  • ⚠️ For extremely risky changes, the EUI team should potentially consider the following precautions:
    • Using a pre-release release candidate to test Kibana CI ahead of time
    • Using kibana-a-la-carte for manual QA, and to give other Kibana teams a staging server to quickly test against

@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review June 6, 2025 15:30
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner June 6, 2025 15:30
@weronikaolejniczak
Copy link
Contributor Author

@mgadewoll thank you for the review, I applied your suggestions

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @weronikaolejniczak

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @weronikaolejniczak

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Thanks for the updates. Changes LGTM and the component works as expected 👍

@mgadewoll mgadewoll merged commit 84890ea into elastic:main Jun 23, 2025
5 checks passed
mgadewoll added a commit to elastic/kibana that referenced this pull request Jun 25, 2025
`103.1.0` ⏩ `104.0.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

- updates flat tooltip prop usages on **EuiCopy** to use new
`tooltipProp`

## Package updates

### `@elastic/eui`

## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2)

**Bug fixes**

- Fixed missing JSON token exports for
`euiColorBackgroundBaseInteractiveSelectHover` and
`euiColorBorderStrongText`
([#8819](elastic/eui#8819))

## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1)

**Bug fixes**

- Fixed a wrong path in the module declaration for the JSON token
exports that would trigger typescript errors
([#8818](elastic/eui#8818))

## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0)

- Added data vis text color tokens:
([#8793](elastic/eui#8793))
  - `colors.vis.euiColorVisText0`
  - `colors.vis.euiColorVisText1`
  - `colors.vis.euiColorVisText2`
  - `colors.vis.euiColorVisText3`
  - `colors.vis.euiColorVisText4`
  - `colors.vis.euiColorVisText5`
  - `colors.vis.euiColorVisText6`
  - `colors.vis.euiColorVisText7`
  - `colors.vis.euiColorVisText8`
  - `colors.vis.euiColorVisText9`
- Updated and aligned background hover styles for `EuiTable` and
`EuiDataGrid` ([#8769](elastic/eui#8769))

**Deprecations**

- Deprecated `euiPaletteForLightBackground` and
`euiPaletteForDarkBackground` palettes. Use the newly added data vis
color tokens instead.
([#8793](elastic/eui#8793))

**Breaking changes**

- Removed tokens: ([#8793](elastic/eui#8793))
  - `colors.vis.euiColorVisAsTextLight1`
  - `colors.vis.euiColorVisAsTextLight0`
  - `colors.vis.euiColorVisAsTextLight2`
  - `colors.vis.euiColorVisAsTextLight3`
  - `colors.vis.euiColorVisAsTextLight4`
  - `colors.vis.euiColorVisAsTextLight5`
  - `colors.vis.euiColorVisAsTextLight6`
  - `colors.vis.euiColorVisAsTextDark1`
  - `colors.vis.euiColorVisAsTextDark0`
  - `colors.vis.euiColorVisAsTextDark2`
  - `colors.vis.euiColorVisAsTextDark3`
  - `colors.vis.euiColorVisAsTextDark4`
  - `colors.vis.euiColorVisAsTextDark5`
  - `colors.vis.euiColorVisAsTextDark6`
- Removed `xl` size from `EuiTabs`
([#8762](elastic/eui#8762))
- Added `tooltipProps` to `EuiCopy` which replaces spreading all props
to `EuiToolTip` ([#8758](elastic/eui#8758))

<!--ONMERGE {"backportTargets":["8.19"]} ONMERGE-->

---------

Co-authored-by: Elastic Machine <[email protected]>
mgadewoll added a commit to mgadewoll/kibana that referenced this pull request Jul 14, 2025
`103.1.0` ⏩ `104.0.2`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

- updates flat tooltip prop usages on **EuiCopy** to use new
`tooltipProp`

## Package updates

### `@elastic/eui`

## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2)

**Bug fixes**

- Fixed missing JSON token exports for
`euiColorBackgroundBaseInteractiveSelectHover` and
`euiColorBorderStrongText`
([elastic#8819](elastic/eui#8819))

## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1)

**Bug fixes**

- Fixed a wrong path in the module declaration for the JSON token
exports that would trigger typescript errors
([elastic#8818](elastic/eui#8818))

## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0)

- Added data vis text color tokens:
([elastic#8793](elastic/eui#8793))
  - `colors.vis.euiColorVisText0`
  - `colors.vis.euiColorVisText1`
  - `colors.vis.euiColorVisText2`
  - `colors.vis.euiColorVisText3`
  - `colors.vis.euiColorVisText4`
  - `colors.vis.euiColorVisText5`
  - `colors.vis.euiColorVisText6`
  - `colors.vis.euiColorVisText7`
  - `colors.vis.euiColorVisText8`
  - `colors.vis.euiColorVisText9`
- Updated and aligned background hover styles for `EuiTable` and
`EuiDataGrid` ([elastic#8769](elastic/eui#8769))

**Deprecations**

- Deprecated `euiPaletteForLightBackground` and
`euiPaletteForDarkBackground` palettes. Use the newly added data vis
color tokens instead.
([elastic#8793](elastic/eui#8793))

**Breaking changes**

- Removed tokens: ([elastic#8793](elastic/eui#8793))
  - `colors.vis.euiColorVisAsTextLight1`
  - `colors.vis.euiColorVisAsTextLight0`
  - `colors.vis.euiColorVisAsTextLight2`
  - `colors.vis.euiColorVisAsTextLight3`
  - `colors.vis.euiColorVisAsTextLight4`
  - `colors.vis.euiColorVisAsTextLight5`
  - `colors.vis.euiColorVisAsTextLight6`
  - `colors.vis.euiColorVisAsTextDark1`
  - `colors.vis.euiColorVisAsTextDark0`
  - `colors.vis.euiColorVisAsTextDark2`
  - `colors.vis.euiColorVisAsTextDark3`
  - `colors.vis.euiColorVisAsTextDark4`
  - `colors.vis.euiColorVisAsTextDark5`
  - `colors.vis.euiColorVisAsTextDark6`
- Removed `xl` size from `EuiTabs`
([elastic#8762](elastic/eui#8762))
- Added `tooltipProps` to `EuiCopy` which replaces spreading all props
to `EuiToolTip` ([elastic#8758](elastic/eui#8758))

<!--ONMERGE {"backportTargets":["8.19"]} ONMERGE-->

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit efedad1)

# Conflicts:
#	package.json
#	src/dev/license_checker/config.ts
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change PRs with breaking changes. (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EuiCopy] Add tooltipProps prop

3 participants