Internal server error when saving a widget with German characters in name#8758
Merged
spalger merged 3 commits intoelastic:masterfrom Oct 19, 2016
Merged
Internal server error when saving a widget with German characters in name#8758spalger merged 3 commits intoelastic:masterfrom
spalger merged 3 commits intoelastic:masterfrom
Conversation
Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes elastic#8705
spalger
force-pushed
the
issue-8705-header-encoding
branch
from
89d8b93 to
fec5e1a
Compare
tylersmalley
approved these changes
Oct 19, 2016
jbudz
approved these changes
Oct 19, 2016
elastic-jasper
added a commit
that referenced
this pull request
Oct 19, 2016
--------- **Commit 1:** URI-encode forwarded location header in proxy Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes #8705 * Original sha: 18c23c1 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-18T17:55:31Z **Commit 2:** Add test to verify umlaut in vis name Relates to #8705 * Original sha: e100e1f * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-19T09:01:46Z **Commit 3:** [elasticsearch/proxy] use different code path with erorr * Original sha: fec5e1a * Authored by spalger <email@spalger.com> on 2016-10-19T19:06:39Z
elastic-jasper
added a commit
that referenced
this pull request
Oct 19, 2016
--------- **Commit 1:** URI-encode forwarded location header in proxy Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes #8705 * Original sha: 18c23c1 * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-18T17:55:31Z **Commit 2:** Add test to verify umlaut in vis name Relates to #8705 * Original sha: e100e1f * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-19T09:01:46Z **Commit 3:** [elasticsearch/proxy] use different code path with erorr * Original sha: fec5e1a * Authored by spalger <email@spalger.com> on 2016-10-19T19:06:39Z
spalger
added a commit
that referenced
this pull request
Oct 19, 2016
[backport] PR #8758 to 5.0 - Internal server error when saving a widget with German characters in name
spalger
added a commit
that referenced
this pull request
Oct 19, 2016
[backport] PR #8758 to 5.x - Internal server error when saving a widget with German characters in name
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** URI-encode forwarded location header in proxy Right now there are situations in which ElasticSearch puts characters in the character code range between 128 and 255 into the `Location` header. This leads to an exception when trying to pass on that header through the hapi proxy in versions before 15.0.0, because it validates that only US-ASCII characters are used in headers. To work around that situation, the `Location` header is encoded using `encodeURI()` for now. Closes elastic#8705 * Original sha: 03ccb8ec56eb92c86162e307a286305384ba92c3 [formerly 18c23c1] * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-18T17:55:31Z **Commit 2:** Add test to verify umlaut in vis name Relates to elastic#8705 * Original sha: 238f6f64a55d113f30fd8f61f5330c1c97f23627 [formerly e100e1f] * Authored by Felix Stürmer <stuermer@weltenwort.de> on 2016-10-19T09:01:46Z **Commit 3:** [elasticsearch/proxy] use different code path with erorr * Original sha: 0f7e4548c7808d845bf0df661d9a3742b81f14da [formerly fec5e1a] * Authored by spalger <email@spalger.com> on 2016-10-19T19:06:39Z Former-commit-id: afbc790
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8758 to 5.x - Internal server error when saving a widget with German characters in name Former-commit-id: 2c0a221
mgadewoll
added a commit
that referenced
this pull request
Jun 25, 2025
`103.1.0` ⏩ `104.0.2` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes - updates flat tooltip prop usages on **EuiCopy** to use new `tooltipProp` ## Package updates ### `@elastic/eui` ## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2) **Bug fixes** - Fixed missing JSON token exports for `euiColorBackgroundBaseInteractiveSelectHover` and `euiColorBorderStrongText` ([#8819](elastic/eui#8819)) ## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1) **Bug fixes** - Fixed a wrong path in the module declaration for the JSON token exports that would trigger typescript errors ([#8818](elastic/eui#8818)) ## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0) - Added data vis text color tokens: ([#8793](elastic/eui#8793)) - `colors.vis.euiColorVisText0` - `colors.vis.euiColorVisText1` - `colors.vis.euiColorVisText2` - `colors.vis.euiColorVisText3` - `colors.vis.euiColorVisText4` - `colors.vis.euiColorVisText5` - `colors.vis.euiColorVisText6` - `colors.vis.euiColorVisText7` - `colors.vis.euiColorVisText8` - `colors.vis.euiColorVisText9` - Updated and aligned background hover styles for `EuiTable` and `EuiDataGrid` ([#8769](elastic/eui#8769)) **Deprecations** - Deprecated `euiPaletteForLightBackground` and `euiPaletteForDarkBackground` palettes. Use the newly added data vis color tokens instead. ([#8793](elastic/eui#8793)) **Breaking changes** - Removed tokens: ([#8793](elastic/eui#8793)) - `colors.vis.euiColorVisAsTextLight1` - `colors.vis.euiColorVisAsTextLight0` - `colors.vis.euiColorVisAsTextLight2` - `colors.vis.euiColorVisAsTextLight3` - `colors.vis.euiColorVisAsTextLight4` - `colors.vis.euiColorVisAsTextLight5` - `colors.vis.euiColorVisAsTextLight6` - `colors.vis.euiColorVisAsTextDark1` - `colors.vis.euiColorVisAsTextDark0` - `colors.vis.euiColorVisAsTextDark2` - `colors.vis.euiColorVisAsTextDark3` - `colors.vis.euiColorVisAsTextDark4` - `colors.vis.euiColorVisAsTextDark5` - `colors.vis.euiColorVisAsTextDark6` - Removed `xl` size from `EuiTabs` ([#8762](elastic/eui#8762)) - Added `tooltipProps` to `EuiCopy` which replaces spreading all props to `EuiToolTip` ([#8758](elastic/eui#8758)) <!--ONMERGE {"backportTargets":["8.19"]} ONMERGE--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mgadewoll
added a commit
to mgadewoll/kibana
that referenced
this pull request
Jul 14, 2025
`103.1.0` ⏩ `104.0.2` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes - updates flat tooltip prop usages on **EuiCopy** to use new `tooltipProp` ## Package updates ### `@elastic/eui` ## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2) **Bug fixes** - Fixed missing JSON token exports for `euiColorBackgroundBaseInteractiveSelectHover` and `euiColorBorderStrongText` ([elastic#8819](elastic/eui#8819)) ## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1) **Bug fixes** - Fixed a wrong path in the module declaration for the JSON token exports that would trigger typescript errors ([elastic#8818](elastic/eui#8818)) ## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0) - Added data vis text color tokens: ([elastic#8793](elastic/eui#8793)) - `colors.vis.euiColorVisText0` - `colors.vis.euiColorVisText1` - `colors.vis.euiColorVisText2` - `colors.vis.euiColorVisText3` - `colors.vis.euiColorVisText4` - `colors.vis.euiColorVisText5` - `colors.vis.euiColorVisText6` - `colors.vis.euiColorVisText7` - `colors.vis.euiColorVisText8` - `colors.vis.euiColorVisText9` - Updated and aligned background hover styles for `EuiTable` and `EuiDataGrid` ([elastic#8769](elastic/eui#8769)) **Deprecations** - Deprecated `euiPaletteForLightBackground` and `euiPaletteForDarkBackground` palettes. Use the newly added data vis color tokens instead. ([elastic#8793](elastic/eui#8793)) **Breaking changes** - Removed tokens: ([elastic#8793](elastic/eui#8793)) - `colors.vis.euiColorVisAsTextLight1` - `colors.vis.euiColorVisAsTextLight0` - `colors.vis.euiColorVisAsTextLight2` - `colors.vis.euiColorVisAsTextLight3` - `colors.vis.euiColorVisAsTextLight4` - `colors.vis.euiColorVisAsTextLight5` - `colors.vis.euiColorVisAsTextLight6` - `colors.vis.euiColorVisAsTextDark1` - `colors.vis.euiColorVisAsTextDark0` - `colors.vis.euiColorVisAsTextDark2` - `colors.vis.euiColorVisAsTextDark3` - `colors.vis.euiColorVisAsTextDark4` - `colors.vis.euiColorVisAsTextDark5` - `colors.vis.euiColorVisAsTextDark6` - Removed `xl` size from `EuiTabs` ([elastic#8762](elastic/eui#8762)) - Added `tooltipProps` to `EuiCopy` which replaces spreading all props to `EuiToolTip` ([elastic#8758](elastic/eui#8758)) <!--ONMERGE {"backportTargets":["8.19"]} ONMERGE--> --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit efedad1) # Conflicts: # package.json # src/dev/license_checker/config.ts # yarn.lock
mgadewoll
added a commit
that referenced
this pull request
Jul 14, 2025
# Backport This will backport the following commits from `main` to `8.19`: - [Upgrade EUI to v104.0.2 (#224855)](#224855) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lene Gadewoll","email":"lene.gadewoll@elastic.co"},"sourceCommit":{"committedDate":"2025-06-25T14:55:46Z","message":"Upgrade EUI to v104.0.2 (#224855)\n\n`103.1.0` ⏩ `104.0.2`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n## Changes\n\n- updates flat tooltip prop usages on **EuiCopy** to use new\n`tooltipProp`\n\n## Package updates\n\n### `@elastic/eui`\n\n## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2)\n\n**Bug fixes**\n\n- Fixed missing JSON token exports for\n`euiColorBackgroundBaseInteractiveSelectHover` and\n`euiColorBorderStrongText`\n([#8819](https://github.com/elastic/eui/pull/8819))\n\n## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1)\n\n**Bug fixes**\n\n- Fixed a wrong path in the module declaration for the JSON token\nexports that would trigger typescript errors\n([#8818](https://github.com/elastic/eui/pull/8818))\n\n## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0)\n\n- Added data vis text color tokens:\n([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisText0`\n - `colors.vis.euiColorVisText1`\n - `colors.vis.euiColorVisText2`\n - `colors.vis.euiColorVisText3`\n - `colors.vis.euiColorVisText4`\n - `colors.vis.euiColorVisText5`\n - `colors.vis.euiColorVisText6`\n - `colors.vis.euiColorVisText7`\n - `colors.vis.euiColorVisText8`\n - `colors.vis.euiColorVisText9`\n- Updated and aligned background hover styles for `EuiTable` and\n`EuiDataGrid` ([#8769](https://github.com/elastic/eui/pull/8769))\n\n**Deprecations**\n\n- Deprecated `euiPaletteForLightBackground` and\n`euiPaletteForDarkBackground` palettes. Use the newly added data vis\ncolor tokens instead.\n([#8793](https://github.com/elastic/eui/pull/8793))\n\n**Breaking changes**\n\n- Removed tokens: ([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisAsTextLight1`\n - `colors.vis.euiColorVisAsTextLight0`\n - `colors.vis.euiColorVisAsTextLight2`\n - `colors.vis.euiColorVisAsTextLight3`\n - `colors.vis.euiColorVisAsTextLight4`\n - `colors.vis.euiColorVisAsTextLight5`\n - `colors.vis.euiColorVisAsTextLight6`\n - `colors.vis.euiColorVisAsTextDark1`\n - `colors.vis.euiColorVisAsTextDark0`\n - `colors.vis.euiColorVisAsTextDark2`\n - `colors.vis.euiColorVisAsTextDark3`\n - `colors.vis.euiColorVisAsTextDark4`\n - `colors.vis.euiColorVisAsTextDark5`\n - `colors.vis.euiColorVisAsTextDark6`\n- Removed `xl` size from `EuiTabs`\n([#8762](https://github.com/elastic/eui/pull/8762))\n- Added `tooltipProps` to `EuiCopy` which replaces spreading all props\nto `EuiToolTip` ([#8758](https://github.com/elastic/eui/pull/8758))\n\n\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"efedad1b3e36460cd6ac5e73837e333c54d75861","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","EUI","backport:skip","ci:cloud-deploy","v9.2.0"],"title":"Upgrade EUI to v104.0.2","number":224855,"url":"https://github.com/elastic/kibana/pull/224855","mergeCommit":{"message":"Upgrade EUI to v104.0.2 (#224855)\n\n`103.1.0` ⏩ `104.0.2`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n## Changes\n\n- updates flat tooltip prop usages on **EuiCopy** to use new\n`tooltipProp`\n\n## Package updates\n\n### `@elastic/eui`\n\n## [`v104.0.2`](https://github.com/elastic/eui/releases/v104.0.2)\n\n**Bug fixes**\n\n- Fixed missing JSON token exports for\n`euiColorBackgroundBaseInteractiveSelectHover` and\n`euiColorBorderStrongText`\n([#8819](https://github.com/elastic/eui/pull/8819))\n\n## [`v104.0.1`](https://github.com/elastic/eui/releases/v104.0.1)\n\n**Bug fixes**\n\n- Fixed a wrong path in the module declaration for the JSON token\nexports that would trigger typescript errors\n([#8818](https://github.com/elastic/eui/pull/8818))\n\n## [`v104.0.0`](https://github.com/elastic/eui/releases/v104.0.0)\n\n- Added data vis text color tokens:\n([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisText0`\n - `colors.vis.euiColorVisText1`\n - `colors.vis.euiColorVisText2`\n - `colors.vis.euiColorVisText3`\n - `colors.vis.euiColorVisText4`\n - `colors.vis.euiColorVisText5`\n - `colors.vis.euiColorVisText6`\n - `colors.vis.euiColorVisText7`\n - `colors.vis.euiColorVisText8`\n - `colors.vis.euiColorVisText9`\n- Updated and aligned background hover styles for `EuiTable` and\n`EuiDataGrid` ([#8769](https://github.com/elastic/eui/pull/8769))\n\n**Deprecations**\n\n- Deprecated `euiPaletteForLightBackground` and\n`euiPaletteForDarkBackground` palettes. Use the newly added data vis\ncolor tokens instead.\n([#8793](https://github.com/elastic/eui/pull/8793))\n\n**Breaking changes**\n\n- Removed tokens: ([#8793](https://github.com/elastic/eui/pull/8793))\n - `colors.vis.euiColorVisAsTextLight1`\n - `colors.vis.euiColorVisAsTextLight0`\n - `colors.vis.euiColorVisAsTextLight2`\n - `colors.vis.euiColorVisAsTextLight3`\n - `colors.vis.euiColorVisAsTextLight4`\n - `colors.vis.euiColorVisAsTextLight5`\n - `colors.vis.euiColorVisAsTextLight6`\n - `colors.vis.euiColorVisAsTextDark1`\n - `colors.vis.euiColorVisAsTextDark0`\n - `colors.vis.euiColorVisAsTextDark2`\n - `colors.vis.euiColorVisAsTextDark3`\n - `colors.vis.euiColorVisAsTextDark4`\n - `colors.vis.euiColorVisAsTextDark5`\n - `colors.vis.euiColorVisAsTextDark6`\n- Removed `xl` size from `EuiTabs`\n([#8762](https://github.com/elastic/eui/pull/8762))\n- Added `tooltipProps` to `EuiCopy` which replaces spreading all props\nto `EuiToolTip` ([#8758](https://github.com/elastic/eui/pull/8758))\n\n\n\n---------\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"efedad1b3e36460cd6ac5e73837e333c54d75861"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #8705
Closes #8705