[backport] PR #8740 to 5.0 - Adapt to ip range breaking changes in ES 5.0+#8760
Merged
[backport] PR #8740 to 5.0 - Adapt to ip range breaking changes in ES 5.0+#8760
Conversation
--------- **Commit 1:** Generate key for ip range from/to agg Elasticsearch 5.0 no longer returns a `key` prop with ip range buckets when from/to is used in the request. Looking at the [2.x docs][1] it appears to be a mistake that it was ever included in the first place. So now we'll generate the key ourselves. [1]: https://www.elastic.co/guide/en/elasticsearch/reference/2.4/search-aggregations-bucket-iprange-aggregation.html Fixes: #8736 * Original sha: f344a4b * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T22:51:56Z **Commit 2:** Stop sending null in ip range from/to props The IP range agg supports open ended ranges. Elasticsearch 2.x was lenient and accepted null as a value for the from/to props, but the correct way to do an open ended range was always to omit the from/to key entirely. ES 5.0 appears to be more strict and barfs when null is passed. This commit removes the null values. Fixes #8741 * Original sha: 3ca45ba * Authored by Matthew Bargar <mbargar@gmail.com> on 2016-10-18T23:18:14Z **Commit 3:** ip range label and filter improvements * updated the filter labels to match the range labels * fixed the filter creation to work for unbound ranges * Original sha: b153ea0 * Authored by Spencer <spalger@users.noreply.github.com> on 2016-10-19T17:57:58Z * Committed by Matthew Bargar <mbargar@gmail.com> on 2016-10-19T18:36:22Z
spalger
force-pushed
the
jasper/backport/8740/5.0
branch
from
6882561 to
5f33808
Compare
Contributor
|
Just waiting on intake and selenium to run before merging these |
epixa
changed the title
weronikaolejniczak
added a commit
that referenced
this pull request
Jun 13, 2025
`@elastic/eslint-plugin-eui`: `1.0.0` ⏩ `2.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v2.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` **Breaking changes** - Remove `prefer-css-prop-for-static-styles` rule because it produces too many warnings. Static code analysis cannot flag dynamic styles with confidence because it doesn't run the code to asses runtime values. We will explore runtime solutions. ([#8760](elastic/eui#8760))
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
`@elastic/eslint-plugin-eui`: `1.0.0` ⏩ `2.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v2.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` **Breaking changes** - Remove `prefer-css-prop-for-static-styles` rule because it produces too many warnings. Static code analysis cannot flag dynamic styles with confidence because it doesn't run the code to asses runtime values. We will explore runtime solutions. ([elastic#8760](elastic/eui#8760))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport PR #8740
Commit 1:
Generate key for ip range from/to agg
Elasticsearch 5.0 no longer returns a
keyprop with ip range bucketswhen from/to is used in the request. Looking at the 2.x docs it
appears to be a mistake that it was ever included in the first place.
So now we'll generate the key ourselves.
Fixes: #8736
Commit 2:
Stop sending null in ip range from/to props
The IP range agg supports open ended ranges. Elasticsearch 2.x was
lenient and accepted null as a value for the from/to props, but the
correct way to do an open ended range was always to omit the from/to
key entirely. ES 5.0 appears to be more strict and barfs when null is
passed. This commit removes the null values.
Fixes #8741
Commit 3:
ip range label and filter improvements