feat(eslint-plugin): remove prefer-css-prop-for-static-styles rule #8760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weronikaolejniczak
added
the
breaking change
|
This PR contains breaking changes. The opener of this pull request is asked to perform the following due diligence steps below, to assist EUI in our next Kibana upgrade:
|
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
|
acstll
approved these changes
Jun 11, 2025
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
I ran test and build locally. Everything seems to be correct. Thanks for tackling this one (again!).
| @@ -0,0 +1,3 @@ | |||
| **Breaking changes** | |||
|
|
|||
| - Remove `prefer-css-prop-for-static-styles` rule because it produces too many warnings. Static code analysis cannot flag dynamic styles with confidence because it doesn't run the code to asses runtime values. We will explore runtime solutions. | |||
Contributor
There was a problem hiding this comment.
[no action required] I first thought this was too long, but after reading it several times I think it's good to have all this information here (you can understand right away the reason why the rule is being removed, and if you need more context, there will be the link to the PR, etc.)
Contributor
Author
There was a problem hiding this comment.
Exactly, following what @JasonStoltz proposed to make the breaking changes more clear.
weronikaolejniczak
added a commit
to elastic/kibana
that referenced
this pull request
Jun 13, 2025
`@elastic/eslint-plugin-eui`: `1.0.0` ⏩ `2.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v2.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` **Breaking changes** - Remove `prefer-css-prop-for-static-styles` rule because it produces too many warnings. Static code analysis cannot flag dynamic styles with confidence because it doesn't run the code to asses runtime values. We will explore runtime solutions. ([#8760](elastic/eui#8760))
iblancof
pushed a commit
to iblancof/kibana
that referenced
this pull request
Jun 16, 2025
`@elastic/eslint-plugin-eui`: `1.0.0` ⏩ `2.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v2.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` **Breaking changes** - Remove `prefer-css-prop-for-static-styles` rule because it produces too many warnings. Static code analysis cannot flag dynamic styles with confidence because it doesn't run the code to asses runtime values. We will explore runtime solutions. ([elastic#8760](elastic/eui#8760))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
This is a breaking change.
Closes #8708
Removes
prefer-css-prop-for-static-stylesrule. Read comments on the issue to understand the context.tl;dr; Using a static code analysis tool like ESLint is unfit for the job. The rule as of now produces too many warnings. We want to explore runtime solutions that can flag dynamic styles.
Kibana impact
There is only 1 mention:
x-pack/solutions/security/plugins/security_solution/public/asset_inventory/components/asset_inventory_bar_chart.tsxUpdate commit
Cloud UI impact
No disable comments / rule overrides (search)