Skip to content

Add color formatter for string fields #8597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spalger merged 10 commits into from
Oct 28, 2016
Merged

Add color formatter for string fields #8597

spalger merged 10 commits into from
Oct 28, 2016

Conversation

@marcelhallmann
Copy link
Contributor

@marcelhallmann marcelhallmann commented Oct 8, 2016 •
edited by epixa
Loading

The pull request addresses the isse #6537 (#6537).
I think it would be nice to integrate the code also in the current 5.x version.

Content:
Now a string field can be colored depending on a specified regex.
Let me show the result using some screenshot:

At first you can see that it is possible now to choose the color-formatter on a string field:
color_in_string_field_1

Very similar to the already exisiting number coloring it is possible to define a condition:
color_in_string_field_2

In the Discover tab the result looks like:
color_in_string_field_3

And in a vizualization (data table) it looks like:
color_in_string_field_4
I also added the column "referer" to demonstrate that the exisiting string formatters / transformers like uppercase are still working.

Closes #6537

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 8, 2016

Can one of the admins verify this patch?

spalger
spalger suggested changes Oct 11, 2016
View reviewed changes
src/ui/public/stringify/types/color.js Outdated
html(val, field) {

var color;
if (field.type === 'string' || field === 'string') {
Copy link
Contributor

@spalger spalger Oct 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the logic for coloring numbers vs strings is pretty different (including completely different parameters), I think we should duplicate the existing formatter, and modify it to support strings instead of numbers.

Copy link
Contributor Author

@marcelhallmann marcelhallmann Oct 14, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spalger
Excuse the question, but are you going to move the code in a separate formatter, or do you want me to do this?

Copy link
Contributor

@spalger spalger Oct 17, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy to, didn't want to step on toes :)

Copy link
Contributor Author

@marcelhallmann marcelhallmann Oct 18, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to you :)
Just tell me if you are going to do it - or if I should (haven't started refactoring yet)

Copy link
Contributor

@spalger spalger Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of it, thanks!

@spalger spalger self-assigned this Oct 11, 2016
thomasneirynck
thomasneirynck approved these changes Oct 28, 2016
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice & useful improvement!

@spalger spalger added the v6.0.0 label Oct 28, 2016
@spalger spalger merged commit 409a30b into elastic:master Oct 28, 2016
elastic-jasper added a commit that referenced this pull request Oct 28, 2016
@elastic-jasper
Backport PR #8597
2479bc9 
---------

**Commit 1:**
#6537 add color formatting for string fields

* Original sha: ca87c48
* Authored by Marcel Hallmann <[email protected]> on 2016-09-29T12:53:19Z

**Commit 2:**
#6537 adjust test

* Original sha: 23e2ce1
* Authored by marcelhallmann <[email protected]> on 2016-10-05T08:21:24Z

**Commit 3:**
Merge remote-tracking branch 'upstream/master'

* Original sha: bdf66fb
* Authored by Marcel Hallmann <[email protected]> on 2016-10-07T11:19:00Z

**Commit 4:**
#6537 adjust check

* Original sha: a4bf798
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T17:58:51Z

**Commit 5:**
#6537 add simple check to enable coloring in viz (data table), too

* Original sha: e67f6eb
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:01:12Z

**Commit 6:**
#6537 call the field formatter instead of the toString() function

* Original sha: 7dc7fd5
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:47:39Z

**Commit 7:**
#6537 add some tests for coloring string fields

* Original sha: 9733fe5
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:48:46Z

**Commit 8:**
#6537 better default value for regex field

* Original sha: fed9df2
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T19:13:40Z

**Commit 9:**
Merge branch 'master' of github.com:elastic/kibana into pr/8597

* Original sha: b583db7
* Authored by spalger <[email protected]> on 2016-10-27T19:31:25Z

**Commit 10:**
[stringify] track field type in params

* Original sha: c84a61b
* Authored by spalger <[email protected]> on 2016-10-27T21:04:19Z
@elastic-jasper elastic-jasper mentioned this pull request Oct 28, 2016
Merged
spalger pushed a commit that referenced this pull request Oct 28, 2016
@elastic-jasper @spalger
Backport PR #8597 - Add color formatter for string fields
f2e3528 
---------

**Commit 1:**
#6537 add color formatting for string fields

* Original sha: ca87c48
* Authored by Marcel Hallmann <[email protected]> on 2016-09-29T12:53:19Z

**Commit 2:**
#6537 adjust test

* Original sha: 23e2ce1
* Authored by marcelhallmann <[email protected]> on 2016-10-05T08:21:24Z

**Commit 3:**
Merge remote-tracking branch 'upstream/master'

* Original sha: bdf66fb
* Authored by Marcel Hallmann <[email protected]> on 2016-10-07T11:19:00Z

**Commit 4:**
#6537 adjust check

* Original sha: a4bf798
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T17:58:51Z

**Commit 5:**
#6537 add simple check to enable coloring in viz (data table), too

* Original sha: e67f6eb
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:01:12Z

**Commit 6:**
#6537 call the field formatter instead of the toString() function

* Original sha: 7dc7fd5
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:47:39Z

**Commit 7:**
#6537 add some tests for coloring string fields

* Original sha: 9733fe5
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:48:46Z

**Commit 8:**
#6537 better default value for regex field

* Original sha: fed9df2
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T19:13:40Z

**Commit 9:**
Merge branch 'master' of github.com:elastic/kibana into pr/8597

* Original sha: b583db7
* Authored by spalger <[email protected]> on 2016-10-27T19:31:25Z

**Commit 10:**
[stringify] track field type in params

* Original sha: c84a61b
* Authored by spalger <[email protected]> on 2016-10-27T21:04:19Z
@epixa epixa changed the title Add coloring for string fields, closes #6537 Add color formatter for string fields Oct 31, 2016
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 10, 2016
@marcelhallmann @nreese
Add coloring for string fields, closes elastic#6537 (elastic#8597)
72748d2 
* elastic#6537 add color formatting for string fields

* elastic#6537 adjust test

* elastic#6537 adjust check

* elastic#6537 add simple check to enable coloring in viz (data table), too

* elastic#6537 call the field formatter instead of the toString() function

* elastic#6537 add some tests for coloring string fields

* elastic#6537 better default value for regex field

* [stringify] track field type in params
@epixa epixa added v5.1.1 and removed v5.1.0 labels Dec 8, 2016
airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017
@elastic-jasper @spalger
Backport PR elastic#8597 - Add color formatter for string fields
6be8108 
---------

**Commit 1:**
elastic#6537 add color formatting for string fields

* Original sha: ca87c48
* Authored by Marcel Hallmann <[email protected]> on 2016-09-29T12:53:19Z

**Commit 2:**
elastic#6537 adjust test

* Original sha: 23e2ce1
* Authored by marcelhallmann <[email protected]> on 2016-10-05T08:21:24Z

**Commit 3:**
Merge remote-tracking branch 'upstream/master'

* Original sha: bdf66fb
* Authored by Marcel Hallmann <[email protected]> on 2016-10-07T11:19:00Z

**Commit 4:**
elastic#6537 adjust check

* Original sha: a4bf798
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T17:58:51Z

**Commit 5:**
elastic#6537 add simple check to enable coloring in viz (data table), too

* Original sha: e67f6eb
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:01:12Z

**Commit 6:**
elastic#6537 call the field formatter instead of the toString() function

* Original sha: 7dc7fd5
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:47:39Z

**Commit 7:**
elastic#6537 add some tests for coloring string fields

* Original sha: 9733fe5
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T18:48:46Z

**Commit 8:**
elastic#6537 better default value for regex field

* Original sha: fed9df2
* Authored by Marcel Hallmann <[email protected]> on 2016-10-08T19:13:40Z

**Commit 9:**
Merge branch 'master' of github.com:elastic/kibana into pr/8597

* Original sha: b583db7
* Authored by spalger <[email protected]> on 2016-10-27T19:31:25Z

**Commit 10:**
[stringify] track field type in params

* Original sha: c84a61b
* Authored by spalger <[email protected]> on 2016-10-27T21:04:19Z

Former-commit-id: f2e3528
@cjcenizal cjcenizal mentioned this pull request Jul 17, 2018
Closed
mgadewoll added a commit that referenced this pull request Apr 24, 2025
@mgadewoll @elasticmachine
Upgrade EUI to v101.4.0 (#218778)
d2d2765 
`101.3.0` ⏩ `101.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

This PR only updates tests and snapshots related to changes on EUI side:
- updated `aria-current="true"` to `aria-current="page"`
- updated icon usage `userAvatar` to `user`

## Package updates

### `@elastic/eui`

#### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)

- Spread `labelProps` to the `label` element in `EuiCheckableCard`
([#8586](elastic/eui#8586))
- Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon`
([#8580](elastic/eui#8580))
- Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`,
`EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize
their internal Emotion styles
([#8565](elastic/eui#8565))
- Updated global `border.radius.medium` token value for default
`Borealis` theme to `4px`
([#8563](elastic/eui#8563))
- Updated `EuiProvider` to build themes including `highContrastMode`
([#8558](elastic/eui#8558))

**Accessibility**

- Removed the `aria-label` attribute from the `ul` element in
`EuiPagination` to avoid duplicate screen reader output
([#8597](elastic/eui#8597))
- Set a more specific `aria-current="page"` on list items in
`EuiPagination` ([#8597](elastic/eui#8597))
- Added `aria-modal` to `EuiFlyout` with `type="overlay"`
([#8591](elastic/eui#8591))

**Dependency updates**

- Updated `@elastic/prismjs-esql` to v1.1.0
([#8587](elastic/eui#8587))

### `@elastic/[email protected]`

- Updated component tokens to use `computed` values to ensure correct
inheritance from theme overrides
([#8558](elastic/eui#8558))
- Added `overrides.HCM` to `euiThemeBorealis` to support theme internal
overrides ([#8558](elastic/eui#8558))
- Updated `border.radius.medium` token value to `4px`
([#8563](elastic/eui#8563))

### `@elastic/[email protected]`

- Added support for theme `overrides` as optional part of
`EuiThemeShape` ([#8558](elastic/eui#8558))
- Updated `getComputed` to support high contrast mode overrides defined
on `overrides.HCM` ([#8558](elastic/eui#8558))

---------

Co-authored-by: Elastic Machine <[email protected]>
mgadewoll added a commit to mgadewoll/kibana that referenced this pull request Apr 24, 2025
@mgadewoll
Upgrade EUI to v101.4.0 (elastic#218778)
65e2098 
`101.3.0` ⏩ `101.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

This PR only updates tests and snapshots related to changes on EUI side:
- updated `aria-current="true"` to `aria-current="page"`
- updated icon usage `userAvatar` to `user`

## Package updates

### `@elastic/eui`

#### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)

- Spread `labelProps` to the `label` element in `EuiCheckableCard`
([elastic#8586](elastic/eui#8586))
- Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon`
([elastic#8580](elastic/eui#8580))
- Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`,
`EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize
their internal Emotion styles
([elastic#8565](elastic/eui#8565))
- Updated global `border.radius.medium` token value for default
`Borealis` theme to `4px`
([elastic#8563](elastic/eui#8563))
- Updated `EuiProvider` to build themes including `highContrastMode`
([elastic#8558](elastic/eui#8558))

**Accessibility**

- Removed the `aria-label` attribute from the `ul` element in
`EuiPagination` to avoid duplicate screen reader output
([elastic#8597](elastic/eui#8597))
- Set a more specific `aria-current="page"` on list items in
`EuiPagination` ([elastic#8597](elastic/eui#8597))
- Added `aria-modal` to `EuiFlyout` with `type="overlay"`
([elastic#8591](elastic/eui#8591))

**Dependency updates**

- Updated `@elastic/prismjs-esql` to v1.1.0
([elastic#8587](elastic/eui#8587))

### `@elastic/[email protected]`

- Updated component tokens to use `computed` values to ensure correct
inheritance from theme overrides
([elastic#8558](elastic/eui#8558))
- Added `overrides.HCM` to `euiThemeBorealis` to support theme internal
overrides ([elastic#8558](elastic/eui#8558))
- Updated `border.radius.medium` token value to `4px`
([elastic#8563](elastic/eui#8563))

### `@elastic/[email protected]`

- Added support for theme `overrides` as optional part of
`EuiThemeShape` ([elastic#8558](elastic/eui#8558))
- Updated `getComputed` to support high contrast mode overrides defined
on `overrides.HCM` ([elastic#8558](elastic/eui#8558))

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit d2d2765)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/index.test.tsx
#	x-pack/solutions/security/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_dns_table/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_http_table/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_top_countries_table/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_top_n_flow_table/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/tls_table/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/explore/network/components/users_table/__snapshots__/index.test.tsx.snap
mgadewoll added a commit that referenced this pull request Apr 24, 2025
@mgadewoll
[8.19] Upgrade EUI to v101.4.0 (#218823)
a2d08ab 
`101.3.0` ⏩ `101.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

>[!IMPORTANT]
This PR is a direct sibling to this [upgrade
PR](#218778) to `main`. The
difference is that it adds a standalone EUI package with the previous
"Amsterdam" theme.
Apart from the theme difference, **there are no further changes added**.

## Changes

This PR only updates tests and snapshots related to changes on EUI side:
- updated `aria-current="true"` to `aria-current="page"`
- updated icon usage `userAvatar` to `user`

## Package updates

### `@elastic/eui`

#### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)

- Spread `labelProps` to the `label` element in `EuiCheckableCard`
([#8586](elastic/eui#8586))
- Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon`
([#8580](elastic/eui#8580))
- Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`,
`EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize
their internal Emotion styles
([#8565](elastic/eui#8565))
- Updated global `border.radius.medium` token value for default
`Borealis` theme to `4px`
([#8563](elastic/eui#8563))
- Updated `EuiProvider` to build themes including `highContrastMode`
([#8558](elastic/eui#8558))

**Accessibility**

- Removed the `aria-label` attribute from the `ul` element in
`EuiPagination` to avoid duplicate screen reader output
([#8597](elastic/eui#8597))
- Set a more specific `aria-current="page"` on list items in
`EuiPagination` ([#8597](elastic/eui#8597))
- Added `aria-modal` to `EuiFlyout` with `type="overlay"`
([#8591](elastic/eui#8591))

**Dependency updates**

- Updated `@elastic/prismjs-esql` to v1.1.0
([#8587](elastic/eui#8587))

### `@elastic/[email protected]`

- Updated component tokens to use `computed` values to ensure correct
inheritance from theme overrides
([#8558](elastic/eui#8558))
- Added `overrides.HCM` to `euiThemeBorealis` to support theme internal
overrides ([#8558](elastic/eui#8558))
- Updated `border.radius.medium` token value to `4px`
([#8563](elastic/eui#8563))

### `@elastic/[email protected]`

- Added support for theme `overrides` as optional part of
`EuiThemeShape` ([#8558](elastic/eui#8558))
- Updated `getComputed` to support high contrast mode overrides defined
on `overrides.HCM` ([#8558](elastic/eui#8558))
mgadewoll added a commit that referenced this pull request Apr 24, 2025
@mgadewoll
[9.0] Upgrade EUI to v101.4.0 (#218778) (#219117)
1c15615 
# Backport

This will backport the following commits from `main` to `9.0`:
- [Upgrade EUI to v101.4.0
(#218778)](#218778)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Lene
Gadewoll","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-24T13:54:52Z","message":"Upgrade
EUI to v101.4.0 (#218778)\n\n`101.3.0` ⏩ `101.4.0`\n\n[Questions? Please
see our Kibana
upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n##
Changes\n\nThis PR only updates tests and snapshots related to changes
on EUI side:\n- updated `aria-current=\"true\"` to
`aria-current=\"page\"`\n- updated icon usage `userAvatar` to
`user`\n\n## Package updates\n\n### `@elastic/eui`\n\n####
[`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)\n\n-
Spread `labelProps` to the `label` element in
`EuiCheckableCard`\n([#8586](https://github.com/elastic/eui/pull/8586))\n-
Add `controls`, `flask`, `comment`, and `readOnly` glyphs to
`EuiIcon`\n([#8580](https://github.com/elastic/eui/pull/8580))\n-
Refactored `EuiExpression`, `EuiFacetGroup`,
`EuiFacetButton`,\n`EuiFilterGroup`, `EuiHeader`, `EuiImage` and
`EuiListGroup` to memoize\ntheir internal Emotion
styles\n([#8565](https://github.com/elastic/eui/pull/8565))\n- Updated
global `border.radius.medium` token value for default\n`Borealis` theme
to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n- Updated
`EuiProvider` to build themes including
`highContrastMode`\n([#8558](https://github.com/elastic/eui/pull/8558))\n\n**Accessibility**\n\n-
Removed the `aria-label` attribute from the `ul` element
in\n`EuiPagination` to avoid duplicate screen reader
output\n([#8597](https://github.com/elastic/eui/pull/8597))\n- Set a
more specific `aria-current=\"page\"` on list items in\n`EuiPagination`
([#8597](https://github.com/elastic/eui/pull/8597))\n- Added
`aria-modal` to `EuiFlyout` with
`type=\"overlay\"`\n([#8591](https://github.com/elastic/eui/pull/8591))\n\n**Dependency
updates**\n\n- Updated `@elastic/prismjs-esql` to
v1.1.0\n([#8587](https://github.com/elastic/eui/pull/8587))\n\n###
`@elastic/[email protected]`\n\n- Updated component tokens to use
`computed` values to ensure correct\ninheritance from theme
overrides\n([#8558](https://github.com/elastic/eui/pull/8558))\n- Added
`overrides.HCM` to `euiThemeBorealis` to support theme
internal\noverrides
([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated
`border.radius.medium` token value to
`4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n\n###
`@elastic/[email protected]`\n\n- Added support for theme
`overrides` as optional part of\n`EuiThemeShape`
([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated
`getComputed` to support high contrast mode overrides defined\non
`overrides.HCM`
([#8558](https://github.com/elastic/eui/pull/8558))\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"d2d27658f36040752ee7747bddb9d17030823352","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","backport:prev-minor","v9.1.0"],"title":"Upgrade
EUI to
v101.4.0","number":218778,"url":"https://github.com/elastic/kibana/pull/218778","mergeCommit":{"message":"Upgrade
EUI to v101.4.0 (#218778)\n\n`101.3.0` ⏩ `101.4.0`\n\n[Questions? Please
see our Kibana
upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n##
Changes\n\nThis PR only updates tests and snapshots related to changes
on EUI side:\n- updated `aria-current=\"true\"` to
`aria-current=\"page\"`\n- updated icon usage `userAvatar` to
`user`\n\n## Package updates\n\n### `@elastic/eui`\n\n####
[`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)\n\n-
Spread `labelProps` to the `label` element in
`EuiCheckableCard`\n([#8586](https://github.com/elastic/eui/pull/8586))\n-
Add `controls`, `flask`, `comment`, and `readOnly` glyphs to
`EuiIcon`\n([#8580](https://github.com/elastic/eui/pull/8580))\n-
Refactored `EuiExpression`, `EuiFacetGroup`,
`EuiFacetButton`,\n`EuiFilterGroup`, `EuiHeader`, `EuiImage` and
`EuiListGroup` to memoize\ntheir internal Emotion
styles\n([#8565](https://github.com/elastic/eui/pull/8565))\n- Updated
global `border.radius.medium` token value for default\n`Borealis` theme
to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n- Updated
`EuiProvider` to build themes including
`highContrastMode`\n([#8558](https://github.com/elastic/eui/pull/8558))\n\n**Accessibility**\n\n-
Removed the `aria-label` attribute from the `ul` element
in\n`EuiPagination` to avoid duplicate screen reader
output\n([#8597](https://github.com/elastic/eui/pull/8597))\n- Set a
more specific `aria-current=\"page\"` on list items in\n`EuiPagination`
([#8597](https://github.com/elastic/eui/pull/8597))\n- Added
`aria-modal` to `EuiFlyout` with
`type=\"overlay\"`\n([#8591](https://github.com/elastic/eui/pull/8591))\n\n**Dependency
updates**\n\n- Updated `@elastic/prismjs-esql` to
v1.1.0\n([#8587](https://github.com/elastic/eui/pull/8587))\n\n###
`@elastic/[email protected]`\n\n- Updated component tokens to use
`computed` values to ensure correct\ninheritance from theme
overrides\n([#8558](https://github.com/elastic/eui/pull/8558))\n- Added
`overrides.HCM` to `euiThemeBorealis` to support theme
internal\noverrides
([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated
`border.radius.medium` token value to
`4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n\n###
`@elastic/[email protected]`\n\n- Added support for theme
`overrides` as optional part of\n`EuiThemeShape`
([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated
`getComputed` to support high contrast mode overrides defined\non
`overrides.HCM`
([#8558](https://github.com/elastic/eui/pull/8558))\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"d2d27658f36040752ee7747bddb9d17030823352"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218778","number":218778,"mergeCommit":{"message":"Upgrade
EUI to v101.4.0 (#218778)\n\n`101.3.0` ⏩ `101.4.0`\n\n[Questions? Please
see our Kibana
upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n##
Changes\n\nThis PR only updates tests and snapshots related to changes
on EUI side:\n- updated `aria-current=\"true\"` to
`aria-current=\"page\"`\n- updated icon usage `userAvatar` to
`user`\n\n## Package updates\n\n### `@elastic/eui`\n\n####
[`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)\n\n-
Spread `labelProps` to the `label` element in
`EuiCheckableCard`\n([#8586](https://github.com/elastic/eui/pull/8586))\n-
Add `controls`, `flask`, `comment`, and `readOnly` glyphs to
`EuiIcon`\n([#8580](https://github.com/elastic/eui/pull/8580))\n-
Refactored `EuiExpression`, `EuiFacetGroup`,
`EuiFacetButton`,\n`EuiFilterGroup`, `EuiHeader`, `EuiImage` and
`EuiListGroup` to memoize\ntheir internal Emotion
styles\n([#8565](https://github.com/elastic/eui/pull/8565))\n- Updated
global `border.radius.medium` token value for default\n`Borealis` theme
to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n- Updated
`EuiProvider` to build themes including
`highContrastMode`\n([#8558](https://github.com/elastic/eui/pull/8558))\n\n**Accessibility**\n\n-
Removed the `aria-label` attribute from the `ul` element
in\n`EuiPagination` to avoid duplicate screen reader
output\n([#8597](https://github.com/elastic/eui/pull/8597))\n- Set a
more specific `aria-current=\"page\"` on list items in\n`EuiPagination`
([#8597](https://github.com/elastic/eui/pull/8597))\n- Added
`aria-modal` to `EuiFlyout` with
`type=\"overlay\"`\n([#8591](https://github.com/elastic/eui/pull/8591))\n\n**Dependency
updates**\n\n- Updated `@elastic/prismjs-esql` to
v1.1.0\n([#8587](https://github.com/elastic/eui/pull/8587))\n\n###
`@elastic/[email protected]`\n\n- Updated component tokens to use
`computed` values to ensure correct\ninheritance from theme
overrides\n([#8558](https://github.com/elastic/eui/pull/8558))\n- Added
`overrides.HCM` to `euiThemeBorealis` to support theme
internal\noverrides
([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated
`border.radius.medium` token value to
`4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n\n###
`@elastic/[email protected]`\n\n- Added support for theme
`overrides` as optional part of\n`EuiThemeShape`
([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated
`getComputed` to support high contrast mode overrides defined\non
`overrides.HCM`
([#8558](https://github.com/elastic/eui/pull/8558))\n\n---------\n\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"d2d27658f36040752ee7747bddb9d17030823352"}}]}]
BACKPORT-->
akowalska622 pushed a commit to akowalska622/kibana that referenced this pull request May 29, 2025
@mgadewoll @elasticmachine @akowalska622
Upgrade EUI to v101.4.0 (elastic#218778)
cbb283f 
`101.3.0` ⏩ `101.4.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

This PR only updates tests and snapshots related to changes on EUI side:
- updated `aria-current="true"` to `aria-current="page"`
- updated icon usage `userAvatar` to `user`

## Package updates

### `@elastic/eui`

#### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)

- Spread `labelProps` to the `label` element in `EuiCheckableCard`
([elastic#8586](elastic/eui#8586))
- Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon`
([elastic#8580](elastic/eui#8580))
- Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`,
`EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize
their internal Emotion styles
([elastic#8565](elastic/eui#8565))
- Updated global `border.radius.medium` token value for default
`Borealis` theme to `4px`
([elastic#8563](elastic/eui#8563))
- Updated `EuiProvider` to build themes including `highContrastMode`
([elastic#8558](elastic/eui#8558))

**Accessibility**

- Removed the `aria-label` attribute from the `ul` element in
`EuiPagination` to avoid duplicate screen reader output
([elastic#8597](elastic/eui#8597))
- Set a more specific `aria-current="page"` on list items in
`EuiPagination` ([elastic#8597](elastic/eui#8597))
- Added `aria-modal` to `EuiFlyout` with `type="overlay"`
([elastic#8591](elastic/eui#8591))

**Dependency updates**

- Updated `@elastic/prismjs-esql` to v1.1.0
([elastic#8587](elastic/eui#8587))

### `@elastic/[email protected]`

- Updated component tokens to use `computed` values to ensure correct
inheritance from theme overrides
([elastic#8558](elastic/eui#8558))
- Added `overrides.HCM` to `euiThemeBorealis` to support theme internal
overrides ([elastic#8558](elastic/eui#8558))
- Updated `border.radius.medium` token value to `4px`
([elastic#8563](elastic/eui#8563))

### `@elastic/[email protected]`

- Added support for theme `overrides` as optional part of
`EuiThemeShape` ([elastic#8558](elastic/eui#8558))
- Updated `getComputed` to support high contrast mode overrides defined
on `overrides.HCM` ([elastic#8558](elastic/eui#8558))

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@spalger spalger spalger approved these changes

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@spalger spalger

@thomasneirynck thomasneirynck

Labels

backported review v5.1.1 v6.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@marcelhallmann @elasticmachine @spalger @thomasneirynck @epixa @ppisljar @stacey-gammon @marcelhallmann53