[5.x] Ensure dashboard panels appear in the correct order #8591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[5.x] Ensure dashboard panels appear in the correct order Former-commit-id: 251dce6
mgadewoll
added a commit
that referenced
this pull request
Apr 24, 2025
`101.3.0` ⏩ `101.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR only updates tests and snapshots related to changes on EUI side: - updated `aria-current="true"` to `aria-current="page"` - updated icon usage `userAvatar` to `user` ## Package updates ### `@elastic/eui` #### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0) - Spread `labelProps` to the `label` element in `EuiCheckableCard` ([#8586](elastic/eui#8586)) - Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon` ([#8580](elastic/eui#8580)) - Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`, `EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize their internal Emotion styles ([#8565](elastic/eui#8565)) - Updated global `border.radius.medium` token value for default `Borealis` theme to `4px` ([#8563](elastic/eui#8563)) - Updated `EuiProvider` to build themes including `highContrastMode` ([#8558](elastic/eui#8558)) **Accessibility** - Removed the `aria-label` attribute from the `ul` element in `EuiPagination` to avoid duplicate screen reader output ([#8597](elastic/eui#8597)) - Set a more specific `aria-current="page"` on list items in `EuiPagination` ([#8597](elastic/eui#8597)) - Added `aria-modal` to `EuiFlyout` with `type="overlay"` ([#8591](elastic/eui#8591)) **Dependency updates** - Updated `@elastic/prismjs-esql` to v1.1.0 ([#8587](elastic/eui#8587)) ### `@elastic/[email protected]` - Updated component tokens to use `computed` values to ensure correct inheritance from theme overrides ([#8558](elastic/eui#8558)) - Added `overrides.HCM` to `euiThemeBorealis` to support theme internal overrides ([#8558](elastic/eui#8558)) - Updated `border.radius.medium` token value to `4px` ([#8563](elastic/eui#8563)) ### `@elastic/[email protected]` - Added support for theme `overrides` as optional part of `EuiThemeShape` ([#8558](elastic/eui#8558)) - Updated `getComputed` to support high contrast mode overrides defined on `overrides.HCM` ([#8558](elastic/eui#8558)) --------- Co-authored-by: Elastic Machine <[email protected]>
mgadewoll
added a commit
to mgadewoll/kibana
that referenced
this pull request
Apr 24, 2025
`101.3.0` ⏩ `101.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR only updates tests and snapshots related to changes on EUI side: - updated `aria-current="true"` to `aria-current="page"` - updated icon usage `userAvatar` to `user` ## Package updates ### `@elastic/eui` #### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0) - Spread `labelProps` to the `label` element in `EuiCheckableCard` ([elastic#8586](elastic/eui#8586)) - Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon` ([elastic#8580](elastic/eui#8580)) - Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`, `EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize their internal Emotion styles ([elastic#8565](elastic/eui#8565)) - Updated global `border.radius.medium` token value for default `Borealis` theme to `4px` ([elastic#8563](elastic/eui#8563)) - Updated `EuiProvider` to build themes including `highContrastMode` ([elastic#8558](elastic/eui#8558)) **Accessibility** - Removed the `aria-label` attribute from the `ul` element in `EuiPagination` to avoid duplicate screen reader output ([elastic#8597](elastic/eui#8597)) - Set a more specific `aria-current="page"` on list items in `EuiPagination` ([elastic#8597](elastic/eui#8597)) - Added `aria-modal` to `EuiFlyout` with `type="overlay"` ([elastic#8591](elastic/eui#8591)) **Dependency updates** - Updated `@elastic/prismjs-esql` to v1.1.0 ([elastic#8587](elastic/eui#8587)) ### `@elastic/[email protected]` - Updated component tokens to use `computed` values to ensure correct inheritance from theme overrides ([elastic#8558](elastic/eui#8558)) - Added `overrides.HCM` to `euiThemeBorealis` to support theme internal overrides ([elastic#8558](elastic/eui#8558)) - Updated `border.radius.medium` token value to `4px` ([elastic#8563](elastic/eui#8563)) ### `@elastic/[email protected]` - Added support for theme `overrides` as optional part of `EuiThemeShape` ([elastic#8558](elastic/eui#8558)) - Updated `getComputed` to support high contrast mode overrides defined on `overrides.HCM` ([elastic#8558](elastic/eui#8558)) --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit d2d2765) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/components/paginated_table/index.test.tsx # x-pack/solutions/security/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_dns_table/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_http_table/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_top_countries_table/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/network/components/network_top_n_flow_table/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/network/components/tls_table/__snapshots__/index.test.tsx.snap # x-pack/solutions/security/plugins/security_solution/public/explore/network/components/users_table/__snapshots__/index.test.tsx.snap
mgadewoll
added a commit
that referenced
this pull request
Apr 24, 2025
`101.3.0` ⏩ `101.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) >[!IMPORTANT] This PR is a direct sibling to this [upgrade PR](#218778) to `main`. The difference is that it adds a standalone EUI package with the previous "Amsterdam" theme. Apart from the theme difference, **there are no further changes added**. ## Changes This PR only updates tests and snapshots related to changes on EUI side: - updated `aria-current="true"` to `aria-current="page"` - updated icon usage `userAvatar` to `user` ## Package updates ### `@elastic/eui` #### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0) - Spread `labelProps` to the `label` element in `EuiCheckableCard` ([#8586](elastic/eui#8586)) - Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon` ([#8580](elastic/eui#8580)) - Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`, `EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize their internal Emotion styles ([#8565](elastic/eui#8565)) - Updated global `border.radius.medium` token value for default `Borealis` theme to `4px` ([#8563](elastic/eui#8563)) - Updated `EuiProvider` to build themes including `highContrastMode` ([#8558](elastic/eui#8558)) **Accessibility** - Removed the `aria-label` attribute from the `ul` element in `EuiPagination` to avoid duplicate screen reader output ([#8597](elastic/eui#8597)) - Set a more specific `aria-current="page"` on list items in `EuiPagination` ([#8597](elastic/eui#8597)) - Added `aria-modal` to `EuiFlyout` with `type="overlay"` ([#8591](elastic/eui#8591)) **Dependency updates** - Updated `@elastic/prismjs-esql` to v1.1.0 ([#8587](elastic/eui#8587)) ### `@elastic/[email protected]` - Updated component tokens to use `computed` values to ensure correct inheritance from theme overrides ([#8558](elastic/eui#8558)) - Added `overrides.HCM` to `euiThemeBorealis` to support theme internal overrides ([#8558](elastic/eui#8558)) - Updated `border.radius.medium` token value to `4px` ([#8563](elastic/eui#8563)) ### `@elastic/[email protected]` - Added support for theme `overrides` as optional part of `EuiThemeShape` ([#8558](elastic/eui#8558)) - Updated `getComputed` to support high contrast mode overrides defined on `overrides.HCM` ([#8558](elastic/eui#8558))
mgadewoll
added a commit
that referenced
this pull request
Apr 24, 2025
# Backport This will backport the following commits from `main` to `9.0`: - [Upgrade EUI to v101.4.0 (#218778)](#218778) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Lene Gadewoll","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-04-24T13:54:52Z","message":"Upgrade EUI to v101.4.0 (#218778)\n\n`101.3.0` ⏩ `101.4.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n## Changes\n\nThis PR only updates tests and snapshots related to changes on EUI side:\n- updated `aria-current=\"true\"` to `aria-current=\"page\"`\n- updated icon usage `userAvatar` to `user`\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)\n\n- Spread `labelProps` to the `label` element in `EuiCheckableCard`\n([#8586](https://github.com/elastic/eui/pull/8586))\n- Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon`\n([#8580](https://github.com/elastic/eui/pull/8580))\n- Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`,\n`EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize\ntheir internal Emotion styles\n([#8565](https://github.com/elastic/eui/pull/8565))\n- Updated global `border.radius.medium` token value for default\n`Borealis` theme to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n- Updated `EuiProvider` to build themes including `highContrastMode`\n([#8558](https://github.com/elastic/eui/pull/8558))\n\n**Accessibility**\n\n- Removed the `aria-label` attribute from the `ul` element in\n`EuiPagination` to avoid duplicate screen reader output\n([#8597](https://github.com/elastic/eui/pull/8597))\n- Set a more specific `aria-current=\"page\"` on list items in\n`EuiPagination` ([#8597](https://github.com/elastic/eui/pull/8597))\n- Added `aria-modal` to `EuiFlyout` with `type=\"overlay\"`\n([#8591](https://github.com/elastic/eui/pull/8591))\n\n**Dependency updates**\n\n- Updated `@elastic/prismjs-esql` to v1.1.0\n([#8587](https://github.com/elastic/eui/pull/8587))\n\n### `@elastic/[email protected]`\n\n- Updated component tokens to use `computed` values to ensure correct\ninheritance from theme overrides\n([#8558](https://github.com/elastic/eui/pull/8558))\n- Added `overrides.HCM` to `euiThemeBorealis` to support theme internal\noverrides ([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated `border.radius.medium` token value to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n\n### `@elastic/[email protected]`\n\n- Added support for theme `overrides` as optional part of\n`EuiThemeShape` ([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated `getComputed` to support high contrast mode overrides defined\non `overrides.HCM` ([#8558](https://github.com/elastic/eui/pull/8558))\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d2d27658f36040752ee7747bddb9d17030823352","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","backport:prev-minor","v9.1.0"],"title":"Upgrade EUI to v101.4.0","number":218778,"url":"https://github.com/elastic/kibana/pull/218778","mergeCommit":{"message":"Upgrade EUI to v101.4.0 (#218778)\n\n`101.3.0` ⏩ `101.4.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n## Changes\n\nThis PR only updates tests and snapshots related to changes on EUI side:\n- updated `aria-current=\"true\"` to `aria-current=\"page\"`\n- updated icon usage `userAvatar` to `user`\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)\n\n- Spread `labelProps` to the `label` element in `EuiCheckableCard`\n([#8586](https://github.com/elastic/eui/pull/8586))\n- Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon`\n([#8580](https://github.com/elastic/eui/pull/8580))\n- Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`,\n`EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize\ntheir internal Emotion styles\n([#8565](https://github.com/elastic/eui/pull/8565))\n- Updated global `border.radius.medium` token value for default\n`Borealis` theme to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n- Updated `EuiProvider` to build themes including `highContrastMode`\n([#8558](https://github.com/elastic/eui/pull/8558))\n\n**Accessibility**\n\n- Removed the `aria-label` attribute from the `ul` element in\n`EuiPagination` to avoid duplicate screen reader output\n([#8597](https://github.com/elastic/eui/pull/8597))\n- Set a more specific `aria-current=\"page\"` on list items in\n`EuiPagination` ([#8597](https://github.com/elastic/eui/pull/8597))\n- Added `aria-modal` to `EuiFlyout` with `type=\"overlay\"`\n([#8591](https://github.com/elastic/eui/pull/8591))\n\n**Dependency updates**\n\n- Updated `@elastic/prismjs-esql` to v1.1.0\n([#8587](https://github.com/elastic/eui/pull/8587))\n\n### `@elastic/[email protected]`\n\n- Updated component tokens to use `computed` values to ensure correct\ninheritance from theme overrides\n([#8558](https://github.com/elastic/eui/pull/8558))\n- Added `overrides.HCM` to `euiThemeBorealis` to support theme internal\noverrides ([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated `border.radius.medium` token value to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n\n### `@elastic/[email protected]`\n\n- Added support for theme `overrides` as optional part of\n`EuiThemeShape` ([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated `getComputed` to support high contrast mode overrides defined\non `overrides.HCM` ([#8558](https://github.com/elastic/eui/pull/8558))\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d2d27658f36040752ee7747bddb9d17030823352"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/218778","number":218778,"mergeCommit":{"message":"Upgrade EUI to v101.4.0 (#218778)\n\n`101.3.0` ⏩ `101.4.0`\n\n[Questions? Please see our Kibana upgrade\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)\n\n## Changes\n\nThis PR only updates tests and snapshots related to changes on EUI side:\n- updated `aria-current=\"true\"` to `aria-current=\"page\"`\n- updated icon usage `userAvatar` to `user`\n\n## Package updates\n\n### `@elastic/eui`\n\n#### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0)\n\n- Spread `labelProps` to the `label` element in `EuiCheckableCard`\n([#8586](https://github.com/elastic/eui/pull/8586))\n- Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon`\n([#8580](https://github.com/elastic/eui/pull/8580))\n- Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`,\n`EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize\ntheir internal Emotion styles\n([#8565](https://github.com/elastic/eui/pull/8565))\n- Updated global `border.radius.medium` token value for default\n`Borealis` theme to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n- Updated `EuiProvider` to build themes including `highContrastMode`\n([#8558](https://github.com/elastic/eui/pull/8558))\n\n**Accessibility**\n\n- Removed the `aria-label` attribute from the `ul` element in\n`EuiPagination` to avoid duplicate screen reader output\n([#8597](https://github.com/elastic/eui/pull/8597))\n- Set a more specific `aria-current=\"page\"` on list items in\n`EuiPagination` ([#8597](https://github.com/elastic/eui/pull/8597))\n- Added `aria-modal` to `EuiFlyout` with `type=\"overlay\"`\n([#8591](https://github.com/elastic/eui/pull/8591))\n\n**Dependency updates**\n\n- Updated `@elastic/prismjs-esql` to v1.1.0\n([#8587](https://github.com/elastic/eui/pull/8587))\n\n### `@elastic/[email protected]`\n\n- Updated component tokens to use `computed` values to ensure correct\ninheritance from theme overrides\n([#8558](https://github.com/elastic/eui/pull/8558))\n- Added `overrides.HCM` to `euiThemeBorealis` to support theme internal\noverrides ([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated `border.radius.medium` token value to `4px`\n([#8563](https://github.com/elastic/eui/pull/8563))\n\n### `@elastic/[email protected]`\n\n- Added support for theme `overrides` as optional part of\n`EuiThemeShape` ([#8558](https://github.com/elastic/eui/pull/8558))\n- Updated `getComputed` to support high contrast mode overrides defined\non `overrides.HCM` ([#8558](https://github.com/elastic/eui/pull/8558))\n\n---------\n\nCo-authored-by: Elastic Machine <[email protected]>","sha":"d2d27658f36040752ee7747bddb9d17030823352"}}]}] BACKPORT-->
akowalska622
pushed a commit
to akowalska622/kibana
that referenced
this pull request
May 29, 2025
`101.3.0` ⏩ `101.4.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR only updates tests and snapshots related to changes on EUI side: - updated `aria-current="true"` to `aria-current="page"` - updated icon usage `userAvatar` to `user` ## Package updates ### `@elastic/eui` #### [`v101.4.0`](https://github.com/elastic/eui/releases/v101.4.0) - Spread `labelProps` to the `label` element in `EuiCheckableCard` ([elastic#8586](elastic/eui#8586)) - Add `controls`, `flask`, `comment`, and `readOnly` glyphs to `EuiIcon` ([elastic#8580](elastic/eui#8580)) - Refactored `EuiExpression`, `EuiFacetGroup`, `EuiFacetButton`, `EuiFilterGroup`, `EuiHeader`, `EuiImage` and `EuiListGroup` to memoize their internal Emotion styles ([elastic#8565](elastic/eui#8565)) - Updated global `border.radius.medium` token value for default `Borealis` theme to `4px` ([elastic#8563](elastic/eui#8563)) - Updated `EuiProvider` to build themes including `highContrastMode` ([elastic#8558](elastic/eui#8558)) **Accessibility** - Removed the `aria-label` attribute from the `ul` element in `EuiPagination` to avoid duplicate screen reader output ([elastic#8597](elastic/eui#8597)) - Set a more specific `aria-current="page"` on list items in `EuiPagination` ([elastic#8597](elastic/eui#8597)) - Added `aria-modal` to `EuiFlyout` with `type="overlay"` ([elastic#8591](elastic/eui#8591)) **Dependency updates** - Updated `@elastic/prismjs-esql` to v1.1.0 ([elastic#8587](elastic/eui#8587)) ### `@elastic/[email protected]` - Updated component tokens to use `computed` values to ensure correct inheritance from theme overrides ([elastic#8558](elastic/eui#8558)) - Added `overrides.HCM` to `euiThemeBorealis` to support theme internal overrides ([elastic#8558](elastic/eui#8558)) - Updated `border.radius.medium` token value to `4px` ([elastic#8563](elastic/eui#8563)) ### `@elastic/[email protected]` - Added support for theme `overrides` as optional part of `EuiThemeShape` ([elastic#8558](elastic/eui#8558)) - Updated `getComputed` to support high contrast mode overrides defined on `overrides.HCM` ([elastic#8558](elastic/eui#8558)) --------- Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #8540