Remove unused vars

[thomasneirynck]

fix #8533. cleanup test code.

[kobelb]

If this parameter isn't being used anymore, the functional tests appear to be still providing it, should we consider removing it there?

https://github.com/elastic/kibana/blob/master/test/functional/apps/visualize/_line_chart.js#L65
https://github.com/elastic/kibana/blob/master/test/functional/apps/visualize/_line_chart.js#L95

[thomasneirynck]

@kobelb you're right. I removed those too. These were introduced at 89aff02.

became obsolete at some point, though can't quite pinpoint where.

[kobelb]

LGTM

[LeeDr]

I would rather not remove the parameter from that method signature. But instead add the usage of it like this;
change;
https://github.com/elastic/kibana/blob/master/test/support/page_objects/visualize_page.js#L532

from;
.findByCssSelector('circle[fill="#6eadc1"]')

to;
.findAllByCssSelector('circle[' + cssPart + ']')

And change any existing calls to getLineChartData to pass in 'fill="#6eadc1"'

The reason is that I have this modification in the private repo for integration testing where I make calls to get the line chart data for specific items using other attributes of the circles like this;

$ grep -r getLineChartData test/functional/*
test/functional/apps/metricbeat/_metricbeat.js:      return PageObjects.visualize.getLineChartData('data-label="CPU user space"');
test/functional/apps/packetbeat/_packetbeat.js:      return PageObjects.visualize.getLineChartData('data-label="Count"');
test/functional/apps/visualize/_line_chart.js:        return PageObjects.visualize.getLineChartData('fill="#57c17b"')

Right now this code isn't shared between the projects but it should be. I know it's not something we need in the existing Kibana tests as they stand right now. But the current line chart test is very simple with only a single line and this change allows us to test more complex charts. In fact other chart types should probably get a change like this too.

[thomasneirynck]

thanks @LeeDr. I reintroduced that change.

[LeeDr]

@thomasneirynck did you run the Selenium tests locally? I think you may have copy/pasted something wrong. There shouldn't be backticks here;

-            .findByCssSelector('circle[fill="#6eadc1"]')
+            .findByCssSelector(`circle[${cssPart}]`)

[thomasneirynck]

@LeeDr I used the ES6 template literal syntax for this (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals). It's shorthand to avoid the string concatenation.

[LeeDr]

@thomasneirynck Cool. I learned something new! I thought it was a copy of the markdown syntax I used to indicate that as code! But now I see how it works.