[kbnDevToolsApp] allow extending the top nav#8355
Merged
spalger merged 1 commit intoelastic:masterfrom Sep 21, 2016
Merged
Conversation
epixa
reviewed
Sep 20, 2016
epixa
reviewed
Sep 20, 2016
Contributor
There was a problem hiding this comment.
What's this about? You didn't end up using chrome anywhere.
Contributor
Author
There was a problem hiding this comment.
Good catch, I was originally exposing it on scope, but since I wasn't able to create a childscope for this directive, and I didn't want to leak it out, I ended up exposing the one necessary method via the KbnTopNavController
spalger
force-pushed
the
fix/devtools-header-stacking
branch
from
33f4bae to
4231b45
Compare
epixa
reviewed
Sep 20, 2016
Contributor
There was a problem hiding this comment.
ಠ_ಠ
I guess we can let this multiple-assignment-on-one-line slide since it's just copied and pasted from a few lines above...
Contributor
|
LGTM |
Contributor
|
@spalger This fails the selenium tests: https://kibana-ci.elastic.co/view/All/job/elastic+kibana+pull-request+multijob-selenium/279/ |
The kbn-dev-tools-app directive renders a navbar above each devtool, giving it breadcrumbs and links to the other devtools. This collides with the toolbars used in devtools like console and causes two mostly-empty toolbars to be stacked. To fix this, we are merging the navbar from kbn-dev-tools-app and the toolbar provided by the devtools into a single kbn-top-nav toolbar. Console already used the kbn-top-nav directive for it's navbar, so kbn-dev-tools-app just needed to be extended to consume and render the kbn-top-nav configuration (a controller in this instance).
spalger
force-pushed
the
fix/devtools-header-stacking
branch
from
4231b45 to
5bff9da
Compare
Contributor
Author
|
The tests actually passed, but it looks like the runner may have thrown a fit... I forced a change to cause the test to rerun |
Contributor
|
LGTM |
This was referenced Sep 21, 2016
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 30, 2016
[kbnDevToolsApp] allow extending the top nav The kbn-dev-tools-app directive renders a navbar above each devtool, giving it breadcrumbs and links to the other devtools. This collides with the toolbars used in devtools like console and causes two mostly-empty toolbars to be stacked. To fix this, we are merging the navbar from kbn-dev-tools-app and the toolbar provided by the devtools into a single kbn-top-nav toolbar. Console already used the kbn-top-nav directive for it's navbar, so kbn-dev-tools-app just needed to be extended to consume and render the kbn-top-nav configuration (a controller in this instance). (cherry picked from commit 5bff9da)
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 30, 2016
[kbnDevToolsApp] allow extending the top nav The kbn-dev-tools-app directive renders a navbar above each devtool, giving it breadcrumbs and links to the other devtools. This collides with the toolbars used in devtools like console and causes two mostly-empty toolbars to be stacked. To fix this, we are merging the navbar from kbn-dev-tools-app and the toolbar provided by the devtools into a single kbn-top-nav toolbar. Console already used the kbn-top-nav directive for it's navbar, so kbn-dev-tools-app just needed to be extended to consume and render the kbn-top-nav configuration (a controller in this instance). (cherry picked from commit 5bff9da)
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[kbnDevToolsApp] allow extending the top nav The kbn-dev-tools-app directive renders a navbar above each devtool, giving it breadcrumbs and links to the other devtools. This collides with the toolbars used in devtools like console and causes two mostly-empty toolbars to be stacked. To fix this, we are merging the navbar from kbn-dev-tools-app and the toolbar provided by the devtools into a single kbn-top-nav toolbar. Console already used the kbn-top-nav directive for it's navbar, so kbn-dev-tools-app just needed to be extended to consume and render the kbn-top-nav configuration (a controller in this instance). (cherry picked from commit b0b9026f06da214e23df8fc4b636fa9532f2fbcc [formerly 5bff9da]) Former-commit-id: 410f61f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8238
Closes #8234
The kbn-dev-tools-app directive renders a navbar above each devtool, giving it breadcrumbs and links to the other devtools. This collides with the toolbars used in devtools like console and causes two mostly-empty toolbars to be stacked.
To fix this, we are merging the navbar from kbn-dev-tools-app and the toolbar provided by the devtools into a single kbn-top-nav toolbar. Console already used the kbn-top-nav directive for it's navbar, so kbn-dev-tools-app just needed to be extended to consume and render the kbn-top-nav configuration (a controller in this instance).