Upgrade Node.js to version 14 by watson · Pull Request #83425 · elastic/kibana

watson · 2020-11-16T14:15:43Z

This upgrades the Node.js runtime to a new major version.

For a complete list of changes in the Node.js runtime, see the Node.js CHANGELOG. For only the breaking changes, see the list of notable changes for v13 and v14 respectively.

Closes #54039

What's new?

Node.js 14 brings with it a lot of new features and improvements. Among the most interesting are:

Native support for optional chaining and nullish coalescing (via the new V8 JavaScript engine). However, it seem that we need to upgrade to webpack v5 before it can be used natively without a Babel transform, which is also why I've not removed our existing Babel plugins in this PR.
Major overhaul of streams, which makes the stream API much more concise.
Support for EcmaScript Modules without the need to use the --experimental-modules flag.
Diagnostic Report now stable. The reports contains information that can be useful to help diagnose problems in production including crashes, slow performance, memory leaks, high CPU usage, unexpected errors and more.

Todo

Use released version of lmdb-store with fixes for @types/node v13+ included.
Use released version of @elastic/good with fixes for Node.js 14 included.
Use released version of @elastic/good with other fixes for Node.js 14 included.

Notes to reviewers

I had to enable the @babel/proposal-optional-chaining plugin in kbn-pm because webpack v4 doesn't like optional chaining in combination with TypeScript, so even though Node.js 14 supports it, we still need to babelify it. It looks like we'll need to do this until we upgrade to webpack v5.

Release note

Upgrades the major Node.js version used by and shipped with Kibana from v12 to v14.

Webpack 4 doesn't support optional chaining, so we need to force Babel to use plugin-proposal-optional-chaining even though Node.js 14 supports it. Once we upgrade to Webpack 5 this should no longer be needed.

patrykkopycinski

SIEM/Endpoint LGTM

spalger · 2020-12-01T17:37:47Z

packages/kbn-utils/src/streams/reduce_stream.test.ts

    reduce$.on('data', dataStub);
    reduce$.on('error', errorStub);
-    const endEvent = promiseFromEvent('end', reduce$);
+    const closeEvent = promiseFromEvent('close', reduce$);


I'm somewhat concerned about this change. Looks like transform.destroy() is what leads to the close event being emitted, but we don't call it... any idea what change in node 14 lead to this being necessary?

Good question. I must say I didn't go into too many details when debugging the test-failure, so I'm not sure my solution is correct. I'll take a closer look...

package.json

mshustov

reviewed the core code & tested locally. ❤️

packages/kbn-pm/.babelrc

jportner

One nit and a question below, LGTM!

src/dev/build/tasks/patch_native_modules_task.ts

jportner · 2020-12-02T18:41:11Z

src/plugins/kibana_utils/public/state_management/url/format.ts

  const url = parseUrl(rawUrl);
+  // @ts-expect-error `queryReplacer` expects key/value pairs with values of type `string | string[] | null`,
+  // however `@types/node` says that `url.query` has values of type `string | string[] | undefined`.
+  // After investigating this, it seems that no matter what the values will be of type `string | string[]`
  const newQuery = queryReplacer(url.query || {});


x-pack/test/functional/apps/dashboard/reporting/lib/compare_pngs.ts

kibanamachine · 2020-12-02T22:36:12Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 948d93b

Metrics [docs]

Distributable file count

id	before	after	diff
`default`	43339	43459	+120
`oss`	22645	22744	+99

History

💚 Build #91449 succeeded 70c7c44
💚 Build #90992 succeeded 4a4caf5
💔 Build #90958 failed 54c1b993a44f3b4fa0a8db1e665c68adba87a99a
💚 Build #90899 succeeded 4a4caf5
💚 Build #90851 succeeded 4ba229b873b5a3721ac32153eaf355a0a98876c4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (40 commits) fix: 🐛 don't add separator befor group on no main items (elastic#83166) [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323) [APM] Add APM agent config options (elastic#84678) Fixed a11y issue on rollup jobs table selection (elastic#84567) [Discover] Refactor getContextUrl to separate file (elastic#84503) [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654) [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749) [Lens] Migrate legacy es client and remove total hits as int (elastic#84340) Improve logging pipeline in @kbn/legacy-logging (elastic#84629) Catch @hapi/podium errors (elastic#84575) [Discover] Unskip date histogram test (elastic#84727) Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791) [Enterprise Search] Fix schema errors button (elastic#84842) [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589) [Maps] Always initialize routes on server-startup (elastic#84806) [Fleet] EPM support to handle uploaded file paths (elastic#84708) [Snapshot Restore] Fix initial policy form state (elastic#83928) Upgrade Node.js to version 14 (elastic#83425) [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992) [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006) ...

* master: (236 commits) fix: 🐛 don't add separator befor group on no main items (elastic#83166) [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323) [APM] Add APM agent config options (elastic#84678) Fixed a11y issue on rollup jobs table selection (elastic#84567) [Discover] Refactor getContextUrl to separate file (elastic#84503) [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654) [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749) [Lens] Migrate legacy es client and remove total hits as int (elastic#84340) Improve logging pipeline in @kbn/legacy-logging (elastic#84629) Catch @hapi/podium errors (elastic#84575) [Discover] Unskip date histogram test (elastic#84727) Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791) [Enterprise Search] Fix schema errors button (elastic#84842) [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589) [Maps] Always initialize routes on server-startup (elastic#84806) [Fleet] EPM support to handle uploaded file paths (elastic#84708) [Snapshot Restore] Fix initial policy form state (elastic#83928) Upgrade Node.js to version 14 (elastic#83425) [Security Solution] Keep Endpoint policies up to date with license changes (elastic#83992) [Security Solution][Exceptions] Implement exceptions for ML rules (elastic#84006) ...

…overy-action-group * upstream/master: (48 commits) [Lens] accessibility screen reader issues (elastic#84395) [Logs UI] Fetch single log entries via a search strategy (elastic#81710) fix: 🐛 don't add separator befor group on no main items (elastic#83166) [Security Solution][Detections] Implements indicator match rule cypress test (elastic#84323) [APM] Add APM agent config options (elastic#84678) Fixed a11y issue on rollup jobs table selection (elastic#84567) [Discover] Refactor getContextUrl to separate file (elastic#84503) [Embeddable] Export CSV action for Lens embeddables in dashboard (elastic#83654) [TSVB] [Cleanup] Remove extra dateFormat props (elastic#84749) [Lens] Migrate legacy es client and remove total hits as int (elastic#84340) Improve logging pipeline in @kbn/legacy-logging (elastic#84629) Catch @hapi/podium errors (elastic#84575) [Discover] Unskip date histogram test (elastic#84727) Rename server.xsrf.whitelist to server.xsrf.allowlist (elastic#84791) [Enterprise Search] Fix schema errors button (elastic#84842) [APM] Removes react-sticky dependency in favor of using CSS (elastic#84589) [Maps] Always initialize routes on server-startup (elastic#84806) [Fleet] EPM support to handle uploaded file paths (elastic#84708) [Snapshot Restore] Fix initial policy form state (elastic#83928) Upgrade Node.js to version 14 (elastic#83425) ...

watson self-assigned this Nov 16, 2020

watson added release_note:enhancement v7.11.0 v8.0.0 labels Nov 16, 2020

mshustov mentioned this pull request Nov 16, 2020

Upgrade to Node 14.x #83154

Closed

watson force-pushed the bump-node branch 4 times, most recently from 69f09e8 to f7b1a4a Compare November 23, 2020 14:37

watson force-pushed the bump-node branch from f7b1a4a to 4ba229b Compare November 30, 2020 19:18

watson added 10 commits November 30, 2020 23:30

Bump shelljs from v0.8.3 to v0.8.4

288708a

Bump lmdb-store for fixed TypeScript support

f4bbd8f

Bump Node.js version from 12.19.1 to 14.15.1

02b8e85

Bump @types/node version from 12.19.4 to 14.14.7

d0640f1

Fix TypeScript errors related to new @types/node version

f82898c

Fix building of kbn-pm

dde1039

Webpack 4 doesn't support optional chaining, so we need to force Babel to use plugin-proposal-optional-chaining even though Node.js 14 supports it. Once we upgrade to Webpack 5 this should no longer be needed.

[test] fix tests affected by changes to streams

fa0813a

[test] update snapshots to match Node.js 14

7864180

Bump @elastic/good to get fixes for Node.js 14

5c5561d

tmp: use dev-version of @elastic/good

4a4caf5

watson force-pushed the bump-node branch from 4ba229b to 4a4caf5 Compare November 30, 2020 22:33

watson marked this pull request as ready for review November 30, 2020 22:33

watson requested review from a team as code owners November 30, 2020 22:33

watson force-pushed the bump-node branch from 54c1b99 to 4a4caf5 Compare December 1, 2020 12:00

patrykkopycinski approved these changes Dec 1, 2020

View reviewed changes

spalger approved these changes Dec 1, 2020

View reviewed changes

watson added 2 commits December 2, 2020 18:14

Merge branch 'master' into bump-node

dfb20e8

Use released version of @elastic/good

70c7c44

mshustov approved these changes Dec 2, 2020

View reviewed changes

mshustov reviewed Dec 2, 2020

View reviewed changes

packages/kbn-pm/.babelrc Show resolved Hide resolved

jportner approved these changes Dec 2, 2020

View reviewed changes

streamich approved these changes Dec 2, 2020

View reviewed changes

watson added 2 commits December 2, 2020 21:53

Fix code-review nit

727c032

Merge branch 'master' into bump-node

948d93b

watson merged commit fb48e90 into elastic:master Dec 2, 2020

watson deleted the bump-node branch December 2, 2020 22:40

watson mentioned this pull request Dec 2, 2020

[7.x] Upgrade Node.js to version 14 (#83425) #84846

Merged

eyalkoren mentioned this pull request Dec 3, 2020

[APM] Add APM agent config options #84678

Merged

10 tasks

watson added a commit that referenced this pull request Dec 3, 2020

Upgrade Node.js to version 14 (#83425) (#84846)

fdb71b6

mistic mentioned this pull request Dec 3, 2020

chore(NA): upgrade node-sass into v4.14.1 to stop shipping old node-gyp #84935

Merged

watson added v7.12.0 v7.11.0 and removed v7.11.0 v7.12.0 labels Dec 9, 2020

Roguelazer mentioned this pull request Feb 25, 2021

kibana 7.11.0 drops support for glibc 2.12 #92901

Closed

legrego mentioned this pull request Mar 1, 2021

[7.11] Add note dropping support for glibc 2.12 #93067

Merged

lukeelmers mentioned this pull request Jun 25, 2021

[I18n] Integrate full-icu module #20288

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Node.js to version 14#83425

Upgrade Node.js to version 14#83425
watson merged 14 commits intoelastic:masterfrom
watson:bump-node

watson commented Nov 16, 2020 •

edited

Loading

Uh oh!

patrykkopycinski left a comment

Uh oh!

spalger Dec 1, 2020

Uh oh!

watson Dec 1, 2020

Uh oh!

Uh oh!

mshustov left a comment •

edited

Loading

Uh oh!

Uh oh!

jportner left a comment

Uh oh!

Uh oh!

jportner Dec 2, 2020

Uh oh!

Uh oh!

kibanamachine commented Dec 2, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

watson commented Nov 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's new?

Todo

Notes to reviewers

Release note

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

spalger Dec 1, 2020

Choose a reason for hiding this comment

Uh oh!

watson Dec 1, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mshustov left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jportner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jportner Dec 2, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Dec 2, 2020

💚 Build Succeeded

Metrics [docs]

Distributable file count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

watson commented Nov 16, 2020 •

edited

Loading

mshustov left a comment •

edited

Loading