Skip to content

Conversation

@cnasikas
Copy link
Member

Summary

This PR closes #79697

For maintainers

@cnasikas cnasikas added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 Team:Threat Hunting Security Solution Threat Hunting Team labels Oct 10, 2020
@cnasikas cnasikas requested review from a team as code owners October 10, 2020 09:19
@cnasikas cnasikas self-assigned this Oct 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@cnasikas cnasikas requested a review from XavierM October 10, 2020 09:19
@cnasikas
Copy link
Member Author

@elasticmachine merge upstream

Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in x-pack/plugins/case/common/api/connectors/index.ts, I will create this type

export const ConnectorPartialFieldsRt = rt.partial({
  ...JiraFieldsRT.props,
  ...ResilientFieldsRT.props,
  ...ServiceNowFieldsRT.props,
});

and then I will use it like that in x-pack/plugins/case/common/api/cases/case.ts

export const ServiceConnectorCaseParamsRt = rt.intersection([
  ServiceConnectorBasicCaseParamsRt,
  ConnectorPartialFieldsRt,
]);

@cnasikas
Copy link
Member Author

in x-pack/plugins/case/common/api/connectors/index.ts, I will create this type

export const ConnectorPartialFieldsRt = rt.partial({
  ...JiraFieldsRT.props,
  ...ResilientFieldsRT.props,
  ...ServiceNowFieldsRT.props,
});

and then I will use it like that in x-pack/plugins/case/common/api/cases/case.ts

export const ServiceConnectorCaseParamsRt = rt.intersection([
  ServiceConnectorBasicCaseParamsRt,
  ConnectorPartialFieldsRt,
]);

Thanks, it is much better this way.

@cnasikas cnasikas requested a review from XavierM October 12, 2020 21:00
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
securitySolution 593.2KB 594.6KB +1.4KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 16e1598 into elastic:master Oct 13, 2020
@cnasikas cnasikas deleted the fix_case_push_types branch October 13, 2020 13:12
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 13, 2020
…otphase-to-formlib

* 'master' of github.com:elastic/kibana: (59 commits)
  [Security Solution][Resolver] Replace copy-to-clipboard with native navigator.clipboard (elastic#80193)
  [Security Solution] Reduce initial bundle size (elastic#78992)
  [Security Solution][Resolver] Fix Resize node box-shadow bug (elastic#80223)
  Move observability content (elastic#79978)
  skip flaky suite (elastic#79389)
  removing kibana_datatable` in favor of `datatable` (elastic#75184)
  [ML] Fixes for anomaly swim lane  (elastic#80299)
  [Lens] Smokescreen lens test unskip (elastic#80190)
  Improved AlertsClient tests structure by splitting a huge alerts_client.tests.ts file into a specific files defined by its responsibility. (elastic#80088)
  [APM] React key warning when opening popover with external resources (elastic#80328)
  [Step 1] use Observables on server search API (elastic#79874)
  Apply back pressure in Task Manager whenever Elasticsearch responds with a 429 (elastic#75666)
  [Lens] Leverage original http request error (elastic#79831)
  [Security Solution][Case] Improve ServiceConnectorCaseParams type (elastic#80109)
  [SECURITY_SOLUTION] Fix query on alert histogram (elastic#80219)
  [DOCS] Update ingest node pipelines doc (elastic#79187)
  [Ingest Manager] Split up OpenAPI spec file  (elastic#80107)
  [SECURITY_SOLUTION][ENDPOINT] Fix label on Trusted App create name field (elastic#80001)
  [Ingest Manager] Fix agent policy bump revision to create only one POLICY_CHANGE action (elastic#80081)
  Grid layout fixes (elastic#80305)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared/data_tier_allocation_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/shared_imports.ts
cnasikas added a commit that referenced this pull request Oct 13, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM Team:Threat Hunting Security Solution Threat Hunting Team v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Security Solution][Case] Improve ServiceConnectorCaseParams type

5 participants