Skip to content

[Security Solution][Case] Improve ServiceConnectorCaseParams type #80109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2020
Merged

[Security Solution][Case] Improve ServiceConnectorCaseParams type #80109

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fab0ce6
Improve ServiceConnectorCaseParams type
cnasikas Oct 10, 2020
0af5932
Merge branch 'master' into fix_case_push_types
kibanamachine Oct 12, 2020
3023c25
Improve connectors fields type
cnasikas Oct 12, 2020
cc3fafe
Merge branch 'fix_case_push_types' of github.com:cnasikas/kibana into…
cnasikas Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions x-pack/plugins/case/common/api/cases/case.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { NumberFromString } from '../saved_object';
import { UserRT } from '../user';
import { CommentResponseRt } from './comment';
import { CasesStatusResponseRt } from './status';
import { CaseConnectorRt, ESCaseConnector } from '../connectors';
import { CaseConnectorRt, ESCaseConnector, ConnectorFieldsRt } from '../connectors';

// eslint-disable-next-line @kbn/eslint/no-restricted-paths
export { ActionTypeExecutorResult } from '../../../../actions/server/types';
Expand Down Expand Up @@ -133,7 +133,7 @@ export const ServiceConnectorCommentParamsRt = rt.type({
updatedBy: rt.union([ServiceConnectorUserParams, rt.null]),
});

export const ServiceConnectorCaseParamsRt = rt.type({
export const ServiceConnectorBasicCaseParamsRt = rt.type({
comments: rt.union([rt.array(ServiceConnectorCommentParamsRt), rt.null]),
createdAt: rt.string,
createdBy: ServiceConnectorUserParams,
Expand All @@ -145,6 +145,16 @@ export const ServiceConnectorCaseParamsRt = rt.type({
updatedBy: rt.union([ServiceConnectorUserParams, rt.null]),
});

export const ServiceConnectorCaseParamsWithFieldsRt = rt.intersection([
ServiceConnectorBasicCaseParamsRt,
ConnectorFieldsRt,
]);

export const ServiceConnectorCaseParamsRt = rt.union([
ServiceConnectorBasicCaseParamsRt,
ServiceConnectorCaseParamsWithFieldsRt,
]);

export const ServiceConnectorCaseResponseRt = rt.intersection([
rt.type({
title: rt.string,
Expand Down