Skip to content

[Alerts] fix failing executionStatus function test with null deref #79809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2020
Merged

[Alerts] fix failing executionStatus function test with null deref #79809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions x-pack/test/alerting_api_integration/spaces_only/tests/alerting/execution_status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ import { FtrProviderContext } from '../../../common/ftr_provider_context';
export default function executionStatusAlertTests({ getService }: FtrProviderContext) {
const supertest = getService('supertest');

// Failing: See https://github.com/elastic/kibana/issues/79248
describe.skip('executionStatus', () => {
describe('executionStatus', () => {
const objectRemover = new ObjectRemover(supertest);

after(async () => await objectRemover.removeAll());
Expand Down Expand Up @@ -257,14 +256,16 @@ export default function executionStatusAlertTests({ getService }: FtrProviderCon
`${getUrlPrefix(Spaces.space1.id)}/api/alerts/alert/${id}`
);
expect(response.status).to.eql(200);
const { status } = response.body.executionStatus;

const { executionStatus } = response.body || {};
const { status } = executionStatus || {};

const message = `waitForStatus(${Array.from(statuses)}): got ${JSON.stringify(
response.body.executionStatus
executionStatus
)}`;

if (statuses.has(status)) {
return response.body.executionStatus;
return executionStatus;
}

// eslint-disable-next-line no-console
Expand All @@ -288,13 +289,14 @@ export default function executionStatusAlertTests({ getService }: FtrProviderCon
const response = await supertest.get(`${getUrlPrefix(Spaces.space1.id)}/${findUri}`);

expect(response.status).to.eql(200);
const { executionStatus } = response.body.data.find((obj: any) => obj.id === id);
const { executionStatus } = response.body.data.find((obj: any) => obj.id === id) || {};
const { status } = executionStatus || {};

const message = `waitForFindStatus(${Array.from(statuses)}): got ${JSON.stringify(
executionStatus
)}`;

if (statuses.has(executionStatus.status)) {
if (statuses.has(status)) {
return executionStatus;
}

Expand All @@ -307,6 +309,7 @@ export default function executionStatusAlertTests({ getService }: FtrProviderCon
}

function expectErrorExecutionStatus(executionStatus: Record<string, any>, startDate: number) {
expect(executionStatus).to.be.ok();
expect(executionStatus.status).to.equal('error');

const statusDate = Date.parse(executionStatus.lastExecutionDate);
Expand Down