Upgrade to Node 6.4.0 by tylersmalley · Pull Request #7920 · elastic/kibana

tylersmalley · 2016-08-03T21:54:14Z

Updated dependencies to include graceful-fs ~4.0
Replaced deprecated grunt-s3 package with suggested grunt-aws-s3
Update licenses task to better support npm 3

cjcenizal · 2016-08-17T16:43:24Z

tasks/licenses.js

I think naming functions/methods as verbs makes code more readable because it follows the "verb noun" format of most sentences. Any reason to change this?

I agree, will update.

epixa · 2016-08-19T15:06:01Z

.nvmrc

What's this about? NVM doesn't have functionality to load version from other files.

It's a symbolic link to the .node-version file.

Ohhhh, gotcha. But symbolic links won't work in windows...

epixa · 2016-08-22T23:07:07Z

package.json

We should use whatever version of npm comes with the given version of node rather than the latest available. I think 3.10.3 is what ships with 6.4.0.

spalger · 2016-08-23T06:23:58Z

Nice, we should probably remove the deepModules related parts of the build task with the move to npm3.

tylersmalley · 2016-08-23T23:57:55Z

This error is present starting with Node 6.3.0. I am investigating the actual cause of the issue, which is proving to be rather difficult without a stack trace or a core dump being generated. As @epixa pointed out, if a security fix were to come out we would need this issue to be resolved in order to bump the version.

tylersmalley · 2016-08-24T00:24:47Z

I was able to obtain the error by setting up Karma outside of Grunt. I find this frustrating as I was running grunt with verbose and debug.

23 08 2016 17:18:18.372:ERROR [karma]: RangeError: out of range index
  at RangeError (native)
  at fastCopy (/Users/tyler/Code/tylersmalley/kibana/node_modules/ws/lib/Receiver.js:386:24)
  at Receiver.add (/Users/tyler/Code/tylersmalley/kibana/node_modules/ws/lib/Receiver.js:86:3)
  at Socket.realHandler (/Users/tyler/Code/tylersmalley/kibana/node_modules/ws/lib/WebSocket.js:800:20)
  at emitOne (events.js:96:13)
  at Socket.emit (events.js:188:7)
  at readableAddChunk (_stream_readable.js:177:18)
  at Socket.Readable.push (_stream_readable.js:135:10)
  at TCP.onread (net.js:542:20)

epixa · 2016-08-24T00:30:18Z

Down with grunt.

tylersmalley · 2016-08-24T00:35:22Z

I bumped Karma and have not been able to reproduce the error after 10 runs of the unit tests. Total number of tests are consistent with previous version.

tylersmalley · 2016-08-25T14:43:29Z

@epixa @spalger - tests are now passing after rebasing master.

tylersmalley · 2016-08-25T15:21:19Z

tasks/release.js

You can now define a bucket in .aws-config.json. For me, this made it much easier to test using my own S3 account.

Can we store .aws-config.json outside of the kibana directory (ie. home directory)? That's how the official aws sdk works, and it is awesome. Then we can have everyone add a kibana-staging bucket to their home directory and lean on that by default.

To be clear: I don't think we need to or even should make that change in this PR, I'm just keen in general on getting rid of semi-permanent dev artifacts from the working directory.

I like the idea of this, especially if we supported walking up the directory tree. I know that in some projects we use separate credentials and for those we could have an overwriting config.

Created #8092

* Updated dependencies to include graceful-fs ~4.0 * Replaced deprecated grunt-s3 package with suggested grunt-aws-s3 * Update licenses task to better support npm 3 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

spalger · 2016-08-25T20:16:50Z

LGTM

spalger · 2016-08-25T20:37:36Z

🎉 🎉 🎉

[backport] PR #7920,#8313 to 4.6 - Upgrade to Node 6.4.0

Upgrade to Node 6.4.0 Former-commit-id: 20b96b8

…ul Links' in Risk Score Enablement page (elastic#171089) ## Summary Get rid of `Host/User` distinction in risk scoring and replace it with `Entity`, as per: [elastic#7920](elastic/security-team#7920) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3ec310b)

…ul Links' in Risk Score Enablement page (elastic#171089) ## Summary Get rid of `Host/User` distinction in risk scoring and replace it with `Entity`, as per: [elastic#7920](elastic/security-team#7920) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…ul Links' in Risk Score Enablement page (elastic#171089) ## Summary Get rid of `Host/User` distinction in risk scoring and replace it with `Entity`, as per: [elastic#7920](elastic/security-team#7920) ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 3ec310b)

…r 'Useful Links' in Risk Score Enablement page (#171089) (#171838) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] [Entity Analytics] Correct References under 'Useful Links' in Risk Score Enablement page (#171089)](#171089)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…r 'Useful Links' in Risk Score Enablement page (#171089) (#171835) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] [Entity Analytics] Correct References under 'Useful Links' in Risk Score Enablement page (#171089)](#171089)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Tiago Vila Verde <tiago.vilaverde@elastic.co>

tylersmalley added review v5.0.0-beta1 labels Aug 3, 2016

tylersmalley force-pushed the 7772-node6.3 branch 3 times, most recently from 51df4e1 to f4c6361 Compare August 4, 2016 00:34

tylersmalley removed the review label Aug 4, 2016

tylersmalley force-pushed the 7772-node6.3 branch 2 times, most recently from c5fed25 to 5a2e9ed Compare August 4, 2016 02:12

tylersmalley force-pushed the 7772-node6.3 branch 4 times, most recently from a0d98e3 to c7ead83 Compare August 17, 2016 14:23

tylersmalley added the review label Aug 17, 2016

tylersmalley changed the title ~~Upgrade to Node 6.3.1~~ Upgrade to Node 6.4.0 Aug 17, 2016

tylersmalley force-pushed the 7772-node6.3 branch from 9a5aa53 to 81ed06e Compare August 17, 2016 15:30

cjcenizal reviewed Aug 17, 2016
View reviewed changes

tylersmalley force-pushed the 7772-node6.3 branch from 81ed06e to 7111351 Compare August 18, 2016 18:35

epixa reviewed Aug 19, 2016
View reviewed changes

tylersmalley force-pushed the 7772-node6.3 branch 8 times, most recently from 74db069 to ee1e88b Compare August 22, 2016 20:03

epixa reviewed Aug 22, 2016
View reviewed changes

tylersmalley force-pushed the 7772-node6.3 branch from ee1e88b to 5ed8bcc Compare August 22, 2016 23:17

tylersmalley mentioned this pull request Aug 23, 2016

[backport] PR #7920 to 4.x - Upgrade to Node 6.4.0 #8052

Closed

tylersmalley force-pushed the 7772-node6.3 branch from af52b3f to 7a179be Compare August 24, 2016 21:17

spalger self-assigned this Aug 24, 2016

tylersmalley force-pushed the 7772-node6.3 branch from 7a179be to 4920855 Compare August 25, 2016 14:30

tylersmalley reviewed Aug 25, 2016
View reviewed changes

Upgrade to Node 6.4.0

ad97552

* Updated dependencies to include graceful-fs ~4.0 * Replaced deprecated grunt-s3 package with suggested grunt-aws-s3 * Update licenses task to better support npm 3 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley force-pushed the 7772-node6.3 branch from 4920855 to ad97552 Compare August 25, 2016 15:40

spalger mentioned this pull request Aug 25, 2016

Move aws-config.json out of the repo #8092

Closed

tylersmalley merged commit 20b96b8 into elastic:master Aug 25, 2016

tylersmalley mentioned this pull request Sep 10, 2016

[backport] PR #7920,#8313 to 4.6 - Upgrade to Node 6.4.0 #8213

Merged

tylersmalley added a commit that referenced this pull request Oct 11, 2016

Merge pull request #8213 from tylersmalley/4.6-node6

332abe8

[backport] PR #7920,#8313 to 4.6 - Upgrade to Node 6.4.0

epixa added the v4.6.3 label Oct 25, 2016

epixa mentioned this pull request Oct 25, 2016

panic: double free or corruption (in node) #8825

Closed

epixa added v4.7.0 and removed v4.6.3 labels Nov 16, 2016

epixa added the v4.6.4 label Dec 20, 2016

airow pushed a commit to airow/kibana that referenced this pull request Feb 16, 2017

Merge pull request elastic#7920 from tylersmalley/7772-node6.3

963a048

Upgrade to Node 6.4.0 Former-commit-id: 20b96b8

Conversation

tylersmalley commented Aug 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalger commented Aug 23, 2016

Uh oh!

tylersmalley commented Aug 23, 2016

Uh oh!

tylersmalley commented Aug 24, 2016

Uh oh!

epixa commented Aug 24, 2016

Uh oh!

tylersmalley commented Aug 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tylersmalley commented Aug 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalger commented Aug 25, 2016

Uh oh!

spalger commented Aug 25, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tylersmalley commented Aug 3, 2016 •

edited

Loading

tylersmalley commented Aug 24, 2016 •

edited

Loading

tylersmalley commented Aug 25, 2016 •

edited

Loading