Merged
Conversation
tylersmalley
commented
Sep 16, 2016
Member
Author
There was a problem hiding this comment.
We can not pass option.statusCode in the request, as Joi was throwing an error.
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Node deprecation: nodejs/node@8e8959d Iron's resolution: hapijs/iron@9e0a1ef As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
force-pushed
the
hapi-upgrade
branch
from
3e48db1 to
4feeff1
Compare
tylersmalley
changed the title
Contributor
|
Is there a reason we don't go all the way to version 15? |
Member
Author
|
A lot more broke when going to 15.0 and after working towards a solution I felt it would be better to make an incremental change which solved the issue then take another pass at it |
|
@tylersmalley I assume you would also like to update joi, boom, wreck as a separate PR as well then? |
Member
Author
|
@AdriVanHoudt, not at this time. Is there a reason your looking to get those dependencies bumped? |
|
@tylersmalley Boom and Wreck not really (apart from upgrading the whole hapi bunch at once) but Joi is recommended in the hapi 14 release notes, see hapijs/hapi#3272 |
Contributor
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Sep 26, 2016
--------- **Commit 1:** Upgrades Hapi to 14.2.0 As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Node deprecation: nodejs/node@8e8959d Iron's resolution: hapijs/iron@9e0a1ef As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 4feeff1 * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-09-13T19:20:22Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 26, 2016
--------- **Commit 1:** Upgrades Hapi to 14.2.0 As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Node deprecation: nodejs/node@8e8959d Iron's resolution: hapijs/iron@9e0a1ef As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 4feeff1 * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-09-13T19:20:22Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 26, 2016
--------- **Commit 1:** Upgrades Hapi to 14.2.0 As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Node deprecation: nodejs/node@8e8959d Iron's resolution: hapijs/iron@9e0a1ef As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: 4feeff1 * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-09-13T19:20:22Z
This was referenced Sep 26, 2016
epixa
added a commit
that referenced
this pull request
Sep 28, 2016
[backport] PR #8313 to 5.x - Upgrades Hapi to 14.2.0
epixa
added a commit
that referenced
this pull request
Sep 28, 2016
[backport] PR #8313 to 5.0 - Upgrades Hapi to 14.2.0
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** Upgrades Hapi to 14.2.0 As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0. Node deprecation: nodejs/node@8e8959d Iron's resolution: hapijs/iron@9e0a1ef As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682 Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> * Original sha: b7e158d8ce37c2e2fd34bf19b98287500ce324aa [formerly 4feeff1] * Authored by Tyler Smalley <tyler.smalley@elastic.co> on 2016-09-13T19:20:22Z Former-commit-id: 853c62e
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8313 to 5.x - Upgrades Hapi to 14.2.0 Former-commit-id: f4dd1c1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of Node 6, crypto.pbkdf emits a deprecation warning when the digest isn't explicily set. Under certain conditions we are seeing this warning from Hapi's dependency Iron. Iron resolved this issue as of 4.0.4, which was introduced into Hapi as of 14.0.0.
Node deprecation: nodejs/node@8e8959d
Iron's resolution: hapijs/iron@9e0a1ef
As of Hapi v9, they have removed three build-in plugins from the core which we rely on inert (files and directories), vision (view templates), and h2o2 (proxy). hapijs/hapi#2682