Skip to content

Comments

[Security Solution] [Entity Analytics] Correct References under 'Useful Links' in Risk Score Enablement page #171089

Merged
tiansivive merged 17 commits intoelastic:mainfrom
tiansivive:siem-ea-7920
Nov 23, 2023
Merged

[Security Solution] [Entity Analytics] Correct References under 'Useful Links' in Risk Score Enablement page #171089
tiansivive merged 17 commits intoelastic:mainfrom
tiansivive:siem-ea-7920

Conversation

@tiansivive
Copy link
Contributor

@tiansivive tiansivive commented Nov 13, 2023 •
edited by kibanamachine
Loading

Summary

Get rid of Host/User distinction in risk scoring and replace it with Entity, as per:
#7920

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@tiansivive tiansivive added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 Team:Entity Analytics Security Entity Analytics Team v8.11.2 labels Nov 13, 2023
jaredburgettelastic
jaredburgettelastic reviewed Nov 13, 2023
View reviewed changes
...k/plugins/security_solution/public/entity_analytics/components/risk_score_enable_section.tsx Outdated
Copy link
Contributor

@jaredburgettelastic jaredburgettelastic Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @SourinPaul , based on this comment, I believe this link should actually take you to the in-product Entity Analytics Dashboard page instead of the docs page.

Copy link

@SourinPaul SourinPaul Nov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your understanding is correct, @jaredburgettelastic

Copy link
Contributor Author

@tiansivive tiansivive Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

jaredburgettelastic
jaredburgettelastic reviewed Nov 13, 2023
View reviewed changes
x-pack/plugins/security_solution/public/explore/components/risk_score/translations.ts Outdated
Copy link
Contributor

@jaredburgettelastic jaredburgettelastic Nov 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: So that we don't lose the nice variable name riskEntity in this code for cleanliness, you can immediately invoke without the parameter. (Don't commit this suggestion directly in GitHub, as GitHub isn't smart enough to allow for multi-line suggestions if any lines of code were deleted 😭 )

Suggested change
const text = ((e) => {
const text = (() => {
if (!riskEntity && plural) return ENTITIES;
if (!riskEntity) return ENTITY;
if (riskEntity === RiskScoreEntity.host && plural) return HOSTS;
if (riskEntity === RiskScoreEntity.host) return HOST;
if (riskEntity === RiskScoreEntity.user && plural) return USERS;
if (riskEntity === RiskScoreEntity.user) return USER;
return '';
})();

Copy link
Contributor Author

@tiansivive tiansivive Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 16, 2023

@elasticmachine merge upstream

@tiansivive tiansivive marked this pull request as ready for review November 17, 2023 10:04
@tiansivive tiansivive requested review from a team as code owners November 17, 2023 10:04
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 17, 2023

Pinging @elastic/security-solution (Team: SecuritySolution)

@semd
Copy link
Contributor

semd commented Nov 17, 2023

Hi @tiansivive, congratulations on your first PR! 🎉
A couple of small suggestions:

  • Make sure the PR has at least a summary before asking for a review. Adding some screenshots of the "before" and "after" is really helpful.
  • It would be nice to see your name somewhere in your GH profile, so coworkers can find you in Slack.

Thanks!

@tiansivive @semd
Update x-pack/plugins/security_solution/public/entity_analytics/compo…
fcb4b8b 
…nents/risk_score_enable_section.tsx


Suggested review

Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 21, 2023

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 21, 2023

expected head sha didn’t match current head ref.

@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 21, 2023

@elasticmachine merge upstream

semd
semd reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some NITs

semd
semd reviewed Nov 21, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks clean now, thanks for addressing the comments. Nothing else to say about that.

However, I've been desk testing this and I don't see the expected state described in the issue:

Useful links

Entity Analytics Dashboard
How is the risk score calculated?

What I see is this:

screenshot

I don't know if I missed some specification changes. But anyway, I think this behavior should be reviewed by the @elastic/security-entity-analytics team itself.

@tiansivive @semd
Update x-pack/plugins/security_solution/public/entity_analytics/compo…
160cb05 
…nents/risk_score_enable_section.tsx

Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 21, 2023

It should open the flyout, that was the intended change of this PR

nkhristinin
nkhristinin approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@nkhristinin nkhristinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, thanks!

Han we also in this PR fix this small issue? In the flyout we say 6 risk levels, but we only have 5
Screenshot 2023-11-21 at 16 43 21

semd
semd approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 22, 2023

@elasticmachine merge upstream

@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 22, 2023 •
edited
Loading

@elasticmachine merge upstream

@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 22, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Nov 22, 2023 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +550.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 65.3KB 65.4KB +28.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tiansivive tiansivive merged commit 3ec310b into elastic:main Nov 23, 2023
@kibanamachine kibanamachine mentioned this pull request Nov 23, 2023
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 23, 2023
@tiansivive @semd @kibanamachine
[Security Solution] [Entity Analytics] Correct References under 'Usef…
fce2dd1 
…ul Links' in Risk Score Enablement page (elastic#171089)

## Summary

Get rid of `Host/User` distinction in risk scoring and replace it with
`Entity`, as per:
[elastic#7920](elastic/security-team#7920)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3ec310b)
@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 23, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@tiansivive tiansivive mentioned this pull request Nov 23, 2023
Merged
@tiansivive
Copy link
Contributor Author

tiansivive commented Nov 23, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

tiansivive added a commit to tiansivive/kibana that referenced this pull request Nov 23, 2023
@tiansivive @semd @kibanamachine
[Security Solution] [Entity Analytics] Correct References under 'Usef…
47242cd 
…ul Links' in Risk Score Enablement page (elastic#171089)

## Summary

Get rid of `Host/User` distinction in risk scoring and replace it with
`Entity`, as per:
[elastic#7920](elastic/security-team#7920)

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Sergi Massaneda <sergi.massaneda@gmail.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3ec310b)
tiansivive added a commit that referenced this pull request Nov 30, 2023
@tiansivive @kibanamachine
[8.11] [Security Solution] [Entity Analytics] Correct References unde…
1de9b5b 
…r 'Useful Links' in Risk Score Enablement page (#171089) (#171838)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] [Entity Analytics] Correct References under
'Useful Links' in Risk Score Enablement page
(#171089)](#171089)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago Vila
Verde","email":"tiago.vilaverde@elastic.co"},"sourceCommit":{"committedDate":"2023-11-23T10:20:23Z","message":"[Security
Solution] [Entity Analytics] Correct References under 'Useful Links' in
Risk Score Enablement page (#171089)\n\n## Summary\r\n\r\nGet rid of
`Host/User` distinction in risk scoring and replace it with\r\n`Entity`,
as
per:\r\n[#7920](https://github.com/elastic/security-team/issues/7920)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Sergi Massaneda <sergi.massaneda@gmail.com>\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3ec310b5192f4bac9b325d3160549800e302fe3e","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:
SecuritySolution","v8.12.0","Team:Entity
Analytics","v8.11.2"],"number":171089,"url":"https://github.com/elastic/kibana/pull/171089","mergeCommit":{"message":"[Security
Solution] [Entity Analytics] Correct References under 'Useful Links' in
Risk Score Enablement page (#171089)\n\n## Summary\r\n\r\nGet rid of
`Host/User` distinction in risk scoring and replace it with\r\n`Entity`,
as
per:\r\n[#7920](https://github.com/elastic/security-team/issues/7920)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Sergi Massaneda <sergi.massaneda@gmail.com>\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3ec310b5192f4bac9b325d3160549800e302fe3e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171089","number":171089,"mergeCommit":{"message":"[Security
Solution] [Entity Analytics] Correct References under 'Useful Links' in
Risk Score Enablement page (#171089)\n\n## Summary\r\n\r\nGet rid of
`Host/User` distinction in risk scoring and replace it with\r\n`Entity`,
as
per:\r\n[#7920](https://github.com/elastic/security-team/issues/7920)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Sergi Massaneda <sergi.massaneda@gmail.com>\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3ec310b5192f4bac9b325d3160549800e302fe3e"}},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/171835","number":171835,"state":"OPEN"}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Nov 30, 2023
@kibanamachine @tiansivive
[8.11] [Security Solution] [Entity Analytics] Correct References unde…
3c9b73e 
…r 'Useful Links' in Risk Score Enablement page (#171089) (#171835)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] [Entity Analytics] Correct References under
'Useful Links' in Risk Score Enablement page
(#171089)](#171089)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Tiago Vila
Verde","email":"tiago.vilaverde@elastic.co"},"sourceCommit":{"committedDate":"2023-11-23T10:20:23Z","message":"[Security
Solution] [Entity Analytics] Correct References under 'Useful Links' in
Risk Score Enablement page (#171089)\n\n## Summary\r\n\r\nGet rid of
`Host/User` distinction in risk scoring and replace it with\r\n`Entity`,
as
per:\r\n[#7920](https://github.com/elastic/security-team/issues/7920)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Sergi Massaneda <sergi.massaneda@gmail.com>\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3ec310b5192f4bac9b325d3160549800e302fe3e","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:
SecuritySolution","v8.12.0","Team:Entity
Analytics","v8.11.2"],"number":171089,"url":"https://github.com/elastic/kibana/pull/171089","mergeCommit":{"message":"[Security
Solution] [Entity Analytics] Correct References under 'Useful Links' in
Risk Score Enablement page (#171089)\n\n## Summary\r\n\r\nGet rid of
`Host/User` distinction in risk scoring and replace it with\r\n`Entity`,
as
per:\r\n[#7920](https://github.com/elastic/security-team/issues/7920)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Sergi Massaneda <sergi.massaneda@gmail.com>\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3ec310b5192f4bac9b325d3160549800e302fe3e"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/171089","number":171089,"mergeCommit":{"message":"[Security
Solution] [Entity Analytics] Correct References under 'Useful Links' in
Risk Score Enablement page (#171089)\n\n## Summary\r\n\r\nGet rid of
`Host/User` distinction in risk scoring and replace it with\r\n`Entity`,
as
per:\r\n[#7920](https://github.com/elastic/security-team/issues/7920)\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n- [x] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [x] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [x] Any UI
touched in this PR is usable by keyboard only (learn more\r\nabout
[keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n-
[x] Any UI touched in this PR does not create any new axe
failures\r\n(run axe in
browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n-
[x] If a plugin configuration key changed, check if it needs to
be\r\nallowlisted in the cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[x] This renders correctly on smaller devices using a
responsive\r\nlayout. (You can test this [in
your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n-
[x] This was checked for
[cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n\r\n###
For maintainers\r\n\r\n- [x] This was checked for breaking API changes
and was
[labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Sergi Massaneda <sergi.massaneda@gmail.com>\r\nCo-authored-by: Kibana
Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3ec310b5192f4bac9b325d3160549800e302fe3e"}},{"branch":"8.11","label":"v8.11.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Tiago Vila Verde <tiago.vilaverde@elastic.co>
@nastasha-solomon nastasha-solomon mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredburgettelastic jaredburgettelastic jaredburgettelastic left review comments

@nkhristinin nkhristinin nkhristinin approved these changes

@semd semd semd approved these changes

+1 more reviewer

@SourinPaul SourinPaul SourinPaul left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:enhancement Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.2 v8.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tiansivive @elasticmachine @semd @kibanamachine @kibana-ci @nkhristinin @SourinPaul @jaredburgettelastic