Skip to content

[Maps] lazy load maps_legacy, tile_map, and region_map bundle #78027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 24, 2020
Merged

[Maps] lazy load maps_legacy, tile_map, and region_map bundle #78027

merged 11 commits into from
Sep 24, 2020

Conversation

@nreese
Copy link
Contributor

@nreese nreese commented Sep 21, 2020 •
edited
Loading

Part of #78022

This PR creates a lazy load bundle for maps_legacy, region_map, and tile_map to reduce plugin size.

@nreese nreese added chore WIP Work in progress Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 21, 2020
@nreese nreese requested a review from a team September 21, 2020 15:30
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 21, 2020

Pinging @elastic/kibana-gis (Team:Geo)

@nreese nreese changed the title [Maps] lazy load maps_legacy bundle [Maps] lazy load maps_legacy, tile_map, and region_map bundle Sep 22, 2020
@nreese nreese added review and removed WIP Work in progress labels Sep 23, 2020
@nreese
Copy link
Contributor Author

nreese commented Sep 23, 2020

@elasticmachine merge upstream

@thomasneirynck thomasneirynck self-requested a review September 23, 2020 14:35
thomasneirynck
thomasneirynck reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, tested.

really impressive improvement 🧨

Just one suggestion. Don't feel strongly, but might improve readability and help users distinguish between "modules" and instance-vars.

@nreese
Copy link
Contributor Author

nreese commented Sep 23, 2020

Just one suggestion. Don't feel strongly, but might improve readability and help users distinguish between "modules" and instance-vars.

I have remove _leaflet and _serviceSettings from BaseMapsVisualization

@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 23, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
mapsLegacy 144 +4 140

async chunks size

id value diff baseline
mapsLegacy 865.3KB ⚠️ +865.3KB 0.0B
regionMap 407.7KB ⚠️ +407.7KB 0.0B
tileMap 273.6KB ⚠️ +273.6KB 0.0B
visTypeVega 1.4MB +515.0B 1.4MB
total ⚠️ +1.5MB

page load bundle size

id value diff baseline
mapsLegacy 96.4KB -861.4KB 957.9KB
mapsLegacyLicensing 5.1KB +966.0B 4.1KB
regionMap 44.9KB -400.8KB 445.6KB
tileMap 187.6KB -269.6KB 457.2KB
visTypeVega 277.1KB -403.0B 277.5KB
total -1.5MB

distributable file count

id value diff baseline
default 45962 +21 45941
oss 26672 +21 26651
total +42

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@nreese nreese merged commit c9e0c71 into elastic:master Sep 24, 2020
This was referenced Sep 24, 2020
Closed
Merged
nreese added a commit to nreese/kibana that referenced this pull request Sep 24, 2020
@nreese @elasticmachine
[Maps] lazy load maps_legacy, tile_map, and region_map bundle (elasti…
8a88cbc 
…c#78027)

* [Maps] lazy load maps_legacy bundle

* tslint

* lazy load leaflet

* try to get lodash out of maps_legacy bundle and work on tile_map bundle

* lazy load service settings

* lazy load region_map and fix vega unit tests

* tslint fixes

* remove lodash from region_map bundle

* review feedback

* remove unused file

Co-authored-by: Elastic Machine <[email protected]>
nreese added a commit that referenced this pull request Sep 24, 2020
@nreese @elasticmachine
[Maps] lazy load maps_legacy, tile_map, and region_map bundle (#78027) (
c15bb39 
#78480)

* [Maps] lazy load maps_legacy bundle

* tslint

* lazy load leaflet

* try to get lodash out of maps_legacy bundle and work on tile_map bundle

* lazy load service settings

* lazy load region_map and fix vega unit tests

* tslint fixes

* remove lodash from region_map bundle

* review feedback

* remove unused file

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
This was referenced Nov 4, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore release_note:skip Skip the PR/issue when compiling release notes review Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nreese @elasticmachine @kibanamachine @thomasneirynck