-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Maps] lazy load maps_legacy, tile_map, and region_map bundle #78027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fcbc121
[Maps] lazy load maps_legacy bundle
nreese 4d54eda
tslint
nreese 2fddf56
lazy load leaflet
nreese a551769
try to get lodash out of maps_legacy bundle and work on tile_map bundle
nreese 88f92fc
lazy load service settings
nreese 9933bdc
lazy load region_map and fix vega unit tests
nreese d47b0cd
tslint fixes
nreese 37c444a
remove lodash from region_map bundle
nreese 3745a80
Merge branch 'master' into maps_legacy_lazy_load
elasticmachine a56234c
review feedback
nreese 4656e0e
remove unused file
nreese File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| import { lazyLoadMapsLegacyModules } from './lazy_load_bundle'; | ||
| // @ts-expect-error | ||
| import { getMapsLegacyConfig } from './kibana_services'; | ||
| import { IServiceSettings } from './map/service_settings_types'; | ||
|
|
||
| let loadPromise: Promise<IServiceSettings>; | ||
|
|
||
| export async function getServiceSettings(): Promise<IServiceSettings> { | ||
| if (typeof loadPromise !== 'undefined') { | ||
| return loadPromise; | ||
| } | ||
|
|
||
| loadPromise = new Promise(async (resolve) => { | ||
| const modules = await lazyLoadMapsLegacyModules(); | ||
| const config = getMapsLegacyConfig(); | ||
| // @ts-expect-error | ||
| resolve(new modules.ServiceSettings(config, config.tilemap)); | ||
| }); | ||
| return loadPromise; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| let loadModulesPromise: Promise<LazyLoadedMapsLegacyModules>; | ||
|
|
||
| interface LazyLoadedMapsLegacyModules { | ||
| KibanaMap: unknown; | ||
| L: unknown; | ||
| ServiceSettings: unknown; | ||
| } | ||
|
|
||
| export async function lazyLoadMapsLegacyModules(): Promise<LazyLoadedMapsLegacyModules> { | ||
| if (typeof loadModulesPromise !== 'undefined') { | ||
| return loadModulesPromise; | ||
| } | ||
|
|
||
| loadModulesPromise = new Promise(async (resolve) => { | ||
| const { KibanaMap, L, ServiceSettings } = await import('./lazy'); | ||
|
|
||
| resolve({ | ||
| KibanaMap, | ||
| L, | ||
| ServiceSettings, | ||
| }); | ||
| }); | ||
| return loadModulesPromise; | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/plugins/maps_legacy/public/lazy_load_bundle/lazy/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| // @ts-expect-error | ||
| export { KibanaMap } from '../../map/kibana_map'; | ||
| // @ts-expect-error | ||
| export { ServiceSettings } from '../../map/service_settings'; | ||
| // @ts-expect-error | ||
| export { L } from '../../leaflet'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.