Skip to content

Conversation

@thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Nov 4, 2020

Summary

Closes #82539

makes two fixes:

For maintainers

@thomasneirynck thomasneirynck changed the title Load correct region-maps format Load choropleth layer correctly Nov 4, 2020
@thomasneirynck thomasneirynck added Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.10.0 release_note:skip Skip the PR/issue when compiling release notes blocker v8.0.0 labels Nov 4, 2020
@thomasneirynck thomasneirynck marked this pull request as ready for review November 4, 2020 19:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

  • code review
  • tested upgrade from older region maps saved object
  • tested lazyload bugfix

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
regionMap 260.2KB 260.2KB +16.0B

page load bundle size

id before after diff
regionMap 43.9KB 44.0KB +158.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 0cfcf9f into elastic:master Nov 4, 2020
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Nov 4, 2020
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request Nov 4, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 5, 2020
* master: (127 commits)
  [ILM] Fix breadcrumbs (elastic#82594)
  [UX]Swap env filter with percentile (elastic#82246)
  Add platform's missing READMEs (elastic#82268)
  [Discover] Adding uiMetric to track Visualize link click (elastic#82344)
  [Search] Add used index pattern name to the search agg error field (elastic#82604)
  improve client-side SO client get pooling (elastic#82603)
  [Security Solution] Unskips Overview tests (elastic#82459)
  Embeddables/migrations (elastic#82296)
  [Enterprise Search] Refactor product server route registrations to their own files/folders (elastic#82663)
  Moving reinstall function outside of promise.all (elastic#82672)
  Load choropleth layer correctly (elastic#82628)
  Master  backport elastic#81233 (elastic#82642)
  [Fleet] Allow snake cased Kibana assets (elastic#77515)
  Reduce saved objects authorization checks (elastic#82204)
  [data.search] Add request handler context and asScoped pattern (elastic#80775)
  [ML] Fixes formatting of fields in index data visualizer (elastic#82593)
  Usage collector readme (elastic#82548)
  [Lens] Visualization validation and better error messages (elastic#81439)
  [ML] Add annotation markers to time series brush area to indicate annotations exist outside of selected range (elastic#81490)
  chore(NA): install microdnf in UBI docker build only (elastic#82611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker release_note:skip Skip the PR/issue when compiling release notes Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.10.0 v7.11.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgraded region maps display Error downloading vector data error

4 participants