Skip to content

Conversation

@parkiino
Copy link
Contributor

@parkiino parkiino commented Jul 23, 2020

Summary

  • Changes text when saving a policy to say "Saving these changes will apply updates to all endpoints assigned to this policy"
  • Removes duplicate subtext

Screenshots
BEFORE
image
AFTER

image

Issues:

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@parkiino parkiino added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.9.0 labels Jul 23, 2020
@parkiino parkiino requested review from a team as code owners July 23, 2020 20:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB -689.0B 7.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino merged commit 47b3a94 into elastic:master Jul 24, 2020
@parkiino parkiino deleted the task/policy-save-modal-text-change branch July 24, 2020 00:58
parkiino added a commit to parkiino/kibana that referenced this pull request Jul 24, 2020
…ove duplicate policy details text (elastic#73130)

[Security Solution][Endpoint] updates policy details text
parkiino added a commit that referenced this pull request Jul 24, 2020
…ove duplicate policy details text (#73130) (#73176)

[Security Solution][Endpoint] updates policy details text
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 27, 2020
* master: (111 commits)
  Remove flaky note from gauge tests (elastic#73240)
  Convert functional vega tests to ts and unskip tests (elastic#72238)
  [Graph] Unskip graph tests (elastic#72291)
  Add default Elasticsearch credentials to docs (elastic#72617)
  [APM] Read body from indicesStats in upload-telemetry-data (elastic#72732)
  The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (elastic#72766)
  [KP] use new ES client in SO service (elastic#72289)
  [Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (elastic#72995)
  Return EUI CSS to Shareable Runtime (elastic#72990)
  Removed useless karma test (elastic#73190)
  [INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (elastic#73082)
  [Ingest Manager] Support DEGRADED state in fleet agent event (elastic#73104)
  [Security Solution][Detections] Change detections breadcrumb title (elastic#73059)
  [ML] Fixing unnecessary deleting job polling (elastic#73087)
  [ML] Fixing recognizer wizard create job button (elastic#73025)
  [Composable template] Preview composite template (elastic#72598)
  [Uptime] Use manual intervals for ping histogram (elastic#72928)
  [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (elastic#73130)
  [Maps] fix tile layer attibution text and attribution link validation errors (elastic#73160)
  skip ingest pipeline api tests
  ...
efreeti pushed a commit to efreeti/kibana that referenced this pull request Nov 16, 2020
…ove duplicate policy details text (elastic#73130)

[Security Solution][Endpoint] updates policy details text
# Conflicts:
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx
efreeti added a commit that referenced this pull request Nov 16, 2020
…e, remove duplicate policy details text (#73130) (#83431)

* [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (#73130)

[Security Solution][Endpoint] updates policy details text
# Conflicts:
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx

* Removed unused labels to fix the build.

Co-authored-by: Candace Park <[email protected]>
efreeti pushed a commit to efreeti/kibana that referenced this pull request Nov 16, 2020
…ove duplicate policy details text (elastic#73130)

[Security Solution][Endpoint] updates policy details text
# Conflicts:
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx
efreeti added a commit that referenced this pull request Nov 17, 2020
…ge, remove duplicate policy details text (#73130) (#83470)

* [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (#73130)

[Security Solution][Endpoint] updates policy details text
# Conflicts:
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx
#	x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx

* Removed unused labels to fix the build.

Co-authored-by: Candace Park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants