[7.x] [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (#73130) #83431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove duplicate policy details text (elastic#73130) [Security Solution][Endpoint] updates policy details text # Conflicts: # x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.test.tsx # x-pack/plugins/security_solution/public/management/pages/policy/view/policy_details.tsx
parkiino
reviewed
Nov 16, 2020
| textAlign="left" | ||
| title={typeTitle} | ||
| > | ||
| <EuiCard description data-test-subj={dataTestSubj} textAlign="left" title={typeTitle}> |
Contributor
There was a problem hiding this comment.
i guess we should remove description? i think i forgot to do it last time
Contributor
Author
There was a problem hiding this comment.
Umm, I tried in my own PR but it causes issues.
Contributor
There was a problem hiding this comment.
oh wait, i think it's required for an EuiCard so you're good to good. nvm mind that comment!
parkiino
approved these changes
Nov 16, 2020
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: