[Graph] Unskip graph tests #72291
Merged
[Graph] Unskip graph tests #72291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Graph
Contributor
Author
Contributor
Author
|
New flaky runner after fix: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/610/console |
Contributor
Author
Contributor
Author
|
Next flaky runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/622/console |
💚 Build Succeeded
Expand to view the summary
Build stats
|
flash1293
added
the
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
@elasticmachine merge upstream |
mbondyra
approved these changes
Jul 27, 2020
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 27, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jul 27, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 27, 2020
* master: (111 commits) Remove flaky note from gauge tests (elastic#73240) Convert functional vega tests to ts and unskip tests (elastic#72238) [Graph] Unskip graph tests (elastic#72291) Add default Elasticsearch credentials to docs (elastic#72617) [APM] Read body from indicesStats in upload-telemetry-data (elastic#72732) The directory in the command was missing the /generated directory and would cause all definitions to be regenerated in the wrong place. (elastic#72766) [KP] use new ES client in SO service (elastic#72289) [Security Solution][Exceptions] Prevents value list entries from co-existing with non value list entries (elastic#72995) Return EUI CSS to Shareable Runtime (elastic#72990) Removed useless karma test (elastic#73190) [INGEST_MANAGER] Make package config name blank for endpoint on Package Config create (elastic#73082) [Ingest Manager] Support DEGRADED state in fleet agent event (elastic#73104) [Security Solution][Detections] Change detections breadcrumb title (elastic#73059) [ML] Fixing unnecessary deleting job polling (elastic#73087) [ML] Fixing recognizer wizard create job button (elastic#73025) [Composable template] Preview composite template (elastic#72598) [Uptime] Use manual intervals for ping histogram (elastic#72928) [Security Solution][Endpoint] Task/policy save modal text change, remove duplicate policy details text (elastic#73130) [Maps] fix tile layer attibution text and attribution link validation errors (elastic#73160) skip ingest pipeline api tests ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 27, 2020
* master: simplified buffer tests to reduce flakyness (elastic#73024) Remove flaky note from gauge tests (elastic#73240) Convert functional vega tests to ts and unskip tests (elastic#72238) [Graph] Unskip graph tests (elastic#72291)
flash1293
added a commit
that referenced
this pull request
Jul 27, 2020
flash1293
added a commit
that referenced
this pull request
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53749
Unskips the graph tests. This specific test was flaky because it was clicking on a thin line in the workspace. This PR switches to a thicker line making it easier to hit.
Old test was using the left line, new test is using the right one:
Testing this on the flaky runner showed some other instability. I think it's angular sometimes recreating the HTML element, rendering the reference used in the test stale. This PR fixes that by stopping the layout, fetching a fresh reference, then clicking it without the UI doing any rerenders.