Skip to content

test: 💍 delete a flaky test#70785

Merged
streamich merged 1 commit intoelastic:masterfrom
streamich:fix-64139
Jul 6, 2020
Merged

test: 💍 delete a flaky test#70785
streamich merged 1 commit intoelastic:masterfrom
streamich:fix-64139

Conversation

@streamich
Copy link
Contributor

@streamich streamich commented Jul 6, 2020

Closes #64139

That one unit test is not that valuable, so I just delete it.

@streamich streamich requested a review from a team as a code owner July 6, 2020 10:50
@botelastic botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jul 6, 2020
@streamich streamich added release_note:skip Skip the PR/issue when compiling release notes review Team:AppArch v7.9.0 v8.0.0 labels Jul 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich requested a review from ppisljar July 6, 2020 10:51
Copy link
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit 2c27bad into elastic:master Jul 6, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 6, 2020
* master:
  [APM] Fix flaky e2e’s (elastic#70790)
  [Discover] Migrate server side saved object from data to discover plugin (elastic#70342)
  [APM] Update docs on running API tests (elastic#70765)
  test: 💍 delete a flaky test (elastic#70785)
  [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345)
  Remove IE11 mention from PR template [skip ci] (elastic#70486)
  [GS] add savedObjects result provider (elastic#68619)
  remove snapshot from disabled test suite. (elastic#70769)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 7, 2020
* actions/feature:
  improved copy
  [APM] Fix flaky e2e’s (elastic#70790)
  [Discover] Migrate server side saved object from data to discover plugin (elastic#70342)
  [APM] Update docs on running API tests (elastic#70765)
  test: 💍 delete a flaky test (elastic#70785)
  [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345)
  Remove IE11 mention from PR template [skip ci] (elastic#70486)
  [GS] add savedObjects result provider (elastic#68619)
  remove snapshot from disabled test suite. (elastic#70769)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes review v7.9.0 v8.0.0

Projects

None yet

4 participants

Comments