[Discover] Migrate server side saved object from data to discover plugin#70342
Conversation
kertal
added
release_note:skip
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM, also tested it manually on chrome :)
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
Looks fine to me overall, but the saved_objects folder structure should be kept even if there is just a single definition to follow the convention
thx for the reminder, @flash1293, forgot about the convention, changed that 👍 |
flash1293
left a comment
flash1293
left a comment
There was a problem hiding this comment.
LGTM, only code review
|
@elasticmachine merge upstream |
…object-to-discover
|
@elasticmachine merge upstream |
…object-to-discover
lizozom
left a comment
lizozom
left a comment
There was a problem hiding this comment.
Looks great.
Haven't checked out.
Would recommend replacing the search saved object name with something less generic
There was a problem hiding this comment.
//nit
IMO the name is waaay too generic ;-)
There was a problem hiding this comment.
@lizozom i do agree, but I've named it what I was thought is the convention, and it's imported just once to register :) https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md#saved-objects-types
should I go back or celebrate minus of 15 characters here, or should I name it s to celebrate 20chars, and definitely break the convention?
There was a problem hiding this comment.
@lizozom not that I rolled I've renamed this, since the less generic, the better it's searchable
…cover' of github.com:kertal/kibana into kertal-pr-2020-06-30-migrate-search_saved_object-to-discover
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
…object-to-discover
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
* master: [APM] Fix flaky e2e’s (elastic#70790) [Discover] Migrate server side saved object from data to discover plugin (elastic#70342) [APM] Update docs on running API tests (elastic#70765) test: 💍 delete a flaky test (elastic#70785) [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345) Remove IE11 mention from PR template [skip ci] (elastic#70486) [GS] add savedObjects result provider (elastic#68619) remove snapshot from disabled test suite. (elastic#70769)
* actions/feature: improved copy [APM] Fix flaky e2e’s (elastic#70790) [Discover] Migrate server side saved object from data to discover plugin (elastic#70342) [APM] Update docs on running API tests (elastic#70765) test: 💍 delete a flaky test (elastic#70785) [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345) Remove IE11 mention from PR template [skip ci] (elastic#70486) [GS] add savedObjects result provider (elastic#68619) remove snapshot from disabled test suite. (elastic#70769)
6 participants
Summary
Migrate the server side saved object of Discover's saved search and it's registration, from the
dataplugin, to thediscoverplugin.Welcome home buddy, we missed you 🌷 .