Remove IE11 mention from PR template [skip ci]#70486
Merged
timroes merged 3 commits intoelastic:masterfrom Jul 6, 2020
Merged
Conversation
timroes
added
v8.0.0
release_note:skip
peterschretlen
approved these changes
Jul 2, 2020
Contributor
peterschretlen
left a comment
peterschretlen
left a comment
There was a problem hiding this comment.
LGTM.
The change is fine as-is, but it might be worth linking to https://www.elastic.co/support/matrix#matrix_browsers so there is no ambiguity as to what we mean by cross-browser support.
Contributor
Author
|
@elasticmachine merge upstream |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Jul 6, 2020
* Remove IE11 mention from PR template * Add link to browser matrix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
timroes
pushed a commit
that referenced
this pull request
Jul 6, 2020
…ention from PR template [skip ci] (#70486) (#70789) * Improve pull request template proposal (#56756) Looking through Kibana PRs many currently ignore the check boxes or just delete them. The goal here is to make the process easier, delete some unused options and align the checkboxes with what's most useful. We've had some discussions on the Uptime team about ways the PR template could be potentially improved. These changes are based on an extended discussion we had on the topic. We'd love to hear if other teams would be OK with these recommended changes. The changes here are: * Allow authors to just delete unnecessary items rather than strike through. Adding all the `~~` in markdown is painful * Remove the unnecessary checkbox for release notes, the build bot catches this and blocks merges without that being set. * Add a checkbox for testing in various browser sizes / mobile responsive devices * Move IE checkbox to the bottom of the list since it's seldom checked and makes the checklist seem daunting * Remove IE11 mention from PR template [skip ci] (#70486) * Remove IE11 mention from PR template * Add link to browser matrix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Andrew Cholakian <andrew@andrewvc.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 6, 2020
* master: [APM] Fix flaky e2e’s (elastic#70790) [Discover] Migrate server side saved object from data to discover plugin (elastic#70342) [APM] Update docs on running API tests (elastic#70765) test: 💍 delete a flaky test (elastic#70785) [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345) Remove IE11 mention from PR template [skip ci] (elastic#70486) [GS] add savedObjects result provider (elastic#68619) remove snapshot from disabled test suite. (elastic#70769)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 7, 2020
* actions/feature: improved copy [APM] Fix flaky e2e’s (elastic#70790) [Discover] Migrate server side saved object from data to discover plugin (elastic#70342) [APM] Update docs on running API tests (elastic#70765) test: 💍 delete a flaky test (elastic#70785) [Security Solution] Refactor GlobalTime to useGlobalTime hook and cle… (elastic#69345) Remove IE11 mention from PR template [skip ci] (elastic#70486) [GS] add savedObjects result provider (elastic#68619) remove snapshot from disabled test suite. (elastic#70769)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since we're now in the 7.9 release cycle and won't support IE11 from 7.9 onwards anymore, we can remove that mention from the PR checklist. The link also linked to a part of the contribution guideline, that only mentions how to test IE11 locally, so no need linking here anymore. I'd still leave that section in the contribution guideline (for now), in case someone still wants/needs to test for other reasons, or supported versions.