Skip to content

Comments

[Metrics UI] Add context.reason and alertOnNoData to Inventory alerts#70260

Merged
Zacqary merged 6 commits intoelastic:masterfrom
Zacqary:69441-context-reason-port
Jun 30, 2020
Merged

[Metrics UI] Add context.reason and alertOnNoData to Inventory alerts#70260
Zacqary merged 6 commits intoelastic:masterfrom
Zacqary:69441-context-reason-port

Conversation

@Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jun 29, 2020

Summary

Closes #69441

  • Adds context.reason to Inventory alerts, and moves its functionality into the common folder
  • Adds the "Alert me when there's no data" checkbox to Inventory alerts
  • Moves toolbar translations of the names of Snapshot metrics into a common file, so that the Inventory alert executor can access it

@Zacqary Zacqary added release_note:enhancement Feature:Alerting Feature:Metrics UI Metrics UI feature v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 labels Jun 29, 2020
@Zacqary Zacqary requested a review from a team as a code owner June 29, 2020 20:56
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@@ -0,0 +1,207 @@
/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: switch to the implementation in #69757 instead

Zacqary added 3 commits June 30, 2020 11:20
…son-port

# Conflicts:
#	x-pack/plugins/infra/public/alerting/inventory/components/expression.tsx
#	x-pack/plugins/infra/server/lib/alerting/metric_threshold/types.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
infra 598 +2 596

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@phillipb phillipb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zacqary Zacqary merged commit 0047eed into elastic:master Jun 30, 2020
@Zacqary Zacqary deleted the 69441-context-reason-port branch June 30, 2020 21:34
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jul 1, 2020
…-based-rbac

* upstream/master: (38 commits)
  Move logger configuration integration test to jest (elastic#70378)
  Changes observability plugin codeowner (elastic#70439)
  update (elastic#70424)
  [Logs UI] Avoid CCS-incompatible index name resolution (elastic#70179)
  Enable "Explore underlying data" actions for Lens visualizations (elastic#70047)
  Initial work on uptime homepage API (elastic#70135)
  expressions indexPattern function (elastic#70315)
  [Discover] Deangularization context error message refactoring (elastic#70090)
  [Lens] Add "no data" popover (elastic#69147)
  [Lens] Move chart switcher over (elastic#70182)
  chore: add missing mjs extension (elastic#70326)
  [Lens] Multiple y axes (elastic#69911)
  skip flaky suite (elastic#70386)
  fix bug to add timeline to case (elastic#70343)
  [QA][Code Coverage] Drop catchError and use try / catch instead, (elastic#69198)
  [QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (elastic#69348)
  [Metrics UI] Add context.reason and alertOnNoData to Inventory alerts (elastic#70260)
  Resolver refactoring (elastic#70312)
  [Ingest Manager] Fix agent ack after input format change (elastic#70335)
  [eslint][ts] Enable prefer-ts-expect-error (elastic#70022)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Alerting Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Metrics UI] Port {context.reason} to Inventory alerts

4 participants